From: Quanah Gibson-Mount <quanah@openldap.org>
Date: Tue, 17 Mar 2009 17:42:59 +0000 (+0000)
Subject: don't short circuit callback list
X-Git-Tag: OPENLDAP_REL_ENG_2_4_16~16
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=f2e88c34e0e132d636bfdcc0ea6c5089b3945118;p=openldap

don't short circuit callback list
free self in case anything goes wrong
---

diff --git a/contrib/slapd-modules/cloak/cloak.c b/contrib/slapd-modules/cloak/cloak.c
index 5e4f11d0e5..8d29a1579c 100644
--- a/contrib/slapd-modules/cloak/cloak.c
+++ b/contrib/slapd-modules/cloak/cloak.c
@@ -269,8 +269,8 @@ cloak_search( Operation *op, SlapReply *rs )
 
 	sc = op->o_tmpcalloc( 1, sizeof( *sc ), op->o_tmpmemctx );
 	sc->sc_response = cloak_search_cb;
-	sc->sc_cleanup = NULL;
-	sc->sc_next = NULL;
+	sc->sc_cleanup = slap_freeself_cb;
+	sc->sc_next = op->o_callback;
 	sc->sc_private = ci;
 	op->o_callback = sc;