From: Spencer Oliver <spen@spen-soft.co.uk>
Date: Fri, 16 Aug 2013 14:37:32 +0000 (+0100)
Subject: gdb server: do not free tdesc_filename early
X-Git-Tag: v0.8.0-rc1~305
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=f4943acd650a5dea16978cf21132b72bdd0f72c9;p=openocd

gdb server: do not free tdesc_filename early

Issue caught by clang.

Change-Id: I4fb331574512140b36e56b3b7ab7e8bdad5e013d
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/1554
Tested-by: jenkins
---

diff --git a/src/server/gdb_server.c b/src/server/gdb_server.c
index 48015abc..ab7d40d7 100644
--- a/src/server/gdb_server.c
+++ b/src/server/gdb_server.c
@@ -2936,16 +2936,16 @@ COMMAND_HANDLER(handle_gdb_save_tdesc_command)
 
 	int retval = fileio_open(&fileio, tdesc_filename, FILEIO_WRITE, FILEIO_TEXT);
 
-	free(tdesc_filename);
-
 	if (retval != ERROR_OK) {
 		LOG_WARNING("Can't open %s for writing", tdesc_filename);
+		free(tdesc_filename);
 		return ERROR_FAIL;
 	}
 
 	retval = fileio_write(&fileio, tdesc_length, tdesc, &size_written);
 
 	fileio_close(&fileio);
+	free(tdesc_filename);
 
 	if (retval != ERROR_OK) {
 		LOG_WARNING("Error while writing the tdesc file");