From: Orestis Floros <orestisf1993@gmail.com>
Date: Sun, 16 Dec 2018 01:27:09 +0000 (+0200)
Subject: Fix: render_con shows floating containers on wrong workspace
X-Git-Tag: 4.16.1~1
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=f7b6ae2836086ed72dde6c44b7ad5d8c918b165b;p=i3%2Fi3

Fix: render_con shows floating containers on wrong workspace

After 204eefc. Alternative fix:
    diff --git a/src/floating.c b/src/floating.c
    index f5c61782..6dd79668 100644
    --- a/src/floating.c
    +++ b/src/floating.c
    @@ -954,7 +954,7 @@ bool floating_reposition(Con *con, Rect newrect) {
             con->scratchpad_state = SCRATCHPAD_CHANGED;

         /* Workspace change will already result in a tree_render. */
    -    if (!reassigned) {
    +    if (!reassigned && workspace_is_visible(con_get_workspace(con))) {
             render_con(con);
             x_push_node(con);
         }
but I don't think that the extra complexity is worth it.

Change in handlers.c because of d2d6d6e0 where the bug also appears.

Fixes #3567
---

diff --git a/src/floating.c b/src/floating.c
index a99d0970..4833466c 100644
--- a/src/floating.c
+++ b/src/floating.c
@@ -907,8 +907,7 @@ bool floating_reposition(Con *con, Rect newrect) {
 
     /* Workspace change will already result in a tree_render. */
     if (!reassigned) {
-        render_con(con, false);
-        x_push_node(con);
+        tree_render();
     }
     return true;
 }