From: mario.six@gdsys.cc Date: Mon, 23 May 2016 07:54:56 +0000 (+0200) Subject: gpio: pca953x: Fix register reading past 8th GPIO X-Git-Tag: v2016.07-rc2~5^2~7 X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=fc76b698736efa9d52e06aa09c03dc8ef10fd581;p=u-boot gpio: pca953x: Fix register reading past 8th GPIO A bug in the pca953x driver prevents correct reading of GPIO input values beyond the 8th GPIO; all values are reported as zero. Setting of GPIO output values is not affected. This patch fixes the reading behavior. Signed-off-by: Mario Six Reviewed-by: Peng Fan Acked-by: Simon Glass --- diff --git a/drivers/gpio/pca953x_gpio.c b/drivers/gpio/pca953x_gpio.c index 065b181bd2..0410add518 100644 --- a/drivers/gpio/pca953x_gpio.c +++ b/drivers/gpio/pca953x_gpio.c @@ -148,11 +148,13 @@ static int pca953x_get_value(struct udevice *dev, unsigned offset) int ret; u8 val = 0; + int off = offset % BANK_SZ; + ret = pca953x_read_single(dev, PCA953X_INPUT, &val, offset); if (ret) return ret; - return (val >> offset) & 0x1; + return (val >> off) & 0x1; } static int pca953x_set_value(struct udevice *dev, unsigned offset,