From: Ilya Yanok Date: Sun, 15 Jul 2012 04:43:51 +0000 (+0000) Subject: usb: check return value of submit_{control, bulk}_msg X-Git-Tag: v2012.07-rc2~9^2~3 X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=fd06028df8a3b48575c9578aa73ab507d451bbc1;p=u-boot usb: check return value of submit_{control, bulk}_msg Return values of submit_{control,bulk}_msg() functions should be checked to detect possible error. Signed-off-by: Ilya Yanok --- diff --git a/common/usb.c b/common/usb.c index 46f4741690..1b40228b28 100644 --- a/common/usb.c +++ b/common/usb.c @@ -188,7 +188,8 @@ int usb_control_msg(struct usb_device *dev, unsigned int pipe, request, requesttype, value, index, size); dev->status = USB_ST_NOT_PROC; /*not yet processed */ - submit_control_msg(dev, pipe, data, size, setup_packet); + if (submit_control_msg(dev, pipe, data, size, setup_packet) < 0) + return -1; if (timeout == 0) return (int)size; @@ -220,7 +221,8 @@ int usb_bulk_msg(struct usb_device *dev, unsigned int pipe, if (len < 0) return -1; dev->status = USB_ST_NOT_PROC; /*not yet processed */ - submit_bulk_msg(dev, pipe, data, len); + if (submit_bulk_msg(dev, pipe, data, len) < 0) + return -1; while (timeout--) { if (!((volatile unsigned long)dev->status & USB_ST_NOT_PROC)) break;