From: Thomas Weber <weber@corscience.de>
Date: Thu, 25 Nov 2010 07:05:29 +0000 (+0100)
Subject: gdsys: osd: Use return value of cmd_usage
X-Git-Tag: v2010.12-rc2~10
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=fd2aa8e2e7cba861097befed7ebd268956211041;p=u-boot

gdsys: osd: Use return value of cmd_usage

Use the return value of cmd_usage instead of ignoring this
and returning a 1.

Signed-off-by: Thomas Weber <weber@corscience.de>
Acked-by: Mike Frysinger <vapier@gentoo.org>
---

diff --git a/board/gdsys/common/osd.c b/board/gdsys/common/osd.c
index 05800ffba4..239c870eff 100644
--- a/board/gdsys/common/osd.c
+++ b/board/gdsys/common/osd.c
@@ -142,8 +142,7 @@ static int osd_print(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	char *text;
 
 	if (argc < 5) {
-		cmd_usage(cmdtp);
-		return 1;
+		return cmd_usage(cmdtp);
 	}
 
 	x = simple_strtoul(argv[1], NULL, 16);
@@ -204,8 +203,7 @@ int osd_write(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	unsigned count = (argc > 4) ?  simple_strtoul(argv[4], NULL, 16) : 1;
 
 	if ((argc < 4) || (strlen(argv[3]) % 4)) {
-		cmd_usage(cmdtp);
-		return 1;
+		return cmd_usage(cmdtp);
 	}
 
 	x = simple_strtoul(argv[1], NULL, 16);