From: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Date: Tue, 21 Nov 2017 22:29:40 +0000 (+0100)
Subject: env: suppress a spurious warning with GCC 7.1
X-Git-Tag: v2018.01-rc1~32
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=fd374665c9b724bb3eb0da32db0bb7ecc5cf1337;p=u-boot

env: suppress a spurious warning with GCC 7.1

GCC 7.1 seems to be smart enough to track val through the various
static inline functions, but not smart enough to see that val will
always be initialised when no error is returned.  This triggers
the following warning:
  env/mmc.c: In function 'mmc_get_env_addr':
  env/mmc.c:121:12: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized]

To make it easier for compiler to understand what is going on, let's
initialise val.

Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---

diff --git a/env/mmc.c b/env/mmc.c
index 3343f9e9f6..ed7bcf16ae 100644
--- a/env/mmc.c
+++ b/env/mmc.c
@@ -73,7 +73,7 @@ static inline s64 mmc_offset(int copy)
 		.partition = "u-boot,mmc-env-partition",
 		.offset = "u-boot,mmc-env-offset",
 	};
-	s64 val, defvalue;
+	s64 val = 0, defvalue;
 	const char *propname;
 	const char *str;
 	int err;