From: Greg King <gregdk@users.sf.net>
Date: Tue, 30 Jun 2015 13:00:28 +0000 (-0400)
Subject: Added comments that explain the unstable behavior of a test program.
X-Git-Tag: V2.16~256^2
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=refs%2Fpull%2F164%2Fhead;p=cc65

Added comments that explain the unstable behavior of a test program.
---

diff --git a/test/misc/Makefile b/test/misc/Makefile
index db643b44c..ca4870663 100644
--- a/test/misc/Makefile
+++ b/test/misc/Makefile
@@ -53,7 +53,7 @@ $(WORKDIR)/sitest%prg: sitest.c
 	-$(CL65) $(subst .,,$(*:.o%=-O%)) $(CC65FLAGS) $< -o $@
 #	-$(SIM65) $(SIM65FLAGS) $@
 $(WORKDIR)/cc65141011%prg: cc65141011.c
-	@echo "FIXME: " $@ "currently will fail."
+	@echo "FIXME: " $@ "currently can fail."
 	$(CL65) $(subst .,,$(*:.o%=-O%)) $(CC65FLAGS) $< -o $@
 	-$(SIM65) $(SIM65FLAGS) $@
 
diff --git a/test/misc/cc65141011.c b/test/misc/cc65141011.c
index 0ee35dc09..26cef7099 100755
--- a/test/misc/cc65141011.c
+++ b/test/misc/cc65141011.c
@@ -1,4 +1,3 @@
-
 /*
   !!DESCRIPTION!! equality problem
   !!ORIGIN!!      Testsuite
@@ -6,32 +5,37 @@
 */
 
 /*
-    different result depending on whether constant is on left or right side
+    Different results, depending on whether constant is on left or right side.
+
+    The optimizer sometimes makes code that executes the right-side expression
+    as eight bits; but then, tests it against the left-side zero as 16 bits.
+    The high-byte is garbage; therefore, that test might, or might not, work.
+    It depends on the platform and the amount of optimization.
 
     http://www.cc65.org/mailarchive/2014-10/11680.html
+    http://www.cc65.org/mailarchive/2014-10/11682.html
     http://www.cc65.org/mailarchive/2014-10/11683.html
 */
 
-#include <stdlib.h>
 #include <stdio.h>
 
 static unsigned char fails = 4;
 static unsigned char bad[3], good[3];
 
-int main(int n, char **args)
+int main(void)
 {
     unsigned char joy_state = 0x7e;
     unsigned a, b;
 
-    /* NOTE: somehow it only fails in the printf statement, the other stuff
+    /* NOTE: It fails in only the printf() statements, the other stuff
              below works! */
-    printf("bad: %u\n", 0 == (joy_state & 1) );
+    printf("bad: %u, ", 0 == (joy_state & 1) );
     printf("good: %u\n", (joy_state & 1) == 0 );
 
     sprintf(bad, "%u", 0 == (joy_state & 1) );
     sprintf(good, "%u", (joy_state & 1) == 0 );
 
-    printf("bad: %u\n", bad[0] - '0' );
+    printf("bad: %u, ", bad[0] - '0' );
     printf("good: %u\n", good[0] - '0' );
 
     fails -= bad[0] - '0';
@@ -40,12 +44,15 @@ int main(int n, char **args)
     if (0 == (joy_state & 1)) fails--;
     if ((joy_state & 1) == 0) fails--;
 
-    printf("fails: %u\n", fails );
+    printf("failures: %u\n", fails );
 
+    /* The above printf() returns a value with a zero high-byte.
+    ** Therefore, the next (broken) statement works (by accident).
+    */
     a = 0 == (joy_state & 1);
     b = (joy_state & 1) == 0;
 
-    printf("a: %u\n", a );
+    printf("a: %u, ", a );
     printf("b: %u\n", b );
 
     return fails;