From: Ingo Bürk <ingo.buerk@tngtech.com>
Date: Wed, 20 Jan 2016 21:28:20 +0000 (+0100)
Subject: Don't grab the buttons on the root window.
X-Git-Tag: 4.12~28^2
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=refs%2Fpull%2F2169%2Fhead;p=i3%2Fi3

Don't grab the buttons on the root window.

We don't actually need to grab the buttons to fix #2097, but doing so
will cause a freeze due to unreleased events.

We partially revert 6f12f02 which avoids the freeze, but doesn't break
functionality.

relates to #2097
fixes #2168
---

diff --git a/src/bindings.c b/src/bindings.c
index 3463f831..351a5862 100644
--- a/src/bindings.c
+++ b/src/bindings.c
@@ -164,10 +164,6 @@ void regrab_all_buttons(xcb_connection_t *conn) {
         xcb_grab_buttons(conn, con->window->id, grab_scrollwheel);
     }
 
-    /* Also grab the root window to allow bindings to work on there as well. */
-    xcb_ungrab_button(conn, XCB_BUTTON_INDEX_ANY, root, XCB_BUTTON_MASK_ANY);
-    xcb_grab_buttons(conn, root, grab_scrollwheel);
-
     xcb_ungrab_server(conn);
 }