]> git.sur5r.net Git - openocd/log
openocd
14 years agoadapter: allow adjusting srst assert with
michal smulski [Sat, 24 Apr 2010 14:50:27 +0000 (16:50 +0200)]
adapter: allow adjusting srst assert with

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agodocs: improve load_image docs
michal smulski [Tue, 20 Apr 2010 20:18:04 +0000 (22:18 +0200)]
docs: improve load_image docs

add docs for missing args.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agodoc: gdb-attach can fix gdb connect issues
Øyvind Harboe [Tue, 20 Apr 2010 07:05:07 +0000 (09:05 +0200)]
doc: gdb-attach can fix gdb connect issues

Flash probing must succeed for e.g. gdb load and automatic
hardware/software breakpoints to work.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agostm32x: allow flash probe on a running target
Andreas Fritiofson [Fri, 16 Apr 2010 23:03:39 +0000 (01:03 +0200)]
stm32x: allow flash probe on a running target

If the flash has not yet been probed and GDB connects while the target is
running, the flash probe triggered by GDB's memory map read will fail. In
that case the returned memory map will be empty, causing a subsequent load
from within GDB to fail. There's not much you can do from GDB to recover,
other than a restart; a 'mon reset init' and manual 'mon flash probe' won't
help since GDB has already made up its mind about the memory map.

It seems there's no reason to require the target to be halted when probing
the flash. Remove the check to let a valid memory map be provided to GDB
even when connecting to a running target.

Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
14 years agoNOR/core bugfix: restore invariants
David Brownell [Fri, 16 Apr 2010 02:48:55 +0000 (19:48 -0700)]
NOR/core bugfix: restore invariants

The The patch labeled "CFI CORE: bug-fix protect single sector" was merged
rged without some requested bugfixes.  Most significantly it broke invariants
in the code, invalidating descriptions and changing the calling convention
for underlying drivers.  (It (Also wasn't CFI-specific...)

Fix that, and Include an update from Antonio Borneo for the degenerate
"nothing to do" case, (although that's still in the  wrong location.  which
is presumably why that is it was working in some cases but not all.)

 src/flash/nor/core.c |   21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
14 years agoNOR/CFI: remove redundant code
Antonio Borneo [Wed, 14 Apr 2010 08:51:16 +0000 (16:51 +0800)]
NOR/CFI: remove redundant code

Arguments for "flash bank" command are already
parsed and put in "bank" struct.
Removed code to parse them again.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoNOR/CFI: fix order of arguments check
Antonio Borneo [Wed, 14 Apr 2010 08:32:30 +0000 (16:32 +0800)]
NOR/CFI: fix order of arguments check

Syntax of "flash bank" command requires:
- chip_width as CMD_ARGV[3]
- bus_width  as CMD_ARGV[4]
Actual code swaps the arguments.
Bug has no run time impact since wrong variables
are only used to check value and both are checked
against same constraint.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoxscale: fix analyze_trace for trace data collected in wrap mode
Mike Dunn [Tue, 13 Apr 2010 17:34:52 +0000 (13:34 -0400)]
xscale: fix analyze_trace for trace data collected in wrap mode

This patch fixes the xscale_analyze_trace() function.  This function was
defective for a trace collected in 'fill' mode (hiccups with repeated
instructions) and completely broken when buffer overflowed in 'wrap' mode.  The
reason for the latter case is that the checkpoint registers were interpreted
incorrectly when two checkpoints are present in the trace (which will be true in
'wrap' mode once the buffer fills).  In this case, checkpoint1 register will
contain the older entry, and checkpoint0 the newer.  The original code assumed
the opposite.  I eventually gave up trying to understand all the logic of the
function, and rewrote it.  I think it's much cleaner and understandable now.  I
have been using and testing this for a few weeks now.  I'm confident it hasn't
regressed in any way.

Also added capability to handle (as best as possible) the case where an
instruction can not be read from the loaded trace image; e.g., partial image.
This was a 'TODO' comment in the original xscale_analyze_trace().

Outside of xcsale_analyze_trace(), these (related) changes were made:

- Remove pc_ok and current_pc elements from struct xscale_trace.  These elements
  and associated logic are useless clutter because the very first entry placed
  in the trace buffer is always an indirect jump to the address at which
  execution resumed.  This type of trace entry includes the literal address in
  the trace buffer, so the initial address of the trace is immediately
  determined from the trace buffer contents and does not need to be recorded
  when trace is enabled.

- Added num_checkpoints to struct xscale_trace_data, which is necessary in order
  to correctly interpret the checkpoint register contents.

- In xscale_read_trace()
  - Fix potential array out-of-bounds condition.
  - Eliminate partial address entries when parsing trace (can occur in wrap mode).
  - Count and record number of checkpoints in trace.

- Added small, inlined utility function xscale_display_instruction() to help
  make the code more concise and clear.

TODO:
 - Save processor state (arm or thumb) in struct xscale_trace when trace is
   enabled so that trace can be analyzed correctly (currently assumes arm mode).
 - Add element to struct xscale_trace that records (when trace is enabled)
   whether vector table is relocated high (to 0xffff0000) or not, so that a
   branch to an exception vector is traced correctly (curently assumes vectors
   at 0x0).

14 years agoTCL SCRIPTS: fix command name
Antonio Borneo [Thu, 15 Apr 2010 09:11:01 +0000 (17:11 +0800)]
TCL SCRIPTS: fix command name

Some tcl script has underline between the words "flash bank"
resulting in 'invalid command name "flash_bank"'.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agocortex-a8: more MMU support
Anton Fedotov [Wed, 14 Apr 2010 05:36:08 +0000 (07:36 +0200)]
cortex-a8: more MMU support

+ virt2phys() can now convert virtual address to real
+ read_memory() and write_memory() are renamed to read_phys_memory()
and write_phys_memory()
+ new read_memory() and write_memory() try to resolve real address if
mmu is enambled than perform real address reading/writing
   + if address is bellow 0xc000000 than TTB0 is used for page table
dereference, if above - than TTB1. Linux style of user/kernel address
separation
   + if above fails (i.e address is unspecified) than mode is checked
whether it is Supervisor (than TTB1) or User (than TTB0)
- Software breakpoints doesn't work. You should invoke
"gdb_breakpoint_override hard" before you start debugging
+ cortex_a8_mmu(), cortex_a8_enable_mmu_caches(),
cortex_a8_disable_mmu_caches() are implemented

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoTARGET/ARM7_9_COMMON: review scope of symbols
Antonio Borneo [Sat, 10 Apr 2010 17:31:42 +0000 (01:31 +0800)]
TARGET/ARM7_9_COMMON: review scope of symbols

Add "static" qualifier to private functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoNOR/TMS470: review scope of symbols
Antonio Borneo [Sat, 10 Apr 2010 17:19:41 +0000 (01:19 +0800)]
NOR/TMS470: review scope of symbols

Add "static" qualifier to private functions and data.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoTARGET/MIPS32: review scope of functions
Antonio Borneo [Sat, 10 Apr 2010 17:16:14 +0000 (01:16 +0800)]
TARGET/MIPS32: review scope of functions

Add "static" qualifier to private functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoTARGET/MIPS32_PRACC: review scope of functions
Antonio Borneo [Sat, 10 Apr 2010 17:11:11 +0000 (01:11 +0800)]
TARGET/MIPS32_PRACC: review scope of functions

Add "static" qualifier to private functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoTARGET/MIPS32_DMAACC: review scope of functions
Antonio Borneo [Sat, 10 Apr 2010 17:03:53 +0000 (01:03 +0800)]
TARGET/MIPS32_DMAACC: review scope of functions

Add "static" qualifier to private functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoHELPER/LOG: review unused symbols
Antonio Borneo [Sat, 10 Apr 2010 14:25:22 +0000 (22:25 +0800)]
HELPER/LOG: review unused symbols

Remove unused functions:
- log_catch
- log_rethrow
- log_try

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoTARGET/MIPS_EJTAG: review scope of functions
Antonio Borneo [Sat, 10 Apr 2010 14:20:41 +0000 (22:20 +0800)]
TARGET/MIPS_EJTAG: review scope of functions

Add "static" qualifier to private functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoNOR/CFI: review scope of functions
Antonio Borneo [Sat, 10 Apr 2010 14:14:34 +0000 (22:14 +0800)]
NOR/CFI: review scope of functions

Add "static" qualifier to private functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoTARGET/DSP563XX_ONCE: review scope of functions
Antonio Borneo [Sat, 10 Apr 2010 14:12:20 +0000 (22:12 +0800)]
TARGET/DSP563XX_ONCE: review scope of functions

Add "static" qualifier to private functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoOPENOCD: review scope of functions
Antonio Borneo [Sat, 10 Apr 2010 14:04:03 +0000 (22:04 +0800)]
OPENOCD: review scope of functions

Add "static" qualifier to private functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoJTAG/COMMANDS: review scope of functions
Antonio Borneo [Sat, 10 Apr 2010 14:01:16 +0000 (22:01 +0800)]
JTAG/COMMANDS: review scope of functions

Add "static" qualifier to private functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoBINARYBUFFER: review scope of data and functions
Antonio Borneo [Sat, 10 Apr 2010 13:54:37 +0000 (21:54 +0800)]
BINARYBUFFER: review scope of data and functions

Add "static" qualifier to private data and functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoNOR/STR7X: review scope of data
Antonio Borneo [Sat, 10 Apr 2010 13:52:33 +0000 (21:52 +0800)]
NOR/STR7X: review scope of data

Add "static" qualifier to private data.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoNAND/TCL: review scope of functions
Antonio Borneo [Sat, 10 Apr 2010 13:50:15 +0000 (21:50 +0800)]
NAND/TCL: review scope of functions

Add "static" qualifier to private functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoMFLASH: review scope of functions
Antonio Borneo [Sat, 10 Apr 2010 12:11:40 +0000 (20:11 +0800)]
MFLASH: review scope of functions

Add "static" qualifier to private functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoNAND/ARM_IO: review scope of functions
Antonio Borneo [Sat, 10 Apr 2010 12:09:59 +0000 (20:09 +0800)]
NAND/ARM_IO: review scope of functions

Add "static" qualifier to private functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoNAND/CORE: review scope of functions
Antonio Borneo [Sat, 10 Apr 2010 12:08:41 +0000 (20:08 +0800)]
NAND/CORE: review scope of functions

Add "static" qualifier to private functions.
Move function's comment from core.h to core.c.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoNAND/MX3: review scope of data
Antonio Borneo [Sat, 10 Apr 2010 12:03:19 +0000 (20:03 +0800)]
NAND/MX3: review scope of data

Add "static" qualifier to private data.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoNOR/ADUC702X: review scope of data
Antonio Borneo [Sat, 10 Apr 2010 11:58:15 +0000 (19:58 +0800)]
NOR/ADUC702X: review scope of data

Add "static" qualifier to private data.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoNOR/AVRF: review scope of data
Antonio Borneo [Sat, 10 Apr 2010 11:56:24 +0000 (19:56 +0800)]
NOR/AVRF: review scope of data

Add "static" qualifier to private data.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoNOR/CORE: review scope of data
Antonio Borneo [Sat, 10 Apr 2010 11:54:22 +0000 (19:54 +0800)]
NOR/CORE: review scope of data

Add "static" qualifier to private data.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoNOR/DRIVERS: review scope of functions
Antonio Borneo [Sat, 10 Apr 2010 11:38:15 +0000 (19:38 +0800)]
NOR/DRIVERS: review scope of functions

Add "static" qualifier to private functions.
Remove unused "extern" in src/ecosboard.c

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoSTR9XPEC: review scope of functions
Antonio Borneo [Sat, 10 Apr 2010 11:29:51 +0000 (19:29 +0800)]
STR9XPEC: review scope of functions

Add "static" qualifier to private functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoTCL: review scope of functions
Antonio Borneo [Sat, 10 Apr 2010 11:28:13 +0000 (19:28 +0800)]
TCL: review scope of functions

Add "static" qualifier to private functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoTIME_SUPPORT: review unused symbols
Antonio Borneo [Sat, 10 Apr 2010 11:25:32 +0000 (19:25 +0800)]
TIME_SUPPORT: review unused symbols

Remove unused functions:
- timeval_add

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoHELLO: review unused symbols
Antonio Borneo [Sat, 10 Apr 2010 09:23:06 +0000 (17:23 +0800)]
HELLO: review unused symbols

Remove unused functions:
- hello_register_commands

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoPLD: review scope of functions
Antonio Borneo [Sat, 10 Apr 2010 09:06:16 +0000 (17:06 +0800)]
PLD: review scope of functions

Add "static" qualifier to private functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoADI_V5_JTAG: review scope of data
Antonio Borneo [Sat, 10 Apr 2010 09:03:02 +0000 (17:03 +0800)]
ADI_V5_JTAG: review scope of data

Add "static" qualifier to private data.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoARM920T: review scope of functions
Antonio Borneo [Sat, 10 Apr 2010 09:01:06 +0000 (17:01 +0800)]
ARM920T: review scope of functions

Add "static" qualifier to private functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoARM_JTAG: review scope of functions
Antonio Borneo [Sat, 10 Apr 2010 08:59:50 +0000 (16:59 +0800)]
ARM_JTAG: review scope of functions

Add "static" qualifier to private functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoARM_SIMULATOR: review scope of functions
Antonio Borneo [Sat, 10 Apr 2010 08:57:49 +0000 (16:57 +0800)]
ARM_SIMULATOR: review scope of functions

Add "static" qualifier to private functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoARMV4_5_MMU: review unused symbols
Antonio Borneo [Sat, 10 Apr 2010 08:46:59 +0000 (16:46 +0800)]
ARMV4_5_MMU: review unused symbols

Remove unused data:
- armv4_5_mmu_page_type_names
Remove prototype of not existing function:
- armv4mmu_translate_va

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoARMV4_5: review scope of data
Antonio Borneo [Sat, 10 Apr 2010 08:46:01 +0000 (16:46 +0800)]
ARMV4_5: review scope of data

Add "static" qualifier to private data.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoEMBEDDEDICE: review scope of functions
Antonio Borneo [Sat, 10 Apr 2010 08:44:54 +0000 (16:44 +0800)]
EMBEDDEDICE: review scope of functions

Add "static" qualifier to private functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoTARGET: review unused symbols
Antonio Borneo [Fri, 9 Apr 2010 16:25:35 +0000 (00:25 +0800)]
TARGET: review unused symbols

Remove unused functions:
- target_all_handle_event

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoTARGET: review scope of functions
Antonio Borneo [Fri, 9 Apr 2010 16:22:46 +0000 (00:22 +0800)]
TARGET: review scope of functions

Add "static" qualifier to private functions.
Remove unused "extern" in src/ecosboard.c

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoARMv7M: review scope of functions
Antonio Borneo [Fri, 9 Apr 2010 16:07:40 +0000 (00:07 +0800)]
ARMv7M: review scope of functions

Add "static" qualifier to private functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoRestore deleted '!' character
David Brownell [Sun, 4 Apr 2010 08:28:50 +0000 (01:28 -0700)]
Restore deleted '!' character

I'm not sure what caused this significant character to get deleted.
it may be related to intermittent Editor or terminal flakes  I've
been seeing lately (sigh).  This fix is trivial.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
14 years agotarget: are we running algorithm code?
David Brownell [Sun, 4 Apr 2010 07:42:05 +0000 (00:42 -0700)]
target: are we running algorithm code?

Fixing one bug can easily uncover another  .... in this case,
making sure that we properly invalidate some cached NOR state when
resuming arbitrary target code turned up an issue when the code
wasn't quite arbitrary (and we couldn't know that, but some parts
of OpenOCD assumed the cache would not be invalidated.

Specifically:  some flash drivers (like CFI) update that state in loops
with downloaded algorithms, thus invalidating the state as it's probed.

 + Add a new target state flag, to record whether the target is
  running downloaded algorithm code.

 + Use that flag to add a special case:  "trust" downloaded algorithms
   not to corrupt that cached state, bypassing cache invalidation.

Also update some of the documentation to stipulate that this flavor of
trustworthiness is now *required* ... not just a fortuitous acident.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
14 years agosimplify and unconfuse target_run_algorithm()
David Brownell [Sun, 4 Apr 2010 07:38:39 +0000 (00:38 -0700)]
simplify and unconfuse target_run_algorithm()

For some reason there are *two* schemes for interposing logic into
the run_algorithm() code path...  One is a standard procedural wapper
around the target method invocation.

the other (superfluous) one hacked the method table by splicing
a second procedural wrapper into the method table.  Remove it:

* Rename its  slightly-more-featureful wrapper so it becomes
  the standard procedural wrapper, leaving its added logic
  (where it should have been in the first place.

          Also add a paranoia check, to report targets that don't
  support algorithms without traversing a NULL pointer, and
  tweak its code structure a bit so it's easier to modify.

* Get rid of the superfluous/conusing method table hacks.

This is a net simplification, making it simpler to analyse what's
going on, and then interpose logic . ... by ensuring there's only one
natural place for it to live.

------------

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
14 years agobuildfix
David Brownell [Sun, 4 Apr 2010 01:36:07 +0000 (18:36 -0700)]
buildfix

Without this, a system using gcc (GCC) 4.2.4 (Ubuntu 4.2.4-1ubuntu4)
aborts builds after reporting:

tcl.c: In function ‘handle_irscan_command’:
tcl.c:1168: warning: passing argument 1 of ‘buf_set_u32’ discards qualifiers from pointer target type

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
14 years agoxscale: fix trace buffer functionality when resuming from a breakpoint
Mike Dunn [Sun, 28 Mar 2010 19:48:32 +0000 (15:48 -0400)]
xscale: fix trace buffer functionality when resuming from a breakpoint

Problem: halt at a breakpoint, enable trace buffer ('xscale trace_buffer enable
fill'), then resume.  Wait for debug exception when trace buffer fills (if not
sooner due to another breakpoint, vector catch, etc).  Instead, never halts.
When halted explicitly from OpenOCD and trace buffer dumped, it contains only
one entry; a branch to the address of the original breakpoint.  If the above
steps are repeated, except that the breakpoint is removed before resuming, the
trace buffer fills and the debug exception is generated, as expected.

Cause: related to how a breakpoint is stepped over on resume.  The breakpoint is
temporarily removed, and a hardware breakpoint is set on the next instruction
that will execute.  xscale_debug_entry() is called when that breakpoint hits.
This function checks if the trace buffer is enabled, and if so reads the trace
buffer from the target and then disables the trace (unless multiple trace
buffers are specified by the user when trace is enabled).  Thus you only trace
one instruction before it is disabled.

Solution: kind of a hack on top of a hack, but it's simple.  Anything better
would involve some refactoring.  This has been tested and trace now works as
intended, except that the very first instruction is not part of the trace when
resuming from a breakpoint.

TODO: still many issues with trace: doesn't work during single-stepping (trace
buffer is flushed each step), 'xscale analyze_trace' works only marginally for
a trace captured in 'fill' mode, and not at all for a trace captured in 'wrap'
mode.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agojtag/tcl.c cleanup -- split out "adapter.c"
David Brownell [Sat, 27 Mar 2010 17:07:13 +0000 (10:07 -0700)]
jtag/tcl.c cleanup -- split out "adapter.c"

Clean up the jtag/tcl.c file, which was one of the biggest and
messiest ones in that directory.  Do it by splitting out all the
generic adapter commands to a separate "adapter.c" file (leaving
the "tcl.c" file holding only JTAG utilities).

Also rename the little-used "jtag interface" to "adapter_name", which
should have been at least re-categorized earlier (it's not jtag-only).

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
14 years agoNOR TCL: fix usage message
Antonio Borneo [Fri, 26 Mar 2010 07:54:33 +0000 (15:54 +0800)]
NOR TCL: fix usage message

The command "flash bank" has updated syntax.
Add the mandatory parameter <target> to the usage message
that prints in case of error.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoTCL scripts: update to current "flash bank" syntax
Antonio Borneo [Fri, 26 Mar 2010 07:17:46 +0000 (15:17 +0800)]
TCL scripts: update to current "flash bank" syntax

While "flash bank" syntax has been changed long ago,
several tcl script are still not fully update.

Fix following cases related with "cfi" driver:
- syntax error: the mandatory <name> parameter is missing
- warning: the <target> parameter is a number, instead of
  the target name
- the comment line above the command does not report
  actual syntax

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agozy1000: dev tool
Øyvind Harboe [Thu, 4 Mar 2010 18:58:42 +0000 (19:58 +0100)]
zy1000: dev tool

first cut peek/poke over tcp/ip, used for debug/research
purposes only. Long term JTAG over TCP/IP might be an
offshoot. The performance is usable for development/testing
purposes.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agotarget: fix poll off
Øyvind Harboe [Thu, 25 Mar 2010 12:06:23 +0000 (13:06 +0100)]
target: fix poll off

I don't know when "poll off" broke, but "poll off" didn't
stop background polling of target. The polling status flag
simply wasn't checked in the handle_target timer callback.

All target polling(including power/reset state) is now stopped
upon "poll off".

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agochange %x and %d to PRIx32 and PRId32 where needed for cygwin
Daniel Bäder [Thu, 25 Mar 2010 10:24:42 +0000 (11:24 +0100)]
change %x and %d to PRIx32 and PRId32 where needed for cygwin

14 years agozy1000: allow it to build on linux host for testing purposes
Øyvind Harboe [Thu, 4 Mar 2010 18:03:26 +0000 (19:03 +0100)]
zy1000: allow it to build on linux host for testing purposes

For testing and checking the build this can be useful,
it doesn't have any practical application outside development.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agotelnet_server: review unused symbols
Antonio Borneo [Wed, 24 Mar 2010 05:45:29 +0000 (13:45 +0800)]
telnet_server: review unused symbols

Remove unused function

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agotelnet_server: review scope of functions
Antonio Borneo [Wed, 24 Mar 2010 05:44:40 +0000 (13:44 +0800)]
telnet_server: review scope of functions

Add "static" qualifier to private functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoFT2232 Messaaging fix
David Brownell [Wed, 24 Mar 2010 23:04:26 +0000 (16:04 -0700)]
FT2232 Messaaging fix

The init cleanup patch overlooked a message which was
wrongly specific to the "usbjtag" layout.  Fix.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
14 years agoserver: review unused symbols
Antonio Borneo [Wed, 24 Mar 2010 04:08:45 +0000 (12:08 +0800)]
server: review unused symbols

Remove unused function

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agoserver: review scope of functions and data
Antonio Borneo [Wed, 24 Mar 2010 04:06:45 +0000 (12:06 +0800)]
server: review scope of functions and data

Add "static" qualifier to private functions and data.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agozy1000: fix optimisaion bug in dcc writes
Øyvind Harboe [Mon, 22 Mar 2010 07:27:03 +0000 (08:27 +0100)]
zy1000: fix optimisaion bug in dcc writes

Introduced & corrected since 0.4.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agofix software breakpoints on xscale
Mike Dunn [Sat, 20 Mar 2010 14:53:47 +0000 (10:53 -0400)]
fix software breakpoints on xscale

This patch fixes xscale software breakpoints by cleaning the dcache and
invalidating the icache after the bkpt instruction is inserted or removed.  The
icache operation is necessary in order to flush the fetch buffers, even if the
icache is disabled (see section 4.2.7 of the xscale core developer's manual).
The dcache is presumed to be enabled; no harm done if not.  The dcache is also
invalidated after cleaning in order to safeguard against a future load of
invalid data, in the event that cache_clean_address points to memory that is
valid and in use.

Also corrected a confusing typo I noticed in a comment.

TODO (or not TODO...?): the xscale's 2K "mini dcache" is not cleaned.  This
cache is not used unless the 'X' bit in the page table entry is set.  This is a
proprietary xscale extension to the ARM architecture.  If a target's OS or
executive makes use of this for memory regions holding code, the breakpoint
problem will persist.  Flushing the mini dcache requires that 2K of valid
cacheable memory (mapped with 'X' bit set) be designated by the user for this
purpose.  The debug handler that gets downloaded to the target will also need to
be extended.

14 years agobitq: fix warning now that out_value is const
Øyvind Harboe [Mon, 22 Mar 2010 06:21:09 +0000 (07:21 +0100)]
bitq: fix warning now that out_value is const

This was an easy one. Just add the missing "const" to a
local variable definition.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoft2232 init mess cleanup
David Brownell [Mon, 22 Mar 2010 05:49:23 +0000 (22:49 -0700)]
ft2232 init mess cleanup

In the ft2232 driver, initialization for many layouts punts to a routine
called usbjtag_init(), instead of a routine specific to each layout.

That routine is  a mess  built around a "what type layout am I" core.
That's a bad design ... in this case, especially so, since it bypasses
the layout-specific dispatch which was just done, and obfuscates the
initialization which is at least somewhat generic, instead of being
specific to the "usbjtag" layout.

Split and document out the generic parts of usbjtag_init(), and make
the rest of those layouts have layout-specific init methods.  Also,
rename usbjtag_reset() ... that also was not specific to the "usbjtag"
layout, and thus contributed to the previous code structure confusion.

(Eventually, all layout-specific code (and method tables) should probably
live in files specific to each layout.  These changes will facilitate
those and other cleanups to this driver.)

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
14 years agoarm breakpoints: amended fix comment
Øyvind Harboe [Sun, 21 Mar 2010 18:20:26 +0000 (19:20 +0100)]
arm breakpoints: amended fix comment

the handling of caches, should be moved into the breakpoint
specific callbacks rather than being plonked into generic
memory write fn's.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agojtag: make out_value const
Øyvind Harboe [Fri, 19 Mar 2010 21:06:01 +0000 (22:06 +0100)]
jtag: make out_value const

Tightens up the jtag_add_xxx_scan() API

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agojtag: move towards making out_value const
Øyvind Harboe [Fri, 19 Mar 2010 21:04:45 +0000 (22:04 +0100)]
jtag: move towards making out_value const

These were relatively straightforward fixes which are
backwards compatible.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoFT2232 comment tweaks
David Brownell [Fri, 19 Mar 2010 17:31:44 +0000 (10:31 -0700)]
FT2232 comment tweaks

Note that the FT4232 chips have four channels not two, and
Elaborate on uses of the additional channels.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
14 years agozy1000: clean up jtag_add_xx_scan fn's
Øyvind Harboe [Fri, 19 Mar 2010 13:47:01 +0000 (14:47 +0100)]
zy1000: clean up jtag_add_xx_scan fn's

The implementation is now more straightforward as the
scan_fields have been greatly simplified over time.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agozy1000: fix bug in end state of DCC writes
Øyvind Harboe [Fri, 19 Mar 2010 13:27:19 +0000 (14:27 +0100)]
zy1000: fix bug in end state of DCC writes

Introduced in latest commits, found by code inspection &
GCC warning.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agojtag: retire jtag_get/set_end_state()
Øyvind Harboe [Thu, 18 Mar 2010 17:53:39 +0000 (18:53 +0100)]
jtag: retire jtag_get/set_end_state()

Voila! This get rids of mysteries about what what
state the TAP is in.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agojtag: remove jtag_get_end_state() usage
Øyvind Harboe [Thu, 18 Mar 2010 17:41:43 +0000 (18:41 +0100)]
jtag: remove jtag_get_end_state() usage

Code inspection indicated what constant end states to
use.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agojtag: get rid of unecessary jtag_get_end_state()
Øyvind Harboe [Thu, 18 Mar 2010 17:37:23 +0000 (18:37 +0100)]
jtag: get rid of unecessary jtag_get_end_state()

By code inspection.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agojtag: remove unecessary usage of jtag_get_end_state().
Øyvind Harboe [Thu, 18 Mar 2010 17:34:34 +0000 (18:34 +0100)]
jtag: remove unecessary usage of jtag_get_end_state().

By code inspection.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agojtag: remove jtag_get_end_state()'s that should be unecessary
Øyvind Harboe [Thu, 18 Mar 2010 17:31:58 +0000 (18:31 +0100)]
jtag: remove jtag_get_end_state()'s that should be unecessary

By a bit of code inspection it seems like all of these
instances of jtag_get_end_state() can be unambigously
replaced by constants.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoFix underlying problem with xscale icache and dcache commands
Mike Dunn [Fri, 19 Mar 2010 04:34:13 +0000 (21:34 -0700)]
Fix underlying problem with xscale icache and dcache commands

Fix problem with the xscale icache and dcache commands.  Both commands were
enabling or disabling the mmu, not the caches

I didn't look any further after my earlier patch fixed the trivial problem
with command argument parsing.  Turns out the underlying code was broken.

The resolution is straightforward when you look at the arguments to
xscale_enable_mmu_caches() and xscale_disable_mmu_caches().  I finally
took a deeper look after dumping the cp15 control register (XSCALE_CTRL)
and seeing that the cache bits weren't changing, but the mmu bit was
(which caused all manner of grief, as you can imagine).  This has been
tested and works OK now.

 src/target/xscale.c |   17 +++++++++++------
 1 files changed, 11 insertions(+), 6 deletions(-)

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
14 years agoADI_v5 - it's not always an "SWJ-DP"
David Brownell [Thu, 18 Mar 2010 19:32:35 +0000 (12:32 -0700)]
ADI_v5 - it's not always an "SWJ-DP"

So don't use the name "swjdp" for all DAPs; rename to
plain old "dap", which *is* always correct.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
14 years agoMerge branch 'master' of ssh://dbrownell@openocd.git.sourceforge.net/gitroot/openocd...
David Brownell [Thu, 18 Mar 2010 19:11:58 +0000 (12:11 -0700)]
Merge branch 'master' of ssh://dbrownell@openocd.git.sourceforge.net/gitroot/openocd/openocd

14 years agoremove more duplication
David Brownell [Thu, 18 Mar 2010 18:56:17 +0000 (11:56 -0700)]
remove more duplication

Not sure how the original "move code to adi_v5_swd.c" patch left
some code in the "arm_adi_v5.c" file, but a recent patch was only
a partial fix -- it didn't remove all the duplication.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
14 years agojtag: retire one instance of jtag_get_end_state() usage
Øyvind Harboe [Thu, 18 Mar 2010 11:07:41 +0000 (12:07 +0100)]
jtag: retire one instance of jtag_get_end_state() usage

Less global variables....

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agooops: committed and pushed two temp files....
Øyvind Harboe [Thu, 18 Mar 2010 11:06:07 +0000 (12:06 +0100)]
oops: committed and pushed two temp files....

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoDOCS: update flash bank examples
Spencer Oliver [Thu, 18 Mar 2010 09:18:53 +0000 (09:18 +0000)]
DOCS: update flash bank examples

 - include the $_FLASHNAME in all flash bank examples.

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
14 years agoPIC32MX: add unlock cmd
Spencer Oliver [Thu, 18 Mar 2010 09:35:45 +0000 (09:35 +0000)]
PIC32MX: add unlock cmd

'unlock' performs a full unlock/erase of the device, removing any
code protection.

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
14 years agoMIPS: remove unused arg from mips_ejtag_set_instr
Spencer Oliver [Wed, 17 Mar 2010 17:24:22 +0000 (17:24 +0000)]
MIPS: remove unused arg from mips_ejtag_set_instr

This arg was never used and was just taken from the arm jtag code.

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
14 years agojtag: cut down on usage of unintended modification of global end state
Øyvind Harboe [Tue, 16 Mar 2010 13:13:03 +0000 (14:13 +0100)]
jtag: cut down on usage of unintended modification of global end state

jtag_get/set_end_state() is now deprecated.

There were lots of places in the code where the end state was
unintentionally modified.

The big Q is whether there were any places where the intention
was to modify the end state. 0.5 is a long way off, so we'll
get a fair amount of testing.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agolinker error: fix problem with duplicate fn
Øyvind Harboe [Wed, 17 Mar 2010 20:50:23 +0000 (21:50 +0100)]
linker error: fix problem with duplicate fn

A fn was copied instead of moved to a new file. The linker
can discard exact copies of fn's without warning.

This is a C++'ism.

However on my Ubuntu 9.10 machine, it fails.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agomips: fix warning
Øyvind Harboe [Wed, 17 Mar 2010 20:34:43 +0000 (21:34 +0100)]
mips: fix warning

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agogdb: long running "monitor mww" now works w/gdb
Øyvind Harboe [Wed, 17 Mar 2010 11:59:33 +0000 (12:59 +0100)]
gdb: long running "monitor mww" now works w/gdb

invoke keep_alive() to make sure that the default 2000ms
timeout does not trigger.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agotarget: faster mww operations
Øyvind Harboe [Tue, 16 Mar 2010 17:02:58 +0000 (18:02 +0100)]
target: faster mww operations

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agotarget: mdX/mwX on target were badly broken
Øyvind Harboe [Wed, 17 Mar 2010 11:43:47 +0000 (12:43 +0100)]
target: mdX/mwX on target were badly broken

- incorrect parsing of arguments
- mdX didn't display arguments correctly

I don't think anyone ever used that code path :-)

Did you know that "target mdw" and mdw are very different?

for {set i 0} {$i < 256} {set i [expr $i+1]} {mwb [expr 0x2000000+$i] $i}

 mdw 0x2000000 0x10
0x02000000: 03020100 07060504 0b0a0908 0f0e0d0c 13121110 17161514 1b1a1918 1f1e1d1c
0x02000020: 23222120 27262524 2b2a2928 2f2e2d2c 33323130 37363534 3b3a3938 3f3e3d3c

> zy1000.cpu mdb 0x2000000 0x20
0x02000000 00 01 02 03 04 05 06 07 08 09 0a 0b 0c 0d 0e 0f ................
0x02000010 10 11 12 13 14 15 16 17 18 19 1a 1b 1c 1d 1e 1f ................
> zy1000.cpu mdh 0x2000000 0x20
0x02000000 0100 0302 0504 0706 0908 0b0a 0d0c 0f0e ................
0x02000010 1110 1312 1514 1716 1918 1b1a 1d1c 1f1e ................
0x02000020 2120 2322 2524 2726 2928 2b2a 2d2c 2f2e  !"#$%&'()*+,-./
0x02000030 3130 3332 3534 3736 3938 3b3a 3d3c 3f3e 0123456789:;<=>?
> zy1000.cpu mdw 0x2000000 0x20
0x02000000 03020100 07060504 0b0a0908 0f0e0d0c ................
0x02000010 13121110 17161514 1b1a1918 1f1e1d1c ................
0x02000020 23222120 27262524 2b2a2928 2f2e2d2c  !"#$%&'()*+,-./
0x02000030 33323130 37363534 3b3a3938 3f3e3d3c 0123456789:;<=>?
0x02000040 43424140 47464544 4b4a4948 4f4e4d4c @ABCDEFGHIJKLMNO
0x02000050 53525150 57565554 5b5a5958 5f5e5d5c PQRSTUVWXYZ[\]^_
0x02000060 63626160 67666564 6b6a6968 6f6e6d6c `abcdefghijklmno
0x02000070 73727170 77767574 7b7a7978 7f7e7d7c pqrstuvwxyz{|}~.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoSCRIPT: add add_script_search_dir cmd
Spencer Oliver [Wed, 17 Mar 2010 09:57:44 +0000 (09:57 +0000)]
SCRIPT: add add_script_search_dir cmd

Add a add_script_search_dir cmd so that adding search
dir's can be added to cfg scripts.

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
14 years agoPIC32: add software reset support
Spencer Oliver [Tue, 16 Mar 2010 12:54:08 +0000 (12:54 +0000)]
PIC32: add software reset support

The PIC32MX does not support the ejtag software reset - it is
optional in the ejtag spec.

We perform the equivalent using the microchip specific MTAP cmd's.

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
14 years agoMIPS: remove ejtag_srst variant
Spencer Oliver [Tue, 16 Mar 2010 12:48:53 +0000 (12:48 +0000)]
MIPS: remove ejtag_srst variant

The mips_m4k_assert_reset has now been restructured
so the variant ejtag_srst is not required anymore.
The ejtag software reset will be used if the target does not
have srst connected.

Remove ejtag_srst from docs.

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
14 years agogdb_server: improved gdb load performance
Øyvind Harboe [Tue, 16 Mar 2010 13:45:07 +0000 (14:45 +0100)]
gdb_server: improved gdb load performance

by ack'ing memory writes immediately and reporting either
at next memory write or stepi/continue time. GDB will then
send off a new packet that is ready by the time the previous
packet has been written to target memory.

On faster adapters this can be as much as 10% improvement.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agozy1000: tweak the DCC inner loop a tiny bit
Øyvind Harboe [Tue, 16 Mar 2010 10:40:52 +0000 (11:40 +0100)]
zy1000: tweak the DCC inner loop a tiny bit

Uses FIFO a bit more efficiently now.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoarm7/9: remove unused post_restore_context
Øyvind Harboe [Tue, 16 Mar 2010 09:58:21 +0000 (10:58 +0100)]
arm7/9: remove unused post_restore_context

Unused. If something should happen after context restore, then the
calling code can just do it afterwards.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>