]> git.sur5r.net Git - openldap/log
openldap
16 years agofix response criticality
Pierangelo Masarati [Mon, 3 Nov 2008 10:41:05 +0000 (10:41 +0000)]
fix response criticality

16 years agoAnother typo
Howard Chu [Mon, 3 Nov 2008 04:39:36 +0000 (04:39 +0000)]
Another typo

16 years agoFix typo in prev commit
Howard Chu [Mon, 3 Nov 2008 04:37:59 +0000 (04:37 +0000)]
Fix typo in prev commit

16 years agoparallel load test (ITS#5709)
Pierangelo Masarati [Sun, 2 Nov 2008 23:48:16 +0000 (23:48 +0000)]
parallel load test (ITS#5709)

16 years agoAdd DBFLAG_CLEAN for a DB that was cleanly shut down; don't bother
Howard Chu [Sun, 2 Nov 2008 23:06:10 +0000 (23:06 +0000)]
Add DBFLAG_CLEAN for a DB that was cleanly shut down; don't bother
scanning to verify contextCSN for clean shutdowns (ITS#5640)

16 years agoITS#5709 forgot to commit this with syncprov.c
Howard Chu [Sun, 2 Nov 2008 22:16:20 +0000 (22:16 +0000)]
ITS#5709 forgot to commit this with syncprov.c

16 years agoadd dontUseCopy and proxiedAuthz "non_critical" disallow switches (ITS#5785)
Pierangelo Masarati [Sun, 2 Nov 2008 21:57:17 +0000 (21:57 +0000)]
add dontUseCopy and proxiedAuthz "non_critical" disallow switches (ITS#5785)

16 years agoadd dontUseCopy and proxiedAuthz "non_critical" disallow switches (ITS#5785)
Pierangelo Masarati [Sun, 2 Nov 2008 21:38:10 +0000 (21:38 +0000)]
add dontUseCopy and proxiedAuthz "non_critical" disallow switches (ITS#5785)

16 years agocontrols can always have criticality set to FALSE (ITS#5785)
Pierangelo Masarati [Sun, 2 Nov 2008 21:06:50 +0000 (21:06 +0000)]
controls can always have criticality set to FALSE (ITS#5785)

16 years agoReally fix ITS#5709 - more explicit check for un-replicatable ops, and
Howard Chu [Sun, 2 Nov 2008 15:26:25 +0000 (15:26 +0000)]
Really fix ITS#5709 - more explicit check for un-replicatable ops, and
don't send ctxcsn update if current maxcsn doesn't match current csn

16 years agobe->be_pcl_mutexp superseded by be->bd_self
Howard Chu [Sun, 2 Nov 2008 07:58:50 +0000 (07:58 +0000)]
be->be_pcl_mutexp superseded by be->bd_self

16 years agoFix ITS#5709, use original pending list
Howard Chu [Sun, 2 Nov 2008 07:46:46 +0000 (07:46 +0000)]
Fix ITS#5709, use original pending list

16 years agobelongs more to informative refs
Pierangelo Masarati [Sat, 1 Nov 2008 17:20:38 +0000 (17:20 +0000)]
belongs more to informative refs

16 years agoallow to override (more than one \!) specs requirements on control criticality (for...
Pierangelo Masarati [Sat, 1 Nov 2008 16:55:45 +0000 (16:55 +0000)]
allow to override (more than one \!) specs requirements on control criticality (for testing purposes; do not advertise)

16 years agoadd "What Failed?" LDAP control (ITS#5784)
Pierangelo Masarati [Sat, 1 Nov 2008 15:15:57 +0000 (15:15 +0000)]
add "What Failed?" LDAP control (ITS#5784)

16 years agoadd "What Failed?" LDAP control (ITS#5784)
Pierangelo Masarati [Sat, 1 Nov 2008 14:42:39 +0000 (14:42 +0000)]
add "What Failed?" LDAP control (ITS#5784)

16 years agouse example.com (RFC2606); mention OpenLDAP-assigned work-in-progress OID
Pierangelo Masarati [Sat, 1 Nov 2008 14:38:23 +0000 (14:38 +0000)]
use example.com (RFC2606); mention OpenLDAP-assigned work-in-progress OID

16 years agomore about ITS#5732
Pierangelo Masarati [Sat, 1 Nov 2008 14:30:14 +0000 (14:30 +0000)]
more about ITS#5732

16 years agoITS#5781 fix modification of MV attrs with no EQ rule
Howard Chu [Thu, 30 Oct 2008 18:22:11 +0000 (18:22 +0000)]
ITS#5781 fix modification of MV attrs with no EQ rule

16 years agoITS#5766 honor principal expiration
Howard Chu [Thu, 30 Oct 2008 15:56:48 +0000 (15:56 +0000)]
ITS#5766 honor principal expiration

16 years agos/manageDIT/relax/ (ITS#5780)
Pierangelo Masarati [Thu, 30 Oct 2008 14:16:22 +0000 (14:16 +0000)]
s/manageDIT/relax/ (ITS#5780)

16 years agocheck the length of the value with the right index (blind fix to ITS#5779)
Pierangelo Masarati [Thu, 30 Oct 2008 14:03:47 +0000 (14:03 +0000)]
check the length of the value with the right index (blind fix to ITS#5779)

16 years agoITS#5759 whitespace vs white space - we now use whitespace.
Gavin Henry [Thu, 30 Oct 2008 13:49:11 +0000 (13:49 +0000)]
ITS#5759 whitespace vs white space - we now use whitespace.

16 years agoITS#5774 blind fix for Windows, please test
Howard Chu [Wed, 29 Oct 2008 13:14:10 +0000 (13:14 +0000)]
ITS#5774 blind fix for Windows, please test

16 years agoCleanup: Move snprintf preformatting into unused Statslog() argument
Hallvard Furuseth [Tue, 28 Oct 2008 22:27:53 +0000 (22:27 +0000)]
Cleanup: Move snprintf preformatting into unused Statslog() argument

16 years agoanticipate Statslog to avoid using dangling pointers (ITS#5775) - HEADS-UP: now ...
Pierangelo Masarati [Tue, 28 Oct 2008 22:02:01 +0000 (22:02 +0000)]
anticipate Statslog to avoid using dangling pointers (ITS#5775) - HEADS-UP: now 'ENTRY dn=' may appear also in case the PDU can't be sent

16 years agoITS#5776 prevent duplicate removal of qtask from runqueue.
Rein Tollevik [Tue, 28 Oct 2008 20:33:46 +0000 (20:33 +0000)]
ITS#5776 prevent duplicate removal of qtask from runqueue.

16 years agoremove unnecessary restrictions; minor improvements
Pierangelo Masarati [Tue, 28 Oct 2008 16:56:20 +0000 (16:56 +0000)]
remove unnecessary restrictions; minor improvements

16 years agoadd Dereference Control I.D. (needs xml2rfc)
Pierangelo Masarati [Mon, 27 Oct 2008 20:21:40 +0000 (20:21 +0000)]
add Dereference Control I.D. (needs xml2rfc)

16 years agoaddress ITS#5773 for slapo-rwm(); needs work
Pierangelo Masarati [Sun, 26 Oct 2008 20:47:11 +0000 (20:47 +0000)]
address ITS#5773 for slapo-rwm(); needs work

16 years agonormalize rewritten DN-valued attrs (ITS#5772)
Pierangelo Masarati [Sun, 26 Oct 2008 19:29:36 +0000 (19:29 +0000)]
normalize rewritten DN-valued attrs (ITS#5772)

16 years agofix dangling pointer issue; cleanup as early as possible
Pierangelo Masarati [Sun, 26 Oct 2008 19:24:10 +0000 (19:24 +0000)]
fix dangling pointer issue; cleanup as early as possible

16 years agodon't rely on attribute values in the returned entry: the control may act on attribut...
Pierangelo Masarati [Sat, 25 Oct 2008 11:06:29 +0000 (11:06 +0000)]
don't rely on attribute values in the returned entry: the control may act on attribute values not requested

16 years agoITS#4467: Fix a few wrong uses of snprintf. Also drop an unneeded array init.
Hallvard Furuseth [Fri, 24 Oct 2008 18:57:38 +0000 (18:57 +0000)]
ITS#4467: Fix a few wrong uses of snprintf.  Also drop an unneeded array init.

16 years agoPlug memory leak with dn.regex. Force error for "dn.=pattern". Cleanup.
Hallvard Furuseth [Fri, 24 Oct 2008 18:22:54 +0000 (18:22 +0000)]
Plug memory leak with dn.regex.  Force error for "dn.=pattern".  Cleanup.

16 years agoMore ITS#5734: Handle empty o_req_ndn. flags=>flags&LDAP_LIMITS_MASK in a test.
Hallvard Furuseth [Fri, 24 Oct 2008 18:16:43 +0000 (18:16 +0000)]
More ITS#5734: Handle empty o_req_ndn. flags=>flags&LDAP_LIMITS_MASK in a test.

16 years agoITS#5770: Fix unaligned BerElements: Use BerElementBuffer, not char[size].
Hallvard Furuseth [Fri, 24 Oct 2008 17:52:05 +0000 (17:52 +0000)]
ITS#5770: Fix unaligned BerElements: Use BerElementBuffer, not char[size].

16 years agoITS#4467: Fix snprintf/WHATSLEFT buffer overflow tests.
Hallvard Furuseth [Fri, 24 Oct 2008 13:16:06 +0000 (13:16 +0000)]
ITS#4467: Fix snprintf/WHATSLEFT buffer overflow tests.
Also make WHATSLEFT unsigned.

16 years agoITS#4467: Fix ptr += snprintf buffer overflow tests (made out-of-range ptr).
Hallvard Furuseth [Fri, 24 Oct 2008 13:11:10 +0000 (13:11 +0000)]
ITS#4467: Fix ptr += snprintf buffer overflow tests (made out-of-range ptr).
Also avoid a buf[BUFSIZ] initialization.

16 years agoforgot access control...
Pierangelo Masarati [Fri, 24 Oct 2008 10:34:04 +0000 (10:34 +0000)]
forgot access control...

16 years agofix examples
Pierangelo Masarati [Thu, 23 Oct 2008 00:14:34 +0000 (00:14 +0000)]
fix examples

16 years agotag optional stuff
Pierangelo Masarati [Wed, 22 Oct 2008 23:38:09 +0000 (23:38 +0000)]
tag optional stuff

16 years agocheck for overflows
Pierangelo Masarati [Wed, 22 Oct 2008 23:37:34 +0000 (23:37 +0000)]
check for overflows

16 years agoslight fixes and improvements to previous commit
Pierangelo Masarati [Wed, 22 Oct 2008 23:01:20 +0000 (23:01 +0000)]
slight fixes and improvements to previous commit

16 years agoadd support for (experimental) dereference control (ITS#5768); need to re-run autocon...
Pierangelo Masarati [Wed, 22 Oct 2008 22:19:49 +0000 (22:19 +0000)]
add support for (experimental) dereference control (ITS#5768); need to re-run autoconf (and autoheader?)

16 years agosave one copy (please review)
Pierangelo Masarati [Wed, 22 Oct 2008 21:58:59 +0000 (21:58 +0000)]
save one copy (please review)

16 years agomissing $OpenLDAP$ header
Pierangelo Masarati [Wed, 22 Oct 2008 21:57:28 +0000 (21:57 +0000)]
missing $OpenLDAP$ header

16 years agoITS#5748: tavl_find3(NULL,,,) returned undefined data
Hallvard Furuseth [Wed, 22 Oct 2008 19:39:42 +0000 (19:39 +0000)]
ITS#5748: tavl_find3(NULL,,,) returned undefined data

16 years agoolcLogFile missing from olcGlobal (ITS#5765)
Pierangelo Masarati [Wed, 22 Oct 2008 11:54:46 +0000 (11:54 +0000)]
olcLogFile missing from olcGlobal (ITS#5765)

16 years agoITS#4467: Fix buffer overflow tests with snprintf / 'unsigned WHATSLEFT'<=0.
Hallvard Furuseth [Tue, 21 Oct 2008 19:00:44 +0000 (19:00 +0000)]
ITS#4467: Fix buffer overflow tests with snprintf / 'unsigned WHATSLEFT'<=0.
Add ptr_APPEND_*. Rename limits_unparse:lm->style, make type/style unsigned.

16 years agoCleanup:
Hallvard Furuseth [Tue, 21 Oct 2008 18:57:16 +0000 (18:57 +0000)]
Cleanup:
Add lmpats_out[] to simplify limits2str().  Wrap both in #ifdef LDAP_DEBUG.
Change char *lmpats[] to struct berval[].  Remove always-true compare.
Readability: Add STRSTART, rearrange limits_get, fix comments & long lines.

16 years agoreset ld->ld_errno to avoid returning error codes of previously API calls (ITS#5762)
Ralf Haferkamp [Tue, 21 Oct 2008 16:17:41 +0000 (16:17 +0000)]
reset ld->ld_errno to avoid returning error codes of previously API calls (ITS#5762)

16 years agoadd optional URI to allow restricting the scope of application of a specific dynamic...
Pierangelo Masarati [Tue, 21 Oct 2008 11:30:04 +0000 (11:30 +0000)]
add optional URI to allow restricting the scope of application of a specific dynamic list expansion rule (ITS#5761)

16 years agopreserve objectClasses not to be removed (ITS#5760)
Pierangelo Masarati [Tue, 21 Oct 2008 07:56:17 +0000 (07:56 +0000)]
preserve objectClasses not to be removed (ITS#5760)

16 years agoITS#5755 values from slapd.conf aren't all strictly validated; detect and
Howard Chu [Tue, 21 Oct 2008 04:42:25 +0000 (04:42 +0000)]
ITS#5755 values from slapd.conf aren't all strictly validated; detect and
report syntax errors when generating LDAP format.

16 years agoITS#5734: Search limits by baseDN - limits dn.this="..."
Hallvard Furuseth [Tue, 21 Oct 2008 00:04:44 +0000 (00:04 +0000)]
ITS#5734: Search limits by baseDN - limits dn.this="..."

16 years agodeal with known controls that need special handling of response (ITS#5757)
Pierangelo Masarati [Mon, 20 Oct 2008 23:51:59 +0000 (23:51 +0000)]
deal with known controls that need special handling of response (ITS#5757)

16 years agobackout ITS#5758 commit
Pierangelo Masarati [Mon, 20 Oct 2008 23:19:07 +0000 (23:19 +0000)]
backout ITS#5758 commit

16 years agoNO-OP must be critical and apply to selected operations (ITS#5758)
Pierangelo Masarati [Mon, 20 Oct 2008 23:16:40 +0000 (23:16 +0000)]
NO-OP must be critical and apply to selected operations (ITS#5758)

16 years agodeclare support for read controls (ITS#5757)
Pierangelo Masarati [Mon, 20 Oct 2008 21:15:13 +0000 (21:15 +0000)]
declare support for read controls (ITS#5757)

16 years agoreturn LDAP_OTHER if the filter cannot be parsed (ITS#5751)
Pierangelo Masarati [Sun, 19 Oct 2008 21:23:06 +0000 (21:23 +0000)]
return LDAP_OTHER if the filter cannot be parsed (ITS#5751)

16 years agodefault to simple bind when -D is specified and no SASL-related options are used...
Pierangelo Masarati [Sun, 19 Oct 2008 21:15:24 +0000 (21:15 +0000)]
default to simple bind when -D is specified and no SASL-related options are used (ITS#5753)

16 years agoadd ldapurl command
Pierangelo Masarati [Sun, 19 Oct 2008 20:35:18 +0000 (20:35 +0000)]
add ldapurl command

16 years agoWarning cleanup: signed meets unsigned: SASL struct propval {unsigned nvalues}.
Hallvard Furuseth [Sat, 18 Oct 2008 23:59:53 +0000 (23:59 +0000)]
Warning cleanup: signed meets unsigned: SASL struct propval {unsigned nvalues}.

16 years agoITS#4467: Fix snprintf buffer overflow test for olcDbQuarantine output.
Hallvard Furuseth [Sat, 18 Oct 2008 23:49:28 +0000 (23:49 +0000)]
ITS#4467: Fix snprintf buffer overflow test for olcDbQuarantine output.
Overrides previous patch which partly fixed it: it was a no-op test before.

16 years agoWarning cleanup to ITS#5695/rev 1.453: signed meets unsigned.
Hallvard Furuseth [Sat, 18 Oct 2008 20:25:57 +0000 (20:25 +0000)]
Warning cleanup to ITS#5695/rev 1.453: signed meets unsigned.

16 years agoFix Debug format (%d, size_t) => (%lu, (unsigned long)value).
Hallvard Furuseth [Sat, 18 Oct 2008 11:42:13 +0000 (11:42 +0000)]
Fix Debug format (%d, size_t) => (%lu, (unsigned long)value).
Warning cleanup: signed meets unsigned.

16 years agoSpell check
Gavin Henry [Sat, 18 Oct 2008 11:20:44 +0000 (11:20 +0000)]
Spell check

16 years agoITS#5750: Fix nameUIDPretty() bitstring in Name and Optional UID syntax.
Hallvard Furuseth [Sat, 18 Oct 2008 11:09:55 +0000 (11:09 +0000)]
ITS#5750: Fix nameUIDPretty() bitstring in Name and Optional UID syntax.
Also update a comment about parsing this syntax.

16 years agoapply Luca Tamburo's patch for Attribute Certificate and X.509 PMI support (with...
Pierangelo Masarati [Sat, 18 Oct 2008 08:33:40 +0000 (08:33 +0000)]
apply Luca Tamburo's patch for Attribute Certificate and X.509 PMI support (with modifications, ITS#5695)

16 years agoWarning cleanup: signed meets unsigned.
Hallvard Furuseth [Sat, 18 Oct 2008 07:21:27 +0000 (07:21 +0000)]
Warning cleanup: signed meets unsigned.

16 years agoITS#5746 - add olcLimits to example, reorganize, enhance uniformity /
Howard Chu [Sat, 18 Oct 2008 02:41:14 +0000 (02:41 +0000)]
ITS#5746 - add olcLimits to example, reorganize, enhance uniformity /
consistency of language

16 years agoWarning cleanup: Signed meets unsigned:
Hallvard Furuseth [Fri, 17 Oct 2008 23:35:44 +0000 (23:35 +0000)]
Warning cleanup: Signed meets unsigned:
Change insertion index bdb_attr_slot(,, unsigned *ins) to int *ins.  This
index is signed elsewhere, including the index returned by the same function.

16 years agoWarning cleanup: signed meets unsigned, remove assert(unsigned >= 0).
Hallvard Furuseth [Fri, 17 Oct 2008 23:24:48 +0000 (23:24 +0000)]
Warning cleanup: signed meets unsigned, remove assert(unsigned >= 0).

16 years agowork in progress. Expand introduction, move slurpd-replacement lower.
Howard Chu [Fri, 17 Oct 2008 22:24:19 +0000 (22:24 +0000)]
work in progress. Expand introduction, move slurpd-replacement lower.
More to come.

16 years agoFix typo
Howard Chu [Fri, 17 Oct 2008 22:02:34 +0000 (22:02 +0000)]
Fix typo

16 years agoITS#5747: Simplify previous fix. Just use the struct hack.
Hallvard Furuseth [Fri, 17 Oct 2008 21:58:09 +0000 (21:58 +0000)]
ITS#5747: Simplify previous fix.  Just use the struct hack.

16 years agoFix Debug(%d, scred->bv_len or -1) -> Debug(%ld, (long) scred->bv_len or -1L).
Hallvard Furuseth [Fri, 17 Oct 2008 20:46:44 +0000 (20:46 +0000)]
Fix Debug(%d, scred->bv_len or -1) -> Debug(%ld, (long) scred->bv_len or -1L).
Cast sasl_encode() arg from unsigned char* to char*.
Warning cleanup: signed meets unsigned.

16 years agoITS#5747: Only use C99 flexible array member when supported
Hallvard Furuseth [Fri, 17 Oct 2008 18:43:10 +0000 (18:43 +0000)]
ITS#5747: Only use C99 flexible array member when supported

16 years agoWarning cleanup: signed meets unsigned.
Hallvard Furuseth [Fri, 17 Oct 2008 18:05:00 +0000 (18:05 +0000)]
Warning cleanup: signed meets unsigned.

16 years agoFix typo in assertion: j1 + j1 -> j1 + j2. (Not a crasher, just wrong test.)
Hallvard Furuseth [Fri, 17 Oct 2008 18:02:09 +0000 (18:02 +0000)]
Fix typo in assertion: j1 + j1 -> j1 + j2. (Not a crasher, just wrong test.)
Warning cleanup: signed meets unsigned.

16 years agoWarning cleanup: Remove no-op bv_len < 0 and bv_len >= 0 tests
Hallvard Furuseth [Fri, 17 Oct 2008 17:40:48 +0000 (17:40 +0000)]
Warning cleanup: Remove no-op bv_len < 0 and bv_len >= 0 tests

16 years agoWarning cleanup: signed meets unsigned. (Adds variable dosearch():outlen.)
Hallvard Furuseth [Fri, 17 Oct 2008 16:35:24 +0000 (16:35 +0000)]
Warning cleanup: signed meets unsigned. (Adds variable dosearch():outlen.)

16 years agoWarning cleanup: signed meets unsigned: Replace BVICMP() with !BV_CASEMATCH().
Hallvard Furuseth [Fri, 17 Oct 2008 16:34:04 +0000 (16:34 +0000)]
Warning cleanup: signed meets unsigned: Replace BVICMP() with !BV_CASEMATCH().
BVICMP() tried (unnecessarily) to return <0 / 0 / >0, but could be unsigned.

16 years agocheck dangling reference (ITS#5742)
Pierangelo Masarati [Fri, 17 Oct 2008 00:07:15 +0000 (00:07 +0000)]
check dangling reference (ITS#5742)

16 years agoleave rs struct untouched (ITS#5742)
Pierangelo Masarati [Fri, 17 Oct 2008 00:06:12 +0000 (00:06 +0000)]
leave rs struct untouched (ITS#5742)

16 years agofix indentation
Pierangelo Masarati [Fri, 17 Oct 2008 00:03:53 +0000 (00:03 +0000)]
fix indentation

16 years agomake sure sr_entry is not used if unset (ITS#5742)
Pierangelo Masarati [Fri, 17 Oct 2008 00:03:17 +0000 (00:03 +0000)]
make sure sr_entry is not used if unset (ITS#5742)

16 years agofix parsing of read entry control (ITS#5741)
Pierangelo Masarati [Fri, 17 Oct 2008 00:02:13 +0000 (00:02 +0000)]
fix parsing of read entry control (ITS#5741)

16 years agominor clarifications
Pierangelo Masarati [Fri, 17 Oct 2008 00:00:46 +0000 (00:00 +0000)]
minor clarifications

16 years agoDefault pagesize is FS dependent
Howard Chu [Wed, 15 Oct 2008 10:56:28 +0000 (10:56 +0000)]
Default pagesize is FS dependent

16 years agoBDB_PAGESIZE not used any more, use BDB/FS default instead
Howard Chu [Wed, 15 Oct 2008 10:45:31 +0000 (10:45 +0000)]
BDB_PAGESIZE not used any more, use BDB/FS default instead

16 years agoFix typo in prev commit
Howard Chu [Wed, 15 Oct 2008 08:24:32 +0000 (08:24 +0000)]
Fix typo in prev commit

16 years agoAdd checksum keyword for enabling checksum validation of DB pages
Howard Chu [Wed, 15 Oct 2008 08:19:33 +0000 (08:19 +0000)]
Add checksum keyword for enabling checksum validation of DB pages

16 years agoAdd checksum keyword to enable DB checksum validation
Howard Chu [Wed, 15 Oct 2008 08:13:56 +0000 (08:13 +0000)]
Add checksum keyword to enable DB checksum validation

16 years agoAdd dbpagesize keyword for configuring DB file page sizes
Howard Chu [Wed, 15 Oct 2008 07:58:48 +0000 (07:58 +0000)]
Add dbpagesize keyword for configuring DB file page sizes

16 years agoAdd dbpagesize keyword for configuring DB file page sizes
Howard Chu [Wed, 15 Oct 2008 07:41:57 +0000 (07:41 +0000)]
Add dbpagesize keyword for configuring DB file page sizes

16 years agoWarning cleanup: signed meets unsigned.
Hallvard Furuseth [Mon, 13 Oct 2008 14:54:27 +0000 (14:54 +0000)]
Warning cleanup: signed meets unsigned.

16 years agoWarning cleanup: signed meets unsigned. ber_flatten2() returns -1 on
Hallvard Furuseth [Mon, 13 Oct 2008 10:18:15 +0000 (10:18 +0000)]
Warning cleanup: signed meets unsigned.  ber_flatten2() returns -1 on
error, not LBER_ERROR.

16 years agoWarning cleanup: signed meets unsigned. ber_flatten2() returns -1 on
Hallvard Furuseth [Mon, 13 Oct 2008 09:17:36 +0000 (09:17 +0000)]
Warning cleanup: signed meets unsigned.  ber_flatten2() returns -1 on
error, not LBER_DEFAULT.