]> git.sur5r.net Git - openldap/log
openldap
11 years agoITS#7512 Plug mdb_txn_abort(nested txn) page leaks.
Hallvard Furuseth [Tue, 19 Feb 2013 21:03:04 +0000 (22:03 +0100)]
ITS#7512 Plug mdb_txn_abort(nested txn) page leaks.

Also catch mdb_cursor_shadow() errors.

11 years agoCheck DB flags when refreshing a stale MDB DBI.
Hallvard Furuseth [Tue, 19 Feb 2013 21:02:37 +0000 (22:02 +0100)]
Check DB flags when refreshing a stale MDB DBI.

It's hairy to figure out when a DBI is valid. Catch destructive
user errors, and flags which another process changed under us.

11 years agomdb_cursor_prev,mdb_cursor_next: Fix return value.
Hallvard Furuseth [Tue, 19 Feb 2013 21:02:15 +0000 (22:02 +0100)]
mdb_cursor_prev,mdb_cursor_next: Fix return value.

Return mdb_node_read()'s return value if it fails, not 1.
(Can happen if mdb_page_get() fails and NDEBUG is #defined.)

11 years agoITS#7515 mdb_dbi_open(): Also open in parent txns.
Hallvard Furuseth [Tue, 19 Feb 2013 21:01:29 +0000 (22:01 +0100)]
ITS#7515 mdb_dbi_open(): Also open in parent txns.

This makes aborting nested and non-nested txns more
similar: The new DBI is available to the surrounding
context (parent txn and MDB_env respectively).

11 years agomdb_page_alloc(): Handle freeDB txnid range holes.
Hallvard Furuseth [Tue, 19 Feb 2013 20:17:33 +0000 (21:17 +0100)]
mdb_page_alloc(): Handle freeDB txnid range holes.

A txn writes no freeDB entry if previous txn dropped mainDB and a read
txn prevents freelist entry reuse. This surprised mdb_page_alloc (and
mdb_txn_commit too before 65c053a6e7f6973c1d09710aa1bd57b218206fcb).

11 years agoITS#7517 Document that dirty DBs may not be closed
Hallvard Furuseth [Tue, 19 Feb 2013 20:15:26 +0000 (21:15 +0100)]
ITS#7517 Document that dirty DBs may not be closed

11 years agoITS#7485 Document key/data size limits in lmdb.h.
Hallvard Furuseth [Tue, 19 Feb 2013 20:14:23 +0000 (21:14 +0100)]
ITS#7485 Document key/data size limits in lmdb.h.

mdb.c already describes them. The user doc should too.

11 years agoRevert "ITS#7515 update parent's mt_next_pgno on child commit"
Hallvard Furuseth [Sun, 17 Feb 2013 07:42:14 +0000 (08:42 +0100)]
Revert "ITS#7515 update parent's mt_next_pgno on child commit"

This reverts commit fd4861bf00fb0b86a9f3b80d16cbe363a8eac227.
It duplicated earlier code.

11 years agoITS#7515 update parent's mt_next_pgno on child commit
Howard Chu [Sun, 17 Feb 2013 00:49:53 +0000 (00:49 +0000)]
ITS#7515 update parent's mt_next_pgno on child commit

11 years agoDon't limit retries when coalescing freelist
Howard Chu [Sun, 17 Feb 2013 00:48:43 +0000 (00:48 +0000)]
Don't limit retries when coalescing freelist

Try to use whatever's available.

11 years agoITS#7515 Fix MDB parent/child txn interaction.
Hallvard Furuseth [Sat, 16 Feb 2013 18:11:20 +0000 (19:11 +0100)]
ITS#7515 Fix MDB parent/child txn interaction.

mdb_txn_commit(child): Copy more state. Copy all of mt_dbs:
Include mainDB, and even freeDB since mdb_drop() can update
it. Don't skip DBs with unchanged root, this could break
when the new was newly opened and the old unused junk.

mdb_page_get(): Search parents' dirty lists.

11 years agoITS#7377 Catch MDB failure updating root pointers.
Hallvard Furuseth [Sat, 16 Feb 2013 18:08:54 +0000 (19:08 +0100)]
ITS#7377 Catch MDB failure updating root pointers.

"cannot fail" was wrong, it fails at least when exceeding mapsize.

11 years agoITS#7517 Don't save dropped dirty MDB databases.
Hallvard Furuseth [Sat, 16 Feb 2013 18:08:37 +0000 (19:08 +0100)]
ITS#7517 Don't save dropped dirty MDB databases.

mdb_txn_commit's attempt to save the DB could corrupt another DB if
another thread had called mdb_dbi_open and reused the closed DBI.

11 years agomdb_stat -ff[f]: show contiguous page spans.
Hallvard Furuseth [Sat, 16 Feb 2013 18:07:16 +0000 (19:07 +0100)]
mdb_stat -ff[f]: show contiguous page spans.

11 years agoAdd error code MDB_MAP_RESIZED.
Hallvard Furuseth [Sat, 16 Feb 2013 18:06:28 +0000 (19:06 +0100)]
Add error code MDB_MAP_RESIZED.

11 years agoDon't memmove freelist entry when chunking it
Howard Chu [Thu, 14 Feb 2013 19:20:45 +0000 (19:20 +0000)]
Don't memmove freelist entry when chunking it

Just advance the pointer, now that it's no longer a complex struct

11 years agoITS#7455 Save freelist in single-page chunks
Hallvard Furuseth [Tue, 12 Feb 2013 11:27:59 +0000 (12:27 +0100)]
ITS#7455 Save freelist in single-page chunks

11 years agoFreelist cleanup/streamlining
Hallvard Furuseth [Wed, 23 Jan 2013 14:47:35 +0000 (15:47 +0100)]
Freelist cleanup/streamlining

Drop unneeded definitions, redundant code.

11 years agoITS#7512 Fix MDB page leak when malloc error.
Hallvard Furuseth [Thu, 7 Feb 2013 07:17:30 +0000 (08:17 +0100)]
ITS#7512 Fix MDB page leak when malloc error.

mdb_page_alloc(): Delay moving me_pgfirst,me_pglast
until malloc(MDB_oldpages to hold the IDs) succeeds.

11 years agoRevert "ITS#7515 fix mdb_dbi_open/close"
Howard Chu [Mon, 4 Feb 2013 18:53:17 +0000 (10:53 -0800)]
Revert "ITS#7515 fix mdb_dbi_open/close"

This reverts commit 48dc782ea612f85e8356a50bfbafe22e5be121cf.

11 years agoMore explicit logging if mdb_txn_commit fails
Howard Chu [Sat, 2 Feb 2013 13:31:39 +0000 (05:31 -0800)]
More explicit logging if mdb_txn_commit fails

Change LDAP_DEBUG_TRACE to LDAP_DEBUG_ANY.
Add log msg if it wasn't being logged before.

11 years agoAdd some simple checks for certificate directories/files
Ralf Haferkamp [Thu, 31 Jan 2013 13:19:39 +0000 (14:19 +0100)]
Add some simple checks for certificate directories/files

11 years agoNULL key is allowed for MDB_CURRENT
Howard Chu [Fri, 1 Feb 2013 14:19:23 +0000 (06:19 -0800)]
NULL key is allowed for MDB_CURRENT

11 years agoITS#7515 fix mdb_dbi_open/close
Howard Chu [Fri, 1 Feb 2013 04:05:48 +0000 (20:05 -0800)]
ITS#7515 fix mdb_dbi_open/close

If a DBI handle is opened by a txn that aborts, the DBI handle
should no longer be valid.

11 years agoITS#7505
Quanah Gibson-Mount [Fri, 1 Feb 2013 00:47:40 +0000 (16:47 -0800)]
ITS#7505

11 years agoMerge remote branch 'origin/mdb.master' into OPENLDAP_REL_ENG_2_4
Quanah Gibson-Mount [Fri, 1 Feb 2013 00:47:15 +0000 (16:47 -0800)]
Merge remote branch 'origin/mdb.master' into OPENLDAP_REL_ENG_2_4

11 years agoITS#7473 fix b1a6f6980f2e5f17a39527069b27dfdc5ee73f8a
Howard Chu [Wed, 30 Jan 2013 01:15:09 +0000 (17:15 -0800)]
ITS#7473 fix b1a6f6980f2e5f17a39527069b27dfdc5ee73f8a

uninit'd size in dn2id_walk, bogus pagedresults

11 years agoITS#7511 make sure cursor is marked valid after successful put
Howard Chu [Tue, 29 Jan 2013 02:45:36 +0000 (18:45 -0800)]
ITS#7511 make sure cursor is marked valid after successful put

11 years agoITS#7505 fix prev commit, partial revert
Howard Chu [Tue, 29 Jan 2013 01:08:24 +0000 (01:08 +0000)]
ITS#7505 fix prev commit, partial revert

11 years agoITS#7473 Sort some test041-aci LDIF output if MDB
Hallvard Furuseth [Mon, 28 Jan 2013 13:25:02 +0000 (14:25 +0100)]
ITS#7473 Sort some test041-aci LDIF output if MDB

11 years agoITS#6164
Quanah Gibson-Mount [Mon, 28 Jan 2013 17:21:36 +0000 (09:21 -0800)]
ITS#6164

11 years agoITS#6164 avoid conn->c_mutex in send_ldap_ber
Howard Chu [Wed, 9 Jan 2013 09:57:48 +0000 (01:57 -0800)]
ITS#6164 avoid conn->c_mutex in send_ldap_ber

11 years agoITS#7505 Fix mdb_update_key when key is too big
Howard Chu [Sun, 27 Jan 2013 17:55:21 +0000 (17:55 +0000)]
ITS#7505 Fix mdb_update_key when key is too big

11 years agoITS#7499
Quanah Gibson-Mount [Sun, 27 Jan 2013 07:12:05 +0000 (23:12 -0800)]
ITS#7499

11 years agoITS#7499 fix typos
Howard Chu [Fri, 25 Jan 2013 14:54:43 +0000 (14:54 +0000)]
ITS#7499 fix typos

11 years agoITS#7499 fix SQL statement configs
Howard Chu [Thu, 24 Jan 2013 01:55:16 +0000 (17:55 -0800)]
ITS#7499 fix SQL statement configs

11 years agoITS#7497
Quanah Gibson-Mount [Sun, 27 Jan 2013 07:11:06 +0000 (23:11 -0800)]
ITS#7497

11 years agoITS#7497 fix lineno overflow in ldif_read_record()
Quanah Gibson-Mount [Sun, 27 Jan 2013 07:06:12 +0000 (23:06 -0800)]
ITS#7497 fix lineno overflow in ldif_read_record()

11 years agoITS#7501 back-ldap keepalive support
Quanah Gibson-Mount [Sun, 27 Jan 2013 03:27:19 +0000 (19:27 -0800)]
ITS#7501 back-ldap keepalive support

11 years agoClean up whitespace in previous commit
Quanah Gibson-Mount [Thu, 24 Jan 2013 19:31:41 +0000 (11:31 -0800)]
Clean up whitespace in previous commit

11 years agoRemoved #if 0 code block
Ted C. Cheng [Thu, 24 Jan 2013 15:12:43 +0000 (07:12 -0800)]
Removed #if 0 code block

11 years agoadded tcp keepalive support to back-ldap
Ted C. Cheng [Thu, 24 Jan 2013 01:10:41 +0000 (17:10 -0800)]
added tcp keepalive support to back-ldap

11 years agoITS#7492
Quanah Gibson-Mount [Sun, 27 Jan 2013 03:25:12 +0000 (19:25 -0800)]
ITS#7492

11 years agoadd support for 'onerr' (ITS#7492)
Pierangelo Masarati [Fri, 11 Jan 2013 23:13:07 +0000 (00:13 +0100)]
add support for 'onerr' (ITS#7492)

11 years agoITS#7473
Quanah Gibson-Mount [Sun, 27 Jan 2013 03:18:43 +0000 (19:18 -0800)]
ITS#7473

11 years agoITS#7473 Scope-based searches
Howard Chu [Sun, 27 Jan 2013 00:17:31 +0000 (16:17 -0800)]
ITS#7473 Scope-based searches

Walk subtree if number of subtree entries is smaller than
number of index candidates.

11 years agoITS#7473 Add mdb_dn2id_walk() to walk subtree
Howard Chu [Sat, 26 Jan 2013 20:32:46 +0000 (20:32 +0000)]
ITS#7473 Add mdb_dn2id_walk() to walk subtree

Non-recursive tree walker.

11 years agoITS#7473 Setup for subtree entry counts
Howard Chu [Thu, 17 Jan 2013 21:01:21 +0000 (21:01 +0000)]
ITS#7473 Setup for subtree entry counts

11 years agoITS#7496, more for ITS#7483
Quanah Gibson-Mount [Sun, 27 Jan 2013 02:59:42 +0000 (18:59 -0800)]
ITS#7496, more for ITS#7483
Fix typo

11 years agoITS#7496
Quanah Gibson-Mount [Sun, 27 Jan 2013 02:43:56 +0000 (18:43 -0800)]
ITS#7496

11 years agoITS#7496, more for ITS#7483
Howard Chu [Tue, 22 Jan 2013 12:31:29 +0000 (12:31 +0000)]
ITS#7496, more for ITS#7483

Missing entries need to be checked at runtime too, not just slapcat.
Apparently some people will still try to run slapd even after slapadd
tells them their DB load was invalid.

11 years agoITS#7493
Quanah Gibson-Mount [Sun, 27 Jan 2013 02:42:00 +0000 (18:42 -0800)]
ITS#7493

11 years agoITS#7490
Quanah Gibson-Mount [Sun, 27 Jan 2013 02:41:09 +0000 (18:41 -0800)]
ITS#7490
Zero out the complete context buffer
From mhardin@symas.com

11 years agoITS#7490
Quanah Gibson-Mount [Thu, 17 Jan 2013 20:05:01 +0000 (12:05 -0800)]
ITS#7490
Zero out the complete context buffer
From mhardin@symas.com

11 years agoClean up whitespace
Quanah Gibson-Mount [Sun, 27 Jan 2013 02:37:29 +0000 (18:37 -0800)]
Clean up whitespace

11 years agomore about ITS#7493
Pierangelo Masarati [Wed, 16 Jan 2013 20:38:33 +0000 (21:38 +0100)]
more about ITS#7493

11 years agos/directoryOperation/dSAOperation/ (ITS#7493)
Michael Stroeder [Wed, 16 Jan 2013 19:31:01 +0000 (20:31 +0100)]
s/directoryOperation/dSAOperation/ (ITS#7493)

11 years agoITS#7489
Quanah Gibson-Mount [Sun, 27 Jan 2013 02:32:20 +0000 (18:32 -0800)]
ITS#7489

11 years agoITS#7473 check DN scope before fetching id2e
Howard Chu [Fri, 11 Jan 2013 11:15:59 +0000 (03:15 -0800)]
ITS#7473 check DN scope before fetching id2e

This is only a 10% gain, but still worth having for now.

11 years agoUpdate slapd.overlays.5 manpage index
Emily Backes [Thu, 10 Jan 2013 23:14:54 +0000 (15:14 -0800)]
Update slapd.overlays.5 manpage index

11 years agoITS#7485
Quanah Gibson-Mount [Sun, 27 Jan 2013 02:28:55 +0000 (18:28 -0800)]
ITS#7485

11 years agoMerge remote branch 'origin/mdb.master' into OPENLDAP_REL_ENG_2_4
Quanah Gibson-Mount [Sun, 27 Jan 2013 02:27:46 +0000 (18:27 -0800)]
Merge remote branch 'origin/mdb.master' into OPENLDAP_REL_ENG_2_4

11 years agoFix MDB_CURRENT updating for dupsort items
Howard Chu [Sat, 26 Jan 2013 18:55:35 +0000 (18:55 +0000)]
Fix MDB_CURRENT updating for dupsort items

11 years agoUpdate MDB comments: Caveats, flags, etc.
Hallvard Furuseth [Wed, 16 Jan 2013 17:42:57 +0000 (18:42 +0100)]
Update MDB comments: Caveats, flags, etc.

11 years agoITS#7485 data sizes limited to 32 bits
Howard Chu [Tue, 15 Jan 2013 12:24:07 +0000 (04:24 -0800)]
ITS#7485 data sizes limited to 32 bits

That's all we have space for in a node record.

11 years agoITS#7485 more size checks
Howard Chu [Mon, 14 Jan 2013 21:46:25 +0000 (13:46 -0800)]
ITS#7485 more size checks

11 years agoITS#7485 check maxkeysize in mdb_cursor_put
Howard Chu [Mon, 14 Jan 2013 21:12:15 +0000 (13:12 -0800)]
ITS#7485 check maxkeysize in mdb_cursor_put

Also MDB_MAXKEYSIZE is redefinable at compile time.

11 years agoHappy New Year
Quanah Gibson-Mount [Mon, 14 Jan 2013 21:09:05 +0000 (13:09 -0800)]
Happy New Year

11 years agoOne more rename
Howard Chu [Mon, 14 Jan 2013 20:57:54 +0000 (12:57 -0800)]
One more rename

Forgot this in 98fe3390891c7577e5f2664a091088786da78ffb

11 years agoMerge remote branch 'origin/mdb.master' into OPENLDAP_REL_ENG_2_4
Quanah Gibson-Mount [Mon, 14 Jan 2013 20:56:03 +0000 (12:56 -0800)]
Merge remote branch 'origin/mdb.master' into OPENLDAP_REL_ENG_2_4

11 years agoITS#7491 check for filled dirty page list
Howard Chu [Fri, 11 Jan 2013 19:45:25 +0000 (11:45 -0800)]
ITS#7491 check for filled dirty page list

Very large single transactions will fail. It's not just a problem when
nested transactions are used. We could make this dynamically sized,
but I'm not sure what the point is.

11 years agoHappy New Year
Howard Chu [Thu, 10 Jan 2013 10:58:55 +0000 (02:58 -0800)]
Happy New Year

11 years agoITS#7476
Quanah Gibson-Mount [Wed, 9 Jan 2013 20:52:38 +0000 (12:52 -0800)]
ITS#7476

11 years agoITS#7476 Prevent EINTR from stopping otherwise successful connect
David Bender [Wed, 19 Dec 2012 07:34:30 +0000 (02:34 -0500)]
ITS#7476 Prevent EINTR from stopping otherwise successful connect

11 years agoITS#7488
Quanah Gibson-Mount [Wed, 9 Jan 2013 20:49:51 +0000 (12:49 -0800)]
ITS#7488

11 years agoITS#7488 disable threaded indexer for now
Howard Chu [Wed, 9 Jan 2013 17:07:29 +0000 (09:07 -0800)]
ITS#7488 disable threaded indexer for now

No time to find the bug at the moment.
There's no performance benefit anyway.

11 years agoITS#7486
Quanah Gibson-Mount [Wed, 9 Jan 2013 20:49:09 +0000 (12:49 -0800)]
ITS#7486

11 years agoclarification about filtering for dynamically added attrs (ITS#7486)
Pierangelo Masarati [Tue, 8 Jan 2013 18:50:33 +0000 (19:50 +0100)]
clarification about filtering for dynamically added attrs (ITS#7486)

11 years agoITS#7487
Quanah Gibson-Mount [Wed, 9 Jan 2013 20:35:58 +0000 (12:35 -0800)]
ITS#7487

11 years agomore about ITS#7487
Pierangelo Masarati [Tue, 8 Jan 2013 16:49:40 +0000 (17:49 +0100)]
more about ITS#7487

11 years agohandle SLAP_MOD_SOFTDEL (ITS#7487) and other internal modification specifiers
Pierangelo Masarati [Tue, 8 Jan 2013 16:39:00 +0000 (17:39 +0100)]
handle SLAP_MOD_SOFTDEL (ITS#7487) and other internal modification specifiers

11 years agoITS#7484
Quanah Gibson-Mount [Wed, 9 Jan 2013 20:33:51 +0000 (12:33 -0800)]
ITS#7484

11 years agofix slapd.conf name (ITS#7484)
Pierangelo Masarati [Sun, 6 Jan 2013 16:14:22 +0000 (17:14 +0100)]
fix slapd.conf name (ITS#7484)

11 years agoMerge remote branch 'origin/mdb.master' into OPENLDAP_REL_ENG_2_4
Quanah Gibson-Mount [Wed, 9 Jan 2013 20:20:29 +0000 (12:20 -0800)]
Merge remote branch 'origin/mdb.master' into OPENLDAP_REL_ENG_2_4

11 years agoDelete liblmdb/mfree. It has moved into mdb_stat.
Hallvard Furuseth [Wed, 9 Jan 2013 19:49:43 +0000 (20:49 +0100)]
Delete liblmdb/mfree. It has moved into mdb_stat.

11 years agoITS#7455 don't give up so soon
Howard Chu [Wed, 9 Jan 2013 16:30:13 +0000 (08:30 -0800)]
ITS#7455 don't give up so soon

If we're operating on the freelist, see if our current pghead
can satisfy the request before giving up and using new pages.

11 years agoITS#7477
Quanah Gibson-Mount [Fri, 4 Jan 2013 16:01:03 +0000 (08:01 -0800)]
ITS#7477

11 years agoITS#7477 check for invalid LDIF
Howard Chu [Fri, 4 Jan 2013 13:09:56 +0000 (05:09 -0800)]
ITS#7477 check for invalid LDIF

11 years agoITS#7483
Quanah Gibson-Mount [Thu, 3 Jan 2013 18:27:10 +0000 (10:27 -0800)]
ITS#7483

11 years agoITS#7483
Howard Chu [Fri, 28 Dec 2012 19:26:26 +0000 (11:26 -0800)]
ITS#7483
Better handling of missing entries

Treat zero-length entries properly (as missing entries) in entry_next()
and entry_get_int().

11 years agoITS#7481
Quanah Gibson-Mount [Thu, 3 Jan 2013 18:23:42 +0000 (10:23 -0800)]
ITS#7481

11 years agoITS#7481 fix nssov-pam-session config
Howard Chu [Sun, 23 Dec 2012 14:11:39 +0000 (06:11 -0800)]
ITS#7481 fix nssov-pam-session config

11 years agoMDB is now called LMDB
Howard Chu [Wed, 19 Dec 2012 21:15:59 +0000 (13:15 -0800)]
MDB is now called LMDB

Lightning Memory-Mapped Database

11 years agoMerge remote branch 'origin/mdb.master' into OPENLDAP_REL_ENG_2_4
Quanah Gibson-Mount [Thu, 3 Jan 2013 18:21:38 +0000 (10:21 -0800)]
Merge remote branch 'origin/mdb.master' into OPENLDAP_REL_ENG_2_4

11 years agoGet MDB txn before acquiring a CSN
Howard Chu [Thu, 13 Dec 2012 15:13:39 +0000 (07:13 -0800)]
Get MDB txn before acquiring a CSN

Since MDB writes are fully serialized in txn_begin, we can use CSNs as
commit sequence numbers, not just change sequence numbers. This will
prevent most instances of out-of-order writes, so syncprov will almost
never need to transmit a change without a cookieCSN. (Out-of-order is
still possible, if the write was received via syncrepl.)

11 years agoFix typo
Howard Chu [Wed, 19 Dec 2012 21:20:24 +0000 (13:20 -0800)]
Fix typo

11 years agoAdd initial mdb utility manpages
Howard Chu [Wed, 19 Dec 2012 21:09:56 +0000 (13:09 -0800)]
Add initial mdb utility manpages

11 years agoMerge remote branch 'origin/mdb.master' into OPENLDAP_REL_ENG_2_4
Quanah Gibson-Mount [Wed, 12 Dec 2012 20:04:25 +0000 (12:04 -0800)]
Merge remote branch 'origin/mdb.master' into OPENLDAP_REL_ENG_2_4

11 years agoinit_meta should write mapsize
Howard Chu [Wed, 12 Dec 2012 06:21:52 +0000 (22:21 -0800)]
init_meta should write mapsize

Was leaving it 0 initially.

11 years agoMerge remote branch 'origin/mdb.master' into OPENLDAP_REL_ENG_2_4
Quanah Gibson-Mount [Wed, 12 Dec 2012 00:02:52 +0000 (16:02 -0800)]
Merge remote branch 'origin/mdb.master' into OPENLDAP_REL_ENG_2_4