]> git.sur5r.net Git - openocd/log
openocd
14 years agoembeddedice: fix error handling
Øyvind Harboe [Mon, 20 Sep 2010 07:40:09 +0000 (09:40 +0200)]
embeddedice: fix error handling

error is now reported at failure site.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoTCL scripts: collect duplicated procedures
Antonio Borneo [Tue, 21 Sep 2010 08:06:37 +0000 (16:06 +0800)]
TCL scripts: collect duplicated procedures

TCL procedures mrw and mmw, originally in DaVinci target code,
are duplicated in other TCL scripts.
Moved in a common helper file, and added help/usage description.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
14 years agostartup: removed capture_catch
Øyvind Harboe [Fri, 10 Sep 2010 09:42:12 +0000 (11:42 +0200)]
startup: removed capture_catch

not used.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agohelper: fix flaky capture command
Øyvind Harboe [Mon, 20 Sep 2010 09:50:32 +0000 (11:50 +0200)]
helper: fix flaky capture command

capture of progress output would get polling
results. This will break in the example below
where polling output would override the tcl
return value.

capture {sleep 10000; set abc def}

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agotcl_server: switch to ctrl-z
Øyvind Harboe [Wed, 8 Sep 2010 18:04:27 +0000 (20:04 +0200)]
tcl_server: switch to ctrl-z

by using ctrl-z instead of line end, multi-line tcl scripts
can be handled.

Testing: send ctrl-z a couple of times to make telnet enter the
mode where it sends ctrl-z unencoded.

Programs that talk to the tcl_server can send ctrl-z to
indicate end of tcl-let to be executed without having
to worry about telnet protocols.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agologging: turn of stdout/stderr buffering
Øyvind Harboe [Fri, 17 Sep 2010 23:37:42 +0000 (01:37 +0200)]
logging: turn of stdout/stderr buffering

with this buffering disabled fancier logging scripts will
be able to process each line as it is output.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agozy1000: add support for Linux host
Øyvind Harboe [Tue, 7 Sep 2010 18:27:45 +0000 (20:27 +0200)]
zy1000: add support for Linux host

used /dev/mem and mmem() to memory map JTAG registers
into user space and used new configure options to exclude
eCos specific code.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agojtag: build jtag first because it generates header files
Øyvind Harboe [Mon, 20 Sep 2010 11:44:03 +0000 (13:44 +0200)]
jtag: build jtag first because it generates header files

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agowarnings: fix alignment warnings
Øyvind Harboe [Fri, 3 Sep 2010 20:49:37 +0000 (22:49 +0200)]
warnings: fix alignment warnings

These warnings are for architectures that do not
support non-aligned word access.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agozy1000: split out configure option for eCos and JTAG master
Øyvind Harboe [Tue, 7 Sep 2010 18:19:05 +0000 (20:19 +0200)]
zy1000: split out configure option for eCos and JTAG master

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agozy1000: remove obsolete debug code
Øyvind Harboe [Tue, 7 Sep 2010 18:22:38 +0000 (20:22 +0200)]
zy1000: remove obsolete debug code

Obsolete code clutter

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agotcl: remove incomplete unused tcl file
Øyvind Harboe [Mon, 20 Sep 2010 07:23:24 +0000 (09:23 +0200)]
tcl: remove incomplete unused tcl file

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoxscale: some wp detail added to user manual
Mike Dunn [Sun, 19 Sep 2010 22:30:59 +0000 (15:30 -0700)]
xscale: some wp detail added to user manual

Hi everyone (again),

Watchpoints on xscale are quirky, so I thought a little explanation in the
user's manual was warranted.

Comments gratefully received.

Last one, Øyvind :-)

Thanks,
Mike

Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
14 years agoxscale: check that wp length does not exceed address
Mike Dunn [Sun, 19 Sep 2010 21:48:51 +0000 (14:48 -0700)]
xscale: check that wp length does not exceed address

Hi everyone,

A while back I sent in a patch that adds support for watchpoint lengths greater
than four on xscale.  It's been working well, until the other day, when it
caused an unexpected debug exception.  Looking into this I realized there is a
case where it breaks: when the length arg is greater than the base address.
This is a consequence of the way the hardware works.  Don't see a work-around,
so I added code to xscale_add_watchpoint() to check for and disallow this
combination.

Some more detail... xscale watchpoint hardware does not support a length
directly.  Instead, a mask value can be specified (not to be confused with the
optional mask arg to the wp command, which xscale does not support).  Any bits
set in the mask are ignored when the watchpoint hardware compares the access
address to the watchpoint address.  So as long as the length is a power of two,
setting the mask to length-1 effectively specifies the length.  Or so I thought,
until I realized that if the length exceeds the base address, *all* bits of the
base address are ignored by the comaparator, and the watchpoint range
effectively becomes 0 .. length.

Questions, comments, criticisms gratefully received.

Thanks,
Mike

Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
14 years agoxscale: bp/wp: additional LOG_ERROR on failure
Mike Dunn [Sun, 19 Sep 2010 21:35:46 +0000 (14:35 -0700)]
xscale: bp/wp: additional LOG_ERROR on failure

Hi everyone,

Added more LOG_ERROR messsages to watchpoint and breakpoint code, given that the
infrastructure no longer interprets returned error codes.  Also changed
existing LOG_INFO and LOG_WARNING to LOG_ERROR for cases where an error is
returned.

Note that the check of the target state is superflous, since the infrastruture
code currently checks this before calling target code.  Is this being
reconsidered as well?  Also, should we stop returning anything other than
ERROR_OK and ERROR_FAIL?

Comments gratefully received.

Thanks,
Mike

Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
14 years agoAM/DM37x: Unify configuration scripts and add support for TI Beagleboard xM.
Karl Kurbjun [Sat, 18 Sep 2010 15:55:29 +0000 (09:55 -0600)]
AM/DM37x: Unify configuration scripts and add support for TI Beagleboard xM.

14 years agocfi: add sst39vf6401b
Flemming Futtrup [Wed, 15 Sep 2010 09:34:57 +0000 (11:34 +0200)]
cfi: add sst39vf6401b

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agobreakpoints: fix error handling
Øyvind Harboe [Mon, 13 Sep 2010 19:59:39 +0000 (21:59 +0200)]
breakpoints: fix error handling

do not try to interpret "retval" into a string, just
amend a bit about the context of the already reported
error.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoboard scripts: Marvell PXA270M processor has a new TAPID: 0x89265013
Takács Áron [Tue, 14 Sep 2010 09:15:35 +0000 (11:15 +0200)]
board scripts: Marvell PXA270M processor has a new TAPID: 0x89265013

the new Marvell PXA270M processor has a new TAPID: 0x89265013.
Attached you will find a patch for target/pxa270.cfg that will handle this.

I have also attached a board/colibri.cfg file to support the Colibri
PXA270 module by Toradex.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoxscale: fix sw breakpoints for thumb; set bp immediately
Mike Dunn [Mon, 13 Sep 2010 19:45:37 +0000 (12:45 -0700)]
xscale: fix sw breakpoints for thumb; set bp immediately

Hi everyone,

Version 2 of this patch.  Code added to breakpoints.c was removed from previous
patch, and item 3 added, per discussion with Øyvind regarding error reporting.
Item 4 added, which I just noticed.

I tried to use a software breakpoint in thumb code on the xscale for the first
time recently, and was surprised to find that it didn't work.  The result was
this patch, which does four things:

1): fix trivial cut-n-paste error that caused thumb breakpoints to not work
2): call xscale_set_breakpoint() from xscale_add_breakpoint()
3): log error on data abort in xscale_write_memory()
4): fixed incorrect error code returned by xscale_set_breakpoint() when no
    breakpoint register is available; added comment

Item 2 not only makes the xscale breakpoint code consistent with other targets,
but also alerts the user immediately if an error occurs when writing the
breakpoint instruction to target memory (previously, xscale_set_breakpoint() was
not called until execution resumed).  Also, calling xscale_breakpoint_set() as
part of the call chain starting with handle_bp_command() and propagating the
return status back up the chain avoids the situation where OpenOCD "thinks" the
breakpoint is set when in reality an error ocurred.

Item 3 provides a helpful message for a common reason for failure to set sw
breakpoint.

This was thoroughly tested, mindful of the fact that breakpoint management is
somewhat dicey during single-stepping.

Comments and criticisms of course gratefully received.

Mike

Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agopropagate return status of set_breakpoint() up call chain
Mike Dunn [Sun, 12 Sep 2010 19:05:07 +0000 (12:05 -0700)]
propagate return status of set_breakpoint() up call chain

Hi everyone,

I figured since I was poking around in the breakpoint code on other arches, I'd
add this change to those arches that don't do it already.  This patch propagates
the return code of <arch>_set_breakpoint() up the call stack.  This ensures that
the higher layer breakpoint infrastructure is aware that an error ocurred, in
which case the breakpoint is not recorded.

Normally I wouldn't touch code that I can't test, but the code is very
uniform across architectures, and the change is rather benign, so I figured
after careful inspection that it is safe.  If the maintainers or others think
this is imprudent, the patch can be dropped.

Also changed the error code to something more appropriate in two cases where
hardware resources are unavailable.

Comments and criticisms of course gratefully received.

Mike

Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agohelper: add stacktrace command that returns error stacktrace
Øyvind Harboe [Sun, 12 Sep 2010 17:29:37 +0000 (19:29 +0200)]
helper: add stacktrace command that returns error stacktrace

Ability to access the stacktrace from a script is quite
handy.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agojim: fix crash when using Jim_ListInsertElements
Øyvind Harboe [Sun, 12 Sep 2010 18:16:55 +0000 (20:16 +0200)]
jim: fix crash when using Jim_ListInsertElements

Jim_ListInsertElements was simply forgotten from the
fn that registered all the APIs.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoversion command: make it scriptable
Øyvind Harboe [Fri, 10 Sep 2010 11:16:13 +0000 (13:16 +0200)]
version command: make it scriptable

you can now set a variable in a script like set version [version].

Also version takes an optional argument "git" to show git version
of source. If git is not installed during the build, then this
will yield an error that is ignored during the build and "version git"
returns an empty string.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agocommand: capture command now handles both types commands
Øyvind Harboe [Fri, 10 Sep 2010 17:28:11 +0000 (19:28 +0200)]
command: capture command now handles both types commands

Commands that output progress output and no return value
will have the progress output captured.

Commands that do not output progress output(tcl commands)
will return the tcl return value instead.

The advantage here is that it is no longer necessary to
consider which command one is capturing, it works for
either.

Example #1: capture progress output:

set foo [capture help]

Example #2: capture tcl return value

set foo [capture {set abc def}]

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agocfi: random crash in cfi_probe() fixed
Øyvind Harboe [Fri, 10 Sep 2010 08:22:14 +0000 (10:22 +0200)]
cfi: random crash in cfi_probe() fixed

for non_cfi cfi chips free() was invoked on rodata.

The mystery is why this bug has survived for so long.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agocfi: tighten up type usage a bit
Øyvind Harboe [Fri, 10 Sep 2010 08:20:06 +0000 (10:20 +0200)]
cfi: tighten up type usage a bit

sizeof() is a bit less scary than seing assumption
about size of type, no bug as such.

Use NULL instead of 0 for pointers. More obvious that
it is a pointer from code inspection.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoxscale: mark xscale registers invalid on debug entry
Mike Dunn [Thu, 9 Sep 2010 02:13:14 +0000 (19:13 -0700)]
xscale: mark xscale registers invalid on debug entry

Hi everyone,

This simple patch fixes a problem I noticed on the xscale where incorrect values
are sometimes reported by the reg command.  The problem can occur when
requesting the value of registers in the xscale-specific register cache.  With a
couple of exceptions, none of the registers in the xscale register cache are
automatically retrieved on debug entry.  This is probably fine, as they are
unlikely to be needed on a regular basis during a typical debug session, and
they can be retrieved when explicitly requested by name using the reg command.
The problem is that once this is done, the register remains marked as valid for
the remainder of the OpenOCD session, and the reg command will henceforth always
report the same value because it is obtained from the cache and is never again
retrieved from the debug handler on the target.

The fix is to mark all registers in the xscale register cache as invalid on
debug entry (before the two exceptions are retrieved), thus forcing retrieval
(when requested) from the target across resumptions in execution, and avoiding
the reporting of stale values.

Small addition change by Øyvind: change 'i' to unsigned to fix compiler
warning for xscale_debug_entry() fn.

Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoRemove duplicated initialization
Alexander Stein [Wed, 8 Sep 2010 08:17:54 +0000 (10:17 +0200)]
Remove duplicated initialization

I a mail conversation with Øyvind we stated that speed may not be set at
all on case CLOCK_MODE_KHZ and CLOCK_MODE_RCLK. Also there isn't proper
error propagation adapter_khz_to_speed or jtag_rclk_to_speed.
So jtag_get_speed may need some rewrite for error propagation.

CC: Øyvind Harboe <oyvind.harboe@zylin.com>
Signed-off-by: Alexander Stein <alexander.stein@informatik.tu-chemnitz.de>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agowarning: fix silly -O3 warning
Øyvind Harboe [Tue, 7 Sep 2010 16:38:06 +0000 (18:38 +0200)]
warning: fix silly -O3 warning

Some versions of GCC don't pick up that local variables
are set in all code paths.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agojtag: fix regression with dummy driver and when starting OpenOCD with target powered...
Øyvind Harboe [Wed, 1 Sep 2010 21:36:31 +0000 (23:36 +0200)]
jtag: fix regression with dummy driver and when starting OpenOCD with target powered down

Do not fail startup if communication with target is
not possible.

OpenOCD supports launching without a target connected
or the target powered down.

The user will typically power up the target and issue
a "reset init" + load his application after OpenOCD
is started then.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoNumonyx M29W160ET patch
Wookey [Tue, 31 Aug 2010 12:53:50 +0000 (13:53 +0100)]
Numonyx M29W160ET patch

Someone called David Carne popped up on IRC and offered a fix (as he's not
on this list so can;t post here). I am just passing it on. (thanx David)

 10:54 < davidc__> Basically; the Numonyx M29W160ET has an incorrect CFI PRI
             block; it describes the erase blocks backwards
 10:54 < davidc__> the linked patch has a fixup for that part [really trivial]:

14 years agocortex m3: add cortex_m3 reset_config cmd
Spencer Oliver [Wed, 25 Aug 2010 19:29:22 +0000 (20:29 +0100)]
cortex m3: add cortex_m3 reset_config cmd

This new cmd adds the ability to choose the Cortex-M3
reset method used.
It defaults to using SRST for reset if available otherwise
it falls back to using NVIC VECTRESET. This is known to work
on all cores.

Move any luminary specific reset handling to the stellaris cfg file.

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
14 years agoflash: increase stellaris flash loader buffer
Spencer Oliver [Tue, 24 Aug 2010 19:52:04 +0000 (20:52 +0100)]
flash: increase stellaris flash loader buffer

This speeds up programming for targets with more working area,

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
14 years agocfg: update Luminary config files
Spencer Oliver [Tue, 24 Aug 2010 19:50:20 +0000 (20:50 +0100)]
cfg: update Luminary config files

 - Update all Luminary config's to use a common target/stellaris.cfg.
 - Add Luminary ek-lm3s6965 config.
 - Increase working area for boards with more ram.

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
14 years agobitq: unshadow pause()
David Brownell [Fri, 27 Aug 2010 22:16:39 +0000 (15:16 -0700)]
bitq: unshadow pause()

bitq.c: In function ‘bitq_scan_field’:
bitq.c:224: error: declaration of ‘pause’ shadows a global declaration
/usr/include/unistd.h:429: error: shadowed declaration is here

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
14 years agoimx35pdk: fix clock and reset delays
Øyvind Harboe [Thu, 19 Aug 2010 14:06:45 +0000 (16:06 +0200)]
imx35pdk: fix clock and reset delays

Use rclk and 100ms delay on ntrst

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agomcb1700: Keil MCB1700 w/1768 config script
Øyvind Harboe [Tue, 17 Aug 2010 19:51:36 +0000 (21:51 +0200)]
mcb1700: Keil MCB1700 w/1768 config script

Ca. 93kBytes/s flashing speed @ 10MHz JTAG clock

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoupdate more Stellaris EK board comments
David Brownell [Mon, 16 Aug 2010 12:25:37 +0000 (08:25 -0400)]
update more Stellaris EK board comments

Using the bundled JTAG/SWD debug support in JTAG mode
is optional on *all* of the EK boards.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
14 years agotwo NEWS updates
David Brownell [Mon, 16 Aug 2010 05:11:39 +0000 (01:11 -0400)]
two NEWS updates

Mention AVR32 AP7000 support.
Clarify ARM semihosting update was for V7M (not ARM9 etc).

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
14 years agoUpdate comments for some Stellaris EK boards.
David Brownell [Mon, 16 Aug 2010 04:36:52 +0000 (00:36 -0400)]
Update comments for some Stellaris EK boards.

These  don't need to use the on-board debuggers in JTAG mode.
Off-board is OK, as would be SWD mode.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
14 years agoavr32: basic target script
Oleksandr Tymoshenko [Sun, 15 Aug 2010 19:55:17 +0000 (21:55 +0200)]
avr32: basic target script

14 years agoat32ap7000 config file
David Brownell [Sun, 15 Aug 2010 19:54:01 +0000 (21:54 +0200)]
at32ap7000 config file

nice board to play with.

14 years agoavr32: work-in-progress
Oleksandr Tymoshenko [Sun, 15 Aug 2010 19:51:34 +0000 (21:51 +0200)]
avr32: work-in-progress

committed so as to ease cooperation and to let it be improved
over time.

So far it supports:
- halt/resume
- registers inspection
- memory inspection/modification

I'm still getting up to speed with OpenOCD internals and AVR32 so code is a little
bit messy and I'd appreciate any feedback.

14 years agoFix typo in usb_blaster_vid_pid error message
Catalin Patulea [Fri, 13 Aug 2010 22:41:18 +0000 (18:41 -0400)]
Fix typo in usb_blaster_vid_pid error message

14 years agoFix typo in documentation of usb_blaster_vid_pid command
Catalin Patulea [Fri, 13 Aug 2010 20:57:37 +0000 (16:57 -0400)]
Fix typo in documentation of usb_blaster_vid_pid command

14 years agolpc1768: turn down the jtag clock
Øyvind Harboe [Fri, 13 Aug 2010 10:59:36 +0000 (12:59 +0200)]
lpc1768: turn down the jtag clock

Tests should that it needs to be as low as 100kHz to be
stable.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoAdded support for the Lisa/L jtag LEDs.
Piotr Esden-Tempski [Wed, 4 Aug 2010 05:04:46 +0000 (22:04 -0700)]
Added support for the Lisa/L jtag LEDs.

14 years agoAdded Lisa/L script as a target board.
Piotr Esden-Tempski [Wed, 4 Aug 2010 04:00:09 +0000 (21:00 -0700)]
Added Lisa/L script as a target board.

14 years agoAdded support for Lisa/L builtin JTAG interface.
Piotr Esden-Tempski [Wed, 4 Aug 2010 03:58:29 +0000 (20:58 -0700)]
Added support for Lisa/L builtin JTAG interface.

14 years agoat91cap7a-stk-sdram.cfg: faster reset
Øyvind Harboe [Thu, 12 Aug 2010 13:01:23 +0000 (15:01 +0200)]
at91cap7a-stk-sdram.cfg: faster reset

crank up JTAG speed as soon as clocks are set up.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agojtag: fix handling of 'tap enable' error
Thomas Koeller [Tue, 10 Aug 2010 12:56:45 +0000 (14:56 +0200)]
jtag: fix handling of 'tap enable' error

if a tap could not be _enabled_, the error message was
'failed to disable tap'. Fixed that. Also, display the failing
tap's name.

Signed-off-by: Thomas Koeller <thomas.koeller@baslerweb.com>
14 years agoDM36x: Set OSCDIV divider
Thomas Koeller [Tue, 10 Aug 2010 12:56:44 +0000 (14:56 +0200)]
DM36x: Set OSCDIV divider

The ability to set up the OSCDIV divider was missing.

Signed-off-by: Thomas Koeller <thomas.koeller@baslerweb.com>
14 years agoDM36x: Disable unused SYSCLKs
Thomas Koeller [Tue, 10 Aug 2010 12:56:43 +0000 (14:56 +0200)]
DM36x: Disable unused SYSCLKs

Clear the enable bits for all clocks that are not set explicitly.
This is done to increase robustness by removing pre-existing
state.

Signed-off-by: Thomas Koeller <thomas.koeller@baslerweb.com>
14 years agoDM36x: Use enable bit for PLL pre-divider
Thomas Koeller [Tue, 10 Aug 2010 12:56:42 +0000 (14:56 +0200)]
DM36x: Use enable bit for PLL pre-divider

The PLL pre- and postdividers seem to have enable bits, although
these are not mentioned in the chip documentation.

Signed-off-by: Thomas Koeller <thomas.koeller@baslerweb.com>
14 years agostr9x: faster flash erase of entire chip
Fredrik Hederstierna [Thu, 12 Aug 2010 06:53:29 +0000 (08:53 +0200)]
str9x: faster flash erase of entire chip

The patch improves flash erase for STR9x in case of a full bank erase.
Then the chip erase command is used instead which improves speed significantly.

Also I think it might help if e.g. STR912 enters some state where flash banks are locked, and a chip erase command is the key for unlocking the flash.

14 years agotcl: remove silly ocd_ prefix to array2mem and mem2array
Øyvind Harboe [Wed, 11 Aug 2010 15:24:55 +0000 (17:24 +0200)]
tcl: remove silly ocd_ prefix to array2mem and mem2array

ocd_ prefix is used internally in OpenOCD as a kludge more
or less to deal with the two kinds of commands that OpenOCD
has.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoboard: added at91cap7a stk w/sdram config scripts
Øyvind Harboe [Wed, 11 Aug 2010 15:09:44 +0000 (17:09 +0200)]
board: added at91cap7a stk w/sdram config scripts

The strange thing here with this board is that 16MHz kinda
works, but only 2MHz is really stable.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agodebug: use assert's when approperiate
Øyvind Harboe [Wed, 11 Aug 2010 09:00:02 +0000 (11:00 +0200)]
debug: use assert's when approperiate

error was returned instead of using assert.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoarm: add missing error reporting
Øyvind Harboe [Wed, 11 Aug 2010 08:58:49 +0000 (10:58 +0200)]
arm: add missing error reporting

when an unknown core mode is read from the target,
report error. Can be communication failure.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoconfig scripts: remove useless reference to OpenOCD docs
Øyvind Harboe [Wed, 11 Aug 2010 08:53:54 +0000 (10:53 +0200)]
config scripts: remove useless reference to OpenOCD docs

clutters config scripts.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agocfg: add omapl138 support and da850evm preliminary support
Ben Gardiner [Mon, 9 Aug 2010 18:41:56 +0000 (14:41 -0400)]
cfg: add omapl138 support and da850evm preliminary support

This patch adds support for the omapl138 target and preliminary support for the da850evm. The
target cfg file is based on the icepick routing done by the target/ti_dm6446.cfg file.

I have performed limited testing with this setup. I am posting this patch in the interest of
sharing cfg files and in the hopes that the experts on this list can correct errors I have made or
point out enhancements.

The testing I have performed is debugging uboot with gdb where I also use the following local.cfg
and gdbinit files. Debugging appears to work in so much as 'ni' works.

local.cfg:
gdb_memory_map disable

gdbinit:
target remote localhost:3333
set remote hardware-breakpoint-limit 2
set remote hardware-watchpoint-limit 2
monitor poll on

Comments welcome.

Best Regards,
Ben Gardiner

14 years agoarm7/9: fix "reset run + halt"
Øyvind Harboe [Sun, 8 Aug 2010 17:21:04 +0000 (19:21 +0200)]
arm7/9: fix "reset run + halt"

if polling is off, then "reset run + halt" would fail
since halt incorrectly assumed the target was in the
reset state as it is the internal poll implementation
that moves the sw tracking of the target state out
of the reset state.

To reproduce:

> reset run; halt
JTAG tap: zy1000.cpu tap/device found: 0x1f0f0f0f (mfg: 0x787, part: 0xf0f0, ver: 0x1)
BUG: arm7/9 does not support halt during reset. This is handled in arm7_9_assert_reset()

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agotarget: if polling fails, back off
Øyvind Harboe [Sun, 8 Aug 2010 07:14:54 +0000 (09:14 +0200)]
target: if polling fails, back off

back-off algorithm for polling. Double polling
interval up to 5000ms when it fails.

when polling succeeds, reset backoff.

This avoids flooding logs(as much) when working
with conditions where the target polling will fail.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoLuminary-icdi comment update
David Brownell [Wed, 4 Aug 2010 01:29:05 +0000 (21:29 -0400)]
Luminary-icdi comment update

Clarify that ICDI is the generic logic, but this config is
for the JTAG-only (no-SWD) mode.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
14 years agoxscale documentation: vector table handling
Mike Dunn [Mon, 2 Aug 2010 19:50:29 +0000 (12:50 -0700)]
xscale documentation: vector table handling

Hi everyone.  I noticed some incorrect information in the user manual
regarding how the vector table is handled on the xscale, so for your
consideration, here's a short patch that corrects it, and adds a
little more detail I thought might be helpful.

The documentation states that OpenOCD does not attempt to synchronize
the vector tables in memory with those stored in the "mini instruction
cache".  In fact, on each resume it does copy from memory to the cache
all entries in the high and low tables that were not previously
defined using the 'xscale vector_table' command. (In
src/target/xscale.c, see xscale_update_vectors(), which is invoked by
xscale_resume().)  I take advantage of this during Linux boot-up.  The
extra detail describes in general terms how I do this.

Corrections, comments are of course gratefully received.

Thanks,
Mike

Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
14 years agoverify_image: print out a statement that there are no further errors
Øyvind Harboe [Mon, 2 Aug 2010 14:55:46 +0000 (16:55 +0200)]
verify_image: print out a statement that there are no further errors

It is useful to know that the printed errors are *all* the
errors there were.

Added missing error handling(found by inspection).

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agozy1000: use correct base clock when calculating speed divisor
Øyvind Harboe [Mon, 2 Aug 2010 20:12:33 +0000 (22:12 +0200)]
zy1000: use correct base clock when calculating speed divisor

revc uses 60MHz and revb 64MHz, use this in calculations.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agozy1000: print out khz correctly in response to setting JTAG speed
Øyvind Harboe [Mon, 2 Aug 2010 15:09:57 +0000 (17:09 +0200)]
zy1000: print out khz correctly in response to setting JTAG speed

Calculate printout based on same core routines.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agolpc1768: even if rclk "works", it isn't necessarily the correct clk
Øyvind Harboe [Mon, 2 Aug 2010 11:21:21 +0000 (13:21 +0200)]
lpc1768: even if rclk "works", it isn't necessarily the correct clk

rclk = 4MHz oon lpc1768, the correct JTAG clk is 666MHz(4MHz/6).

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoioutil: fix internal fn names
Øyvind Harboe [Mon, 2 Aug 2010 09:59:46 +0000 (11:59 +0200)]
ioutil: fix internal fn names

prefix w/ioutil_

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agojtag: measure_clk debug proc
Øyvind Harboe [Mon, 2 Aug 2010 09:15:21 +0000 (11:15 +0200)]
jtag: measure_clk debug proc

It can be useful to get an approximate measurement of
rtck frequency for debugging purposes.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agojtag: add jtag_flush_queue_sleep debug command
Øyvind Harboe [Sat, 31 Jul 2010 19:45:56 +0000 (21:45 +0200)]
jtag: add jtag_flush_queue_sleep debug command

it can be useful to throttle performance: test
differences in behavior, test performance effect
of long roundtrips.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoutil: ms command to calculate length of operations
Øyvind Harboe [Sun, 1 Aug 2010 07:35:58 +0000 (09:35 +0200)]
util: ms command to calculate length of operations

This can be used to calculate approximate RTCK frequency
for instance.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoSupport NGX Technologies product NGX ARM USB JTAG
Peter Stuge [Sun, 1 Aug 2010 01:26:48 +0000 (03:26 +0200)]
Support NGX Technologies product NGX ARM USB JTAG

This is a standard FT2232 device. More info at their web page:
http://shop.ngxtechnologies.com/product_info.php?cPath=26&products_id=30

14 years agoRemove srst_pulls_trst from LPC2148 target
Peter Stuge [Sun, 1 Aug 2010 01:26:47 +0000 (03:26 +0200)]
Remove srst_pulls_trst from LPC2148 target

srst_pulls_trst is only true on some (broken) LPC2148 boards, a fact
which is already documented in doc/openocd.texi, so it shouldn't be
set unconditionally in the target tcl.

This patch was needed to reflash when an Abort exception occured very
early after reset, before OpenOCD tried to halt the CPU.

14 years agostellaris flash comment update
David Brownell [Sun, 1 Aug 2010 06:27:14 +0000 (02:27 -0400)]
stellaris flash comment update

This flash driver works on more than just two chips.
(Though it does need work still, e.g. to protect more than 64K.
(On non-'3748-A0 chips where errata allow that.))

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
14 years agolpc7168: make flash available upon reset init
Øyvind Harboe [Fri, 30 Jul 2010 20:34:43 +0000 (22:34 +0200)]
lpc7168: make flash available upon reset init

set user mode to avoid ROM being mapped at address
0 rather than flash.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years ago"transport select" returns Jim value
David Brownell [Sat, 24 Jul 2010 18:38:46 +0000 (14:38 -0400)]
"transport select" returns Jim value

Make it scriptable, so code can be conditionalized based on
what transport is in use for the session.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
14 years agoBuspirate: fix shadow
Michal Demin [Sat, 10 Jul 2010 08:08:18 +0000 (10:08 +0200)]
Buspirate: fix shadow

14 years agodocs: removed unused cmd 'fast'
Spencer Oliver [Tue, 20 Jul 2010 09:46:54 +0000 (10:46 +0100)]
docs: removed unused cmd 'fast'

The cmd fast was removed in commit c0d14dc7f19d785702eee5f69de5b1a63902554b

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
14 years agoflash: remove algorithm exit_point address for supported targets
Spencer Oliver [Mon, 19 Jul 2010 19:33:04 +0000 (20:33 +0100)]
flash: remove algorithm exit_point address for supported targets

For the above targets the exit_point is
optional when used with run_algorithm, so remove it.

This makes updating the algorithm less error prone.

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
14 years agomips32: exit_point optional for mips32_run_algorithm
Spencer Oliver [Mon, 19 Jul 2010 19:29:16 +0000 (20:29 +0100)]
mips32: exit_point optional for mips32_run_algorithm

As the mips32 uses instruction breakpoints for algorithms we do not really
need to check the pc on exit.

This now matches the behaviour of the arm codebase.

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
14 years agoarmv7m: exit_point optional for armv7m_run_algorithm
Spencer Oliver [Mon, 19 Jul 2010 19:28:30 +0000 (20:28 +0100)]
armv7m: exit_point optional for armv7m_run_algorithm

As the armv7m uses instruction breakpoints for algorithms we do not really
need to check the pc on exit.

This now matches the behaviour of the arm4_5 codebase.

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
14 years agoarmv4_5: add algorithms instruction breakpoint support
Spencer Oliver [Tue, 20 Jul 2010 08:02:10 +0000 (09:02 +0100)]
armv4_5: add algorithms instruction breakpoint support

Update the arm_checksum_memory and arm_blank_check_memory
algorithms to use a breakpoint instruction on v5 arch.

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
14 years agoarm11 error propagation fixes
Øyvind Harboe [Tue, 20 Jul 2010 06:42:52 +0000 (08:42 +0200)]
arm11 error propagation fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoarm_jtag_scann error propagation fixes
Øyvind Harboe [Tue, 20 Jul 2010 06:23:59 +0000 (08:23 +0200)]
arm_jtag_scann error propagation fixes

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoarm_dpm: error propagation fixes
Øyvind Harboe [Mon, 19 Jul 2010 12:49:41 +0000 (14:49 +0200)]
arm_dpm: error propagation fixes

found by inspection

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoadi_jtag_ error propagation
Øyvind Harboe [Mon, 19 Jul 2010 12:42:54 +0000 (14:42 +0200)]
adi_jtag_ error propagation

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoarm: error propagation of arm_jtag_set_instr
Øyvind Harboe [Mon, 19 Jul 2010 12:37:45 +0000 (14:37 +0200)]
arm: error propagation of arm_jtag_set_instr

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoarm_adi_v5: dap_run() error propagation
Øyvind Harboe [Mon, 19 Jul 2010 12:22:35 +0000 (14:22 +0200)]
arm_adi_v5: dap_run() error propagation

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoarm_adi_v5: mem_ap_write error propagation
Øyvind Harboe [Mon, 19 Jul 2010 12:03:33 +0000 (14:03 +0200)]
arm_adi_v5: mem_ap_write error propagation

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoarm_adi_v5: error propagation of mem_ap_read_atomic_u32 failure
Øyvind Harboe [Mon, 19 Jul 2010 11:56:59 +0000 (13:56 +0200)]
arm_adi_v5: error propagation of mem_ap_read_atomic_u32 failure

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agomem_ap_read_u32 error propagation
Øyvind Harboe [Mon, 19 Jul 2010 11:50:28 +0000 (13:50 +0200)]
mem_ap_read_u32 error propagation

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoarm_adi_v5: add error propagation for dap_setup_accessport
Øyvind Harboe [Mon, 19 Jul 2010 11:45:53 +0000 (13:45 +0200)]
arm_adi_v5: add error propagation for dap_setup_accessport

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agodebug: debug entry error propagation
Øyvind Harboe [Mon, 19 Jul 2010 10:34:54 +0000 (12:34 +0200)]
debug: debug entry error propagation

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agocortex a8: added timeout handling
Øyvind Harboe [Mon, 19 Jul 2010 10:17:11 +0000 (12:17 +0200)]
cortex a8: added timeout handling

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoarm: add error propagation for enable/disable mmu caches
Øyvind Harboe [Mon, 19 Jul 2010 08:58:07 +0000 (10:58 +0200)]
arm: add error propagation for enable/disable mmu caches

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agoarm: add error propagation to generic get_ttb fn
Øyvind Harboe [Mon, 19 Jul 2010 06:45:45 +0000 (08:45 +0200)]
arm: add error propagation to generic get_ttb fn

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
14 years agomore careful luminary init
David Brownell [Mon, 19 Jul 2010 20:08:09 +0000 (16:08 -0400)]
more careful luminary init

Set up more of the Luminary-specific signals, and stop cloning
a few of the JTAG defaults.  More comments too.

Still leaves the "dap info 0" bugs unresolved (presumably coupled
to this particular adapter family) where TPIU, ITM, DWT, and other
debug modules wrongly display as extra NVICs.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>