]>
git.sur5r.net Git - i3/i3/log
Michael Stapelberg [Wed, 13 Sep 2017 14:39:13 +0000 (16:39 +0200)]
Bugfix: free incomplete containers when JSON parsing fails
related to #2755
Michael Stapelberg [Wed, 13 Sep 2017 13:07:21 +0000 (15:07 +0200)]
Merge pull request #2935 from orestisf1993/issue-2934
Make sure that parse_config input terminates with '\0'
Orestis Floros [Tue, 12 Sep 2017 09:29:01 +0000 (12:29 +0300)]
scalloc parse_config input to make sure it terminates with '\0'
Otherwise strchr() can crash for files that don't end with '\n' because
it won't find a null char to terminate at.
Fixes #2934
Orestis Floros [Wed, 13 Sep 2017 10:32:12 +0000 (13:32 +0300)]
Don't insert newline at end of config with launch_with_config
Michael Stapelberg [Wed, 13 Sep 2017 08:58:38 +0000 (10:58 +0200)]
Merge pull request #2920 from CyberShadow/monitor-output-names
Consider RandR 1.5's monitors' output names in addition to monitor names
Vladimir Panteleev [Tue, 12 Sep 2017 09:27:49 +0000 (09:27 +0000)]
docs/userguide: Document that i3 can accept RandR output names
Vladimir Panteleev [Tue, 12 Sep 2017 09:18:40 +0000 (09:18 +0000)]
533-randr15.t: Add test for bar output name canonicalization
Vladimir Panteleev [Tue, 12 Sep 2017 08:50:40 +0000 (08:50 +0000)]
533-randr15.t: Stop hard-coding the output name
Refactor away all mentions of DP3.
Vladimir Panteleev [Tue, 12 Sep 2017 08:42:46 +0000 (08:42 +0000)]
533-randr15.t: Add a fake output connected to the fake monitor
Add an output ID to the simulated RRGetMonitors reply, then add a
simulated RRGetOutputInfo reply describing the added output.
Vladimir Panteleev [Tue, 12 Sep 2017 08:41:00 +0000 (08:41 +0000)]
testcases/lib: Add inject_randr15_outputinfo argument
Allow tests to specify a file name for inject_randr15's
--getoutputinfo_reply command-line parameter.
Vladimir Panteleev [Tue, 12 Sep 2017 08:39:15 +0000 (08:39 +0000)]
inject_randr1.5: Intercept X11 error responses in addition to replies
Allow clients to send garbage to the server, then intercept the
server's error response and substitute it with the supplied simulated
reply data.
Vladimir Panteleev [Tue, 12 Sep 2017 07:03:20 +0000 (07:03 +0000)]
inject_randr1.5: Add RRGetOutputInfo reply injection
Add a --getoutputinfo_reply switch to indicate a filename containing
the RRGetOutputInfo reply data to inject.
Vladimir Panteleev [Tue, 12 Sep 2017 06:58:29 +0000 (06:58 +0000)]
inject_randr1.5: Refactor reading and storing reply buffer to a struct
Allows easier introduction of additional reply buffers in upcoming
changes.
Vladimir Panteleev [Mon, 11 Sep 2017 11:15:56 +0000 (11:15 +0000)]
ipc: Canonicalize output names in bar configuration
Convert the output names specified in the "output" and "tray_output"
fields in bar blocks in i3's configuration to the referred output's
primary name. This allows specifying names other than the primary
output's name in the given fields without changing the IPC protocol.
Vladimir Panteleev [Sat, 9 Sep 2017 09:23:50 +0000 (09:23 +0000)]
randr: Look up alternative output names when searching outputs
Update get_output_by_name to look at all additional names added by the
change in the previous commit, not just the primary one.
Vladimir Panteleev [Sat, 9 Sep 2017 09:00:22 +0000 (09:00 +0000)]
randr: Register monitors' output names as additional i3 output names
In addition to the name of the monitor itself (which is still used as
the i3 output's primary name), register RandR output names associated
with the RandR monitor as alternative i3 output names.
Vladimir Panteleev [Sat, 9 Sep 2017 07:37:37 +0000 (07:37 +0000)]
Store output names as a linked list
Currently, only one name is ever added, and only the first name is
ever accessed; actually using the capability to store and access
multiple names comes in the following commits.
Vladimir Panteleev [Sat, 9 Sep 2017 07:18:29 +0000 (07:18 +0000)]
Introduce output_primary_name function
Currently simply returns output->name, but this will make it easier to
change how output names are stored in the following commits.
Also replace reading output->name with invocations of
output_primary_name. Code which writes output->name is unchanged. Done
using a mostly mechanical replacement of output->name to
output_primary_name(output).
Michael Stapelberg [Tue, 12 Sep 2017 20:16:36 +0000 (22:16 +0200)]
testsuite: install Module::Install so that AnyEvent-I3/Makefile.PL works (#2940)
As per https://perlmaven.com/cant-locate-inc-module-install-in-inc, the inc/
directory should not be under version control.
fixes #2914
Orestis [Mon, 11 Sep 2017 19:31:29 +0000 (22:31 +0300)]
Fix userguide bug (#2932)
Fixes #2931
Ingo Bürk [Mon, 11 Sep 2017 18:49:47 +0000 (20:49 +0200)]
Merge pull request #2928 from CyberShadow/pull-
20170911 -130032
docs/hacking-howto: Promote "Using git / sending patches" section
Vladimir Panteleev [Mon, 11 Sep 2017 13:09:25 +0000 (13:09 +0000)]
docs/hacking-howto: Update section topology
- Promote the "How to build?" sub-section to a top-level
section ("Building i3")
- Convert the "Introduction" sub-section as the intro to the remaining
contents of the "Using git / sending patches" section
- Keep "Which branch to use?" as a level-3 sub-section, thus making it
a sub-section of what used to be the "Introduction" sub-section.
Vladimir Panteleev [Mon, 11 Sep 2017 13:06:40 +0000 (13:06 +0000)]
docs/hacking-howto: Promote "How to build?" sub-section
Move the "How to build?" sub-section to the top of its parent section.
Vladimir Panteleev [Mon, 11 Sep 2017 13:04:58 +0000 (13:04 +0000)]
docs/hacking-howto: Promote "Using git / sending patches" section
Move the contents of the "Using git / sending patches" section to the
top of the document.
Michael Stapelberg [Sun, 10 Sep 2017 20:08:05 +0000 (22:08 +0200)]
Merge pull request #2926 from stapelberg/unflake-tests
Unflake tests
Michael Stapelberg [Sun, 10 Sep 2017 18:05:55 +0000 (20:05 +0200)]
tests: run 533-randr15.t at the very end
The test runs `xrandr setmonitor`, which will otherwise affect any test
scheduled after 533-randr15.t, causing flakyness in t/217-NET_CURRENT_DESKTOP.t
for example.
Michael Stapelberg [Sun, 10 Sep 2017 18:06:49 +0000 (20:06 +0200)]
tests: unflake t/263-edge-borders.t
Michael Stapelberg [Sun, 10 Sep 2017 17:41:49 +0000 (19:41 +0200)]
tests: re-seed random number generator in workers
Ingo Bürk [Sun, 10 Sep 2017 15:03:09 +0000 (17:03 +0200)]
Revert "Use OVER operator for drawing text (#2908)" (#2925)
This reverts commit
16160462a30f186f5b72bb551ba2188670d4e45c .
Michael Stapelberg [Sun, 10 Sep 2017 11:41:46 +0000 (13:41 +0200)]
Merge pull request #2923 from stapelberg/tests-split
Testsuite: avoid starting new i3 instances where possible
Vladimir Panteleev [Sun, 10 Sep 2017 11:02:10 +0000 (11:02 +0000)]
docs/testsuite: Correct Xephyr package name on Arch Linux (#2913)
The package is called `xorg-server-xephyr`, not `xorg-xserver-xephyr`.
Michael Stapelberg [Sun, 10 Sep 2017 09:31:10 +0000 (11:31 +0200)]
Kill windows between tests
Michael Stapelberg [Sun, 10 Sep 2017 09:30:56 +0000 (11:30 +0200)]
i3test: add kill_all_windows convenience function
Michael Stapelberg [Sun, 10 Sep 2017 09:25:43 +0000 (11:25 +0200)]
testcases/Makefile.PL: tell MakeMaker this is a pure-Perl distribution (#2922)
fixes #2914
Vladimir Panteleev [Sun, 10 Sep 2017 05:43:53 +0000 (05:43 +0000)]
Add README.md (#2910)
Michael Stapelberg [Sat, 9 Sep 2017 16:39:56 +0000 (18:39 +0200)]
529-net-wm-desktop: avoid timeout, avoid restarts, split
This shaves off almost half a second of the wall-clock time (from 5.9s to 5.6s).
Michael Stapelberg [Sat, 9 Sep 2017 16:30:17 +0000 (18:30 +0200)]
travis: remove clang-analyze (#2917)
• The output currently contains a large number of false-positives and — AFAICT —
no actual issues.
• Upstream shows little interest in addressing the long-standing issues with the
TAILQ macros, so the false-positive situation probably won’t change soon:
https://bugs.llvm.org/show_bug.cgi?id=18222
Currently, we largely spend travis CPU cycles on this, for no additional value.
Michael Stapelberg [Sat, 9 Sep 2017 16:21:59 +0000 (18:21 +0200)]
165-for_window: merge config and re-use i3 instance, split remainder
This reduces total test wall-clock time by 1.5s (from 7.5s down to 5.9s).
Michael Stapelberg [Sat, 9 Sep 2017 15:50:23 +0000 (17:50 +0200)]
t/265-swap: don’t start new i3 instances with the same config
$config is never touched after being initially set up.
Not restarting i3 between each test case reduces the runtime of this test by an
order of magnitude.
Jan Alexander Steffens [Sat, 9 Sep 2017 15:32:34 +0000 (17:32 +0200)]
Use OVER operator for drawing text (#2908)
For opaque text, SOURCE is not any different from OVER. However, when
drawing color glyphs (which consist of RGBA pixels instead of strokes)
SOURCE's handling of alpha is not what we want.
I stumbled across this because cairo 1.15.8 seems to clear the surface
before drawing color emoji if the operator is SOURCE, deleting every-
thing drawn before. Arguably, the area outside the glyph bounds should
not be touched, but even if this is a cairo bug the problem of alpha
within the glyph remains.
Orestis [Sat, 9 Sep 2017 12:47:32 +0000 (15:47 +0300)]
Add files generated by make check in AnyEvent-I3/ to .gitignore (#2915)
Michael Stapelberg [Sat, 9 Sep 2017 12:22:16 +0000 (14:22 +0200)]
Include AnyEvent-I3 directory in dist tarballs (#2916)
fixes #2905
Michael Stapelberg [Sat, 9 Sep 2017 09:41:07 +0000 (11:41 +0200)]
Merge pull request #2911 from i3/asan
i3bar: ensure get_buffer does not leak memory
Michael Stapelberg [Sat, 9 Sep 2017 06:15:03 +0000 (08:15 +0200)]
travis: downgrade temporarily due to asan issue
fixes #2912
Michael Stapelberg [Sat, 9 Sep 2017 04:56:50 +0000 (06:56 +0200)]
i3bar: ensure get_buffer does not leak memory
This fixes an AddressSanitizer warning which recently popped up.
related to #2907
Michael Stapelberg [Thu, 7 Sep 2017 12:55:37 +0000 (14:55 +0200)]
Merge pull request #2901 from orestisf1993/issue-2900
Set marks to NULL after freeing
Orestis Floros [Thu, 7 Sep 2017 00:53:28 +0000 (03:53 +0300)]
Set marks to NULL after freeing
realloc() was being called on an already freed pointer.
Fixes #2900
Orestis Floros [Thu, 7 Sep 2017 01:19:57 +0000 (04:19 +0300)]
Improve 267-regress-mark-restart.t
Another window with a mark is needed for issue #2900.
Ingo Bürk [Wed, 6 Sep 2017 15:08:02 +0000 (17:08 +0200)]
Merge pull request #2899 from orestisf1993/patch-1
Fix typo in 265-swap.t
Orestis [Wed, 6 Sep 2017 15:02:52 +0000 (18:02 +0300)]
Fix typo in 265-swap.t
Orestis [Wed, 6 Sep 2017 05:34:14 +0000 (08:34 +0300)]
Check if con_id exists in cmd_swap (#2898)
Also adds some testcases for swap using con_id.
Fixes #2895
Ingo Bürk [Tue, 5 Sep 2017 07:01:53 +0000 (09:01 +0200)]
Invert condition to log debug message in correct situation (#2896)
Ingo Bürk [Mon, 4 Sep 2017 16:44:14 +0000 (18:44 +0200)]
Merge pull request #2891 from hwangcc23/init-sigaction
Properly initialize sigaction struct
Ingo Bürk [Mon, 4 Sep 2017 16:43:42 +0000 (18:43 +0200)]
Merge pull request #2875 from botovq/next
Avoid use of uninitialized in init_dpi_end
Michael Stapelberg [Mon, 4 Sep 2017 06:21:06 +0000 (08:21 +0200)]
debian: update changelog
Michael Stapelberg [Mon, 4 Sep 2017 05:53:39 +0000 (07:53 +0200)]
Merge branch 'release-4.14'
Michael Stapelberg [Mon, 4 Sep 2017 05:53:39 +0000 (07:53 +0200)]
Set non-git version to 4.14-non-git.
Michael Stapelberg [Mon, 4 Sep 2017 05:53:25 +0000 (07:53 +0200)]
release i3 4.14
Michael Stapelberg [Thu, 31 Aug 2017 20:50:00 +0000 (22:50 +0200)]
Revert "i3-nagbar: add button flag to execute action with /bin/sh directly" (#2893)
hwangcc23 [Thu, 31 Aug 2017 14:48:33 +0000 (22:48 +0800)]
Properly initialize sigaction struct
The code in handle_signal() wasn't clearing the struct sigaction before passing it to sigaction().
This meant that we would block a random set of signals while executing the default handler, or jump to the uninitialized __sa_sigaction__ (instead of sa_handler).
Initialize properly as we do in setup_signal_handler().
Michael Stapelberg [Mon, 28 Aug 2017 10:07:56 +0000 (12:07 +0200)]
Respect focus_on_window_activation for ConfigureRequests (#2889)
fixes #2873
Michael Stapelberg [Mon, 28 Aug 2017 10:07:40 +0000 (12:07 +0200)]
Merge pull request #2888 from stapelberg/leak
Fix memory leak
Chih-Chyuan Hwang [Mon, 28 Aug 2017 07:43:42 +0000 (15:43 +0800)]
Update doc for dependency Module::Install (#2877)
After moving to AnyEvent-I3, a new testsuite dependency is introduced: Module::Install.
Update the doc for this.
See the issue #2876.
Michael Stapelberg [Mon, 28 Aug 2017 07:23:42 +0000 (09:23 +0200)]
do leak check before exiting
related to #2541
Michael Stapelberg [Mon, 28 Aug 2017 07:22:38 +0000 (09:22 +0200)]
Fix memleak: free regex when parsing fails
fixes #2541
Ingo Bürk [Sat, 26 Aug 2017 09:38:06 +0000 (11:38 +0200)]
Merge pull request #2882 from jolange/dev
docs markup fixes
Johannes Lange [Mon, 5 Jun 2017 12:30:49 +0000 (14:30 +0200)]
docs markup fixes
Theo Buehler [Wed, 23 Aug 2017 13:48:58 +0000 (15:48 +0200)]
Avoid use of uninitialized in init_dpi_end
If conn == NULL or display == NULL, init_dpi() jumps to init_dpi_end
before (declaring and) initializing resource. In init_dpi_end, there
is a free(resource) call conditionally on resource != NULL, so this
may lead to a bogus free. Found by clang -Wsometimes-uninitialized.
Ingo Bürk [Sun, 20 Aug 2017 16:07:34 +0000 (18:07 +0200)]
Merge pull request #2868 from stapelberg/mouse
t/264-keypress-numlock: add mouse binding test
Michael Stapelberg [Sun, 20 Aug 2017 16:00:10 +0000 (18:00 +0200)]
t/264-keypress-numlock: add mouse binding test
fixes #2523
Michael Stapelberg [Sun, 20 Aug 2017 15:07:23 +0000 (17:07 +0200)]
Respect dont_warp flag when moving containers (#2867)
fixes #2681
fixes #2592
Michael Stapelberg [Sun, 20 Aug 2017 13:30:27 +0000 (15:30 +0200)]
i3bar: only restart child when command changed (#2866)
this is a follow-up to
https://github.com/i3/i3/commit/
98f202dd1b2782d11a713513f5dcca2f52daab73
fixes #2689
Michael Stapelberg [Sun, 20 Aug 2017 12:56:44 +0000 (14:56 +0200)]
Focus windows upon ConfigureWindow with stack-mode=Above (#2865)
fixes #2708
fixes #2745
Michael Stapelberg [Sun, 20 Aug 2017 11:16:53 +0000 (13:16 +0200)]
Merge pull request #2864 from stapelberg/fixconfig
Improve error messages for incorrect config lines starting with “set”
Michael Stapelberg [Sun, 20 Aug 2017 11:12:06 +0000 (13:12 +0200)]
t/201-config-parser: update expected token list
Michael Stapelberg [Sun, 20 Aug 2017 10:58:13 +0000 (12:58 +0200)]
parser: only skip set[\s], not set.*
fixes #2564
Michael Stapelberg [Sun, 20 Aug 2017 10:57:26 +0000 (12:57 +0200)]
start nagbar when encountering invalid set statements
related to #2564
Michael Stapelberg [Sun, 20 Aug 2017 10:57:04 +0000 (12:57 +0200)]
Skip lines consisting only of “set”
Michael Stapelberg [Sun, 20 Aug 2017 10:55:55 +0000 (12:55 +0200)]
(Re-)initialize optional fields to empty strings
Michael Stapelberg [Sun, 20 Aug 2017 10:54:49 +0000 (12:54 +0200)]
Bugfix: check bounds before accessing memory
This fixes the following issue when having an error early in the config file:
==1562==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6220000180ff at pc 0x55c837edb1d3 bp 0x7ffee7534650 sp 0x7ffee7534648
READ of size 1 at 0x6220000180ff thread T0
#0 0x55c837edb1d2 in start_of_line ../../i3/src/config_parser.c:238
#1 0x55c837edc96f in parse_config ../../i3/src/config_parser.c:493
#2 0x55c837edf527 in parse_file ../../i3/src/config_parser.c:1091
#3 0x55c837ecf14b in parse_configuration ../../i3/src/config.c:65
#4 0x55c837ed1ef4 in load_configuration ../../i3/src/config.c:230
#5 0x55c837f0a8d0 in main ../../i3/src/main.c:539
#6 0x7fb63ae042b0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202b0)
#7 0x55c837e95eb9 in _start (/home/michael/i3/build/i3+0x4beb9)
0x6220000180ff is located 1 bytes to the left of 5165-byte region [0x622000018100,0x62200001952d)
allocated by thread T0 here:
#0 0x7fb63e590cf8 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.3+0xc1cf8)
#1 0x55c837f59aa6 in smalloc ../../i3/libi3/safewrappers.c:24
#2 0x55c837edef45 in parse_file ../../i3/src/config_parser.c:1029
#3 0x55c837ecf14b in parse_configuration ../../i3/src/config.c:65
#4 0x55c837ed1ef4 in load_configuration ../../i3/src/config.c:230
#5 0x55c837f0a8d0 in main ../../i3/src/main.c:539
#6 0x7fb63ae042b0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202b0)
Ingo Bürk [Sun, 20 Aug 2017 10:25:06 +0000 (12:25 +0200)]
Merge pull request #2863 from stapelberg/fixfreeze
i3bar: Bugfix: avoid freeze after VisibilityNotify
Michael Stapelberg [Sun, 20 Aug 2017 10:14:12 +0000 (12:14 +0200)]
i3bar: Bugfix: avoid freeze after VisibilityNotify
fixes #2790
Michael Stapelberg [Sat, 19 Aug 2017 22:19:45 +0000 (00:19 +0200)]
Bugfix: consider inactive monitors when querying (#2862)
fixes #2815
fixes #2594
Michael Stapelberg [Sat, 19 Aug 2017 17:23:02 +0000 (19:23 +0200)]
Merge pull request #2861 from stapelberg/ipcconfig
Introduce the GET_CONFIG IPC request
Michael Stapelberg [Sat, 19 Aug 2017 17:06:23 +0000 (19:06 +0200)]
Bump AnyEvent-I3 to 0.18
Michael Stapelberg [Sat, 19 Aug 2017 15:29:03 +0000 (17:29 +0200)]
Introduce the GET_CONFIG IPC request
This introduces memory usage by one copy of the config file, which is an
acceptable trade-off for being able to easily revert data loss.
The default config is 6KB, user configs will be in the same ballpark.
fixes #2856
Michael Stapelberg [Sat, 19 Aug 2017 17:05:25 +0000 (19:05 +0200)]
Makefile.am: fix anyevent-i3.stamp dependencies
Michael Stapelberg [Sat, 19 Aug 2017 16:32:04 +0000 (18:32 +0200)]
Merge pull request #2860 from stapelberg/anyevent-i3
Merge the AnyEvent-I3 repository into i3/AnyEvent-I3
Ingo Bürk [Sat, 19 Aug 2017 16:19:51 +0000 (18:19 +0200)]
Merge pull request #2859 from stapelberg/fixtests
Fix tests
Michael Stapelberg [Sat, 19 Aug 2017 14:51:51 +0000 (16:51 +0200)]
testcases: remove external AnyEvent::I3 dependency
Michael Stapelberg [Sat, 19 Aug 2017 14:32:39 +0000 (16:32 +0200)]
Move to AnyEvent-I3
Michael Stapelberg [Sun, 9 Apr 2017 13:34:36 +0000 (15:34 +0200)]
tag 0.17
Michael Stapelberg [Sun, 9 Apr 2017 13:32:04 +0000 (15:32 +0200)]
use lib '.' for Perl 5.25.11+
see also https://rt.cpan.org/Ticket/Display.html?id=120943
Tony Crisci [Fri, 6 May 2016 06:44:28 +0000 (02:44 -0400)]
Add the shutdown event (#2)
The shutdown event is triggered when the ipc shuts down because of
either a restart or when i3 exits.
Michael Stapelberg [Fri, 3 Oct 2014 07:39:10 +0000 (09:39 +0200)]
support the barconfig_update and binding event, tag 0.16
Michael Stapelberg [Mon, 18 Feb 2013 10:01:04 +0000 (11:01 +0100)]
support the window event, tag 0.15
Michael Stapelberg [Sat, 3 Nov 2012 10:47:27 +0000 (11:47 +0100)]
fix doc error: missing opening brace (Thanks bitonic)
Michael Stapelberg [Sat, 22 Sep 2012 11:11:08 +0000 (13:11 +0200)]
0.14: add support for the mode event
Michael Stapelberg [Sun, 5 Aug 2012 15:41:16 +0000 (17:41 +0200)]
update Changes file
Michael Stapelberg [Sun, 5 Aug 2012 15:31:57 +0000 (17:31 +0200)]
bump version to 0.13