]> git.sur5r.net Git - i3/i3/log
i3/i3
12 years agoupdate refcard (Thanks Moritz Bandemer)
Michael Stapelberg [Sun, 3 Jun 2012 15:17:11 +0000 (17:17 +0200)]
update refcard (Thanks Moritz Bandemer)

12 years agoRestrict "move to workspace" commands in fullscreen.
Fernando Tarlá Cardoso Lemos [Sun, 27 May 2012 01:13:16 +0000 (22:13 -0300)]
Restrict "move to workspace" commands in fullscreen.

12 years agoPrevent moving out of fullscreen containers.
Fernando Tarlá Cardoso Lemos [Sun, 27 May 2012 00:45:15 +0000 (21:45 -0300)]
Prevent moving out of fullscreen containers.

12 years agoRestrict directional focus in fullscreen.
Fernando Tarlá Cardoso Lemos [Sat, 26 May 2012 22:53:02 +0000 (19:53 -0300)]
Restrict directional focus in fullscreen.

This reuses the same fullscreen focus logic to ensure that focus
doesn't escape a fullscreen container.

12 years agoAllow focus child/parent when in fullscreen.
Fernando Tarlá Cardoso Lemos [Sat, 26 May 2012 21:36:25 +0000 (18:36 -0300)]
Allow focus child/parent when in fullscreen.

This is now restricted according to the already defined fullscreen
focus constraints. Test case 157 was removed, as we don't prevent
level up/down in fullscreen anymore. Those commands are properly
tested in fullscreen by test case 156.

Fixes: #612
12 years agoRefined the fullscreen focus constraints.
Fernando Tarlá Cardoso Lemos [Sat, 26 May 2012 20:37:45 +0000 (17:37 -0300)]
Refined the fullscreen focus constraints.

Basically, a focus change can't escape a fullscreen container. The
only exception is per-output fullscreen containers, as you should
be able to focus a container in a different workspace in this case.

This is an improvement on 4eab046e, now considering the difference
between global and per-output fullscreen and taking the tree
structure into account to determine what escaping the fullscreen
container means. It only affects targeted focus commands in the
form "for_window [...] focus", but it lays the foundation for
forthcoming fixes to all other focus commands.

12 years agoMerge branch 'master' into next
Michael Stapelberg [Wed, 30 May 2012 15:27:22 +0000 (17:27 +0200)]
Merge branch 'master' into next

12 years agoMerge branch 'use-xkb-kc2ks'
Michael Stapelberg [Wed, 30 May 2012 15:27:18 +0000 (17:27 +0200)]
Merge branch 'use-xkb-kc2ks'

12 years agoReplace deprecated XKeycodeToKeysym() with XkbKeycodeToKeysym()
David Coppa [Wed, 30 May 2012 09:11:08 +0000 (11:11 +0200)]
Replace deprecated XKeycodeToKeysym() with XkbKeycodeToKeysym()

12 years agoMerge branch 'master' into next
Michael Stapelberg [Mon, 28 May 2012 21:37:26 +0000 (23:37 +0200)]
Merge branch 'master' into next

12 years agoMerge branch 'tests-focus-parent-child'
Michael Stapelberg [Mon, 28 May 2012 21:37:22 +0000 (23:37 +0200)]
Merge branch 'tests-focus-parent-child'

12 years agoGet rid of references to level up/down.
Fernando Tarlá Cardoso Lemos [Sun, 27 May 2012 04:44:29 +0000 (01:44 -0300)]
Get rid of references to level up/down.

In v4 syntax, that's focus parent/child.

12 years agoMerge branch 'master' into next
Michael Stapelberg [Fri, 18 May 2012 07:14:38 +0000 (09:14 +0200)]
Merge branch 'master' into next

12 years agoMerge branch 'fix-keycodes'
Michael Stapelberg [Fri, 18 May 2012 07:14:34 +0000 (09:14 +0200)]
Merge branch 'fix-keycodes'

12 years agoFix errors in i3.config.keycodes (bindsym -> bindcode)
David Coppa [Thu, 17 May 2012 10:31:36 +0000 (12:31 +0200)]
Fix errors in i3.config.keycodes (bindsym -> bindcode)

12 years agoMerge branch 'master' into next
Michael Stapelberg [Wed, 16 May 2012 04:24:53 +0000 (06:24 +0200)]
Merge branch 'master' into next

12 years agoMerge branch 'fix-stray-ws-number'
Michael Stapelberg [Wed, 16 May 2012 04:24:50 +0000 (06:24 +0200)]
Merge branch 'fix-stray-ws-number'

12 years agoFix stray workspaces "number 1" being created when having workspace number 1 in your...
Michael Stapelberg [Wed, 16 May 2012 04:24:16 +0000 (06:24 +0200)]
Fix stray workspaces "number 1" being created when having workspace number 1 in your config

12 years agoMerge branch 'master' into next
Michael Stapelberg [Sat, 12 May 2012 06:24:20 +0000 (08:24 +0200)]
Merge branch 'master' into next

12 years agoMerge branch 'i3bar-fix-null'
Michael Stapelberg [Sat, 12 May 2012 06:24:09 +0000 (08:24 +0200)]
Merge branch 'i3bar-fix-null'

12 years agoi3bar: Don’t crash when full_text is missing or null in the JSON input (Thanks fernan...
Michael Stapelberg [Sat, 12 May 2012 06:23:37 +0000 (08:23 +0200)]
i3bar: Don’t crash when full_text is missing or null in the JSON input (Thanks fernandotcl)

12 years agoMerge branch 'master' into next
Michael Stapelberg [Wed, 9 May 2012 19:08:28 +0000 (21:08 +0200)]
Merge branch 'master' into next

12 years agoMerge branch 'focus-in-fullscreen'
Michael Stapelberg [Wed, 9 May 2012 19:08:25 +0000 (21:08 +0200)]
Merge branch 'focus-in-fullscreen'

12 years agoAllow focus w/ target when in fs in some cases.
Fernando Tarlá Cardoso Lemos [Sat, 21 Apr 2012 19:34:25 +0000 (16:34 -0300)]
Allow focus w/ target when in fs in some cases.

If the target is in a different workspace, there's no reason why
we wouldn't allow the user to focus it. We already allow this when
focusing a workspace, for example.

12 years agoMerge branch 'master' into next
Michael Stapelberg [Wed, 9 May 2012 18:39:26 +0000 (20:39 +0200)]
Merge branch 'master' into next

12 years agoMerge branch 'fix-workspace-number'
Michael Stapelberg [Wed, 9 May 2012 18:39:23 +0000 (20:39 +0200)]
Merge branch 'fix-workspace-number'

12 years agomaybe_back_and_forth now sets render_tree
Ondrej Grover [Wed, 2 May 2012 20:27:41 +0000 (22:27 +0200)]
maybe_back_and_forth now sets render_tree

12 years agomake maybe_back_and_forth static
Michael Stapelberg [Wed, 9 May 2012 18:34:40 +0000 (20:34 +0200)]
make maybe_back_and_forth static

12 years agobugfix: less differentiation between named and numbered workspaces
Ondrej Grover [Wed, 2 May 2012 14:05:27 +0000 (16:05 +0200)]
bugfix: less differentiation between named and numbered workspaces

calling workspace by number now also checks for switching back and forth
and creates a new workspace if no workspace starting with that number is
found

also removed the obsolete tree_render() in favor of setting
cmd_output->needs_tree_render to true

12 years agotests: add test to verify workspace_auto_back_and_forth works with 'workspace number'
Michael Stapelberg [Wed, 9 May 2012 18:33:41 +0000 (20:33 +0200)]
tests: add test to verify workspace_auto_back_and_forth works with 'workspace number'

12 years agotests: Check that 'workspace number <number>' opens a new workspace
Michael Stapelberg [Wed, 9 May 2012 18:33:11 +0000 (20:33 +0200)]
tests: Check that 'workspace number <number>' opens a new workspace

12 years agoMerge branch 'master' into next
Michael Stapelberg [Wed, 9 May 2012 18:16:15 +0000 (20:16 +0200)]
Merge branch 'master' into next

12 years agodon’t wrap when changing workspaces by mouse wheel scrolling
TunnelWicht [Tue, 1 May 2012 11:35:34 +0000 (13:35 +0200)]
don’t wrap when changing workspaces by mouse wheel scrolling

12 years agoMerge branch 'master' into next
Michael Stapelberg [Wed, 9 May 2012 18:06:45 +0000 (20:06 +0200)]
Merge branch 'master' into next

12 years agoMerge branch 'fix-static-analysis'
Michael Stapelberg [Wed, 9 May 2012 18:06:42 +0000 (20:06 +0200)]
Merge branch 'fix-static-analysis'

12 years agoremove dead code
Michael Stapelberg [Wed, 9 May 2012 18:00:46 +0000 (20:00 +0200)]
remove dead code

This was a left-over of commit 9d68d780e2ca45e231a3cb76063860c561e0453c

12 years agoremove unused variable
Michael Stapelberg [Wed, 9 May 2012 17:58:50 +0000 (19:58 +0200)]
remove unused variable

12 years agoRemove set but never read variable
Michael Stapelberg [Wed, 9 May 2012 17:56:21 +0000 (19:56 +0200)]
Remove set but never read variable

This was due to the changes in commit d25e77ce7597bf0736c610a04185c8c27694c890

12 years agoMerge branch 'master' into next
Michael Stapelberg [Wed, 9 May 2012 17:47:19 +0000 (19:47 +0200)]
Merge branch 'master' into next

12 years agoMerge branch 'fix-dump-log-errmsg'
Michael Stapelberg [Wed, 9 May 2012 17:47:10 +0000 (19:47 +0200)]
Merge branch 'fix-dump-log-errmsg'

12 years agoImprove the main error message of i3-dump-log
Michael Stapelberg [Wed, 9 May 2012 17:46:44 +0000 (19:46 +0200)]
Improve the main error message of i3-dump-log

12 years agoMove is_debug_build() to libi3/
Michael Stapelberg [Wed, 9 May 2012 17:12:20 +0000 (19:12 +0200)]
Move is_debug_build() to libi3/

12 years agoFix floating precision bug
Pavel Löbl [Sun, 6 May 2012 09:03:17 +0000 (11:03 +0200)]
Fix floating precision bug

When calculating coordinates we should multiply at first otherwise
we lose precision when i3 is compiled without sse2 support.

The following code prints "Res1: 348 Res2: 349" when compiled with
-O0 -mno-sse2 and "Res1: 349 Res2: 349" with -O0 -msee2.

Note that -msse2 is default flag on 64bit OSes.

int main() {
  double a = 349.0 / 768;
  double b = 349.0 * 768;
  int res1 = a * 768;
  int res2 = b / 768;
  printf("Res1: %d Res2: %d\n", res1, res2);
  return 0;
}

Thanks guys for helping me to hunt down this one.

12 years agot/141-resize.t: do not compare float values directly. use i3test.pm::cmp_float which...
Pavel Löbl [Sat, 5 May 2012 15:28:42 +0000 (17:28 +0200)]
t/141-resize.t: do not compare float values directly. use i3test.pm::cmp_float which compares using precision of 1e-6.

12 years agoMerge branch 'fix-invalid-cmd-reply'
Michael Stapelberg [Wed, 2 May 2012 20:02:37 +0000 (22:02 +0200)]
Merge branch 'fix-invalid-cmd-reply'

12 years agoSend proper error messages upon parser failures, use yajl for generating command...
Michael Stapelberg [Wed, 2 May 2012 20:01:50 +0000 (22:01 +0200)]
Send proper error messages upon parser failures, use yajl for generating command replies

Fixes: #693
12 years agoMerge branch 'fix-spelling'
Michael Stapelberg [Wed, 2 May 2012 18:21:03 +0000 (20:21 +0200)]
Merge branch 'fix-spelling'

12 years agoFix spelling of success
Michael Stapelberg [Wed, 2 May 2012 18:20:45 +0000 (20:20 +0200)]
Fix spelling of success

Fixes: #695
12 years agoMerge branch 'build-mac-os-x'
Michael Stapelberg [Wed, 2 May 2012 18:08:34 +0000 (20:08 +0200)]
Merge branch 'build-mac-os-x'

12 years agolog.c: len is always positive, remove useless check (Thanks Marcus)
Michael Stapelberg [Wed, 2 May 2012 18:07:59 +0000 (20:07 +0200)]
log.c: len is always positive, remove useless check (Thanks Marcus)

12 years agodon’t link against librt on Mac OS X (Thanks Marcus)
Michael Stapelberg [Wed, 2 May 2012 18:06:57 +0000 (20:06 +0200)]
don’t link against librt on Mac OS X (Thanks Marcus)

12 years agoMake log.c figure out the physical amount of memory on Mac OS X (Thanks Marcus)
Michael Stapelberg [Wed, 2 May 2012 18:05:07 +0000 (20:05 +0200)]
Make log.c figure out the physical amount of memory on Mac OS X (Thanks Marcus)

12 years agomakefile: use LDFLAGS when linking test.commands_parser (Thanks Marcus)
Michael Stapelberg [Wed, 2 May 2012 18:00:50 +0000 (20:00 +0200)]
makefile: use LDFLAGS when linking test.commands_parser (Thanks Marcus)

12 years agoMerge branch 'release-4.2'
Michael Stapelberg [Wed, 25 Apr 2012 21:30:18 +0000 (23:30 +0200)]
Merge branch 'release-4.2'

12 years agodebian: install the RELEASE-NOTES as upstream changelog for now 4.2
Michael Stapelberg [Wed, 25 Apr 2012 21:21:10 +0000 (23:21 +0200)]
debian: install the RELEASE-NOTES as upstream changelog for now

12 years agodebian: bump changelog
Michael Stapelberg [Wed, 25 Apr 2012 21:19:52 +0000 (23:19 +0200)]
debian: bump changelog

12 years ago/usr/share/applications/i3.desktop: drop the encoding key, UTF-8 is now required
Michael Stapelberg [Wed, 25 Apr 2012 21:18:22 +0000 (23:18 +0200)]
/usr/share/applications/i3.desktop: drop the encoding key, UTF-8 is now required

12 years agodebian: add i3-dump-log.1 to manpages
Michael Stapelberg [Wed, 25 Apr 2012 21:18:04 +0000 (23:18 +0200)]
debian: add i3-dump-log.1 to manpages

12 years agoadd release notes for v4.2
Michael Stapelberg [Wed, 25 Apr 2012 21:06:39 +0000 (23:06 +0200)]
add release notes for v4.2

12 years agoi3bar: don’t immediately redraw bars after kicking tray clients
Michael Stapelberg [Tue, 24 Apr 2012 10:04:07 +0000 (12:04 +0200)]
i3bar: don’t immediately redraw bars after kicking tray clients

12 years agoa few little corrections for the previous commit
Michael Stapelberg [Mon, 23 Apr 2012 21:21:51 +0000 (23:21 +0200)]
a few little corrections for the previous commit

12 years agoman/i3-input.man: Add description of options and improve examples.
Mateusz Poszwa [Sun, 22 Apr 2012 14:34:20 +0000 (16:34 +0200)]
man/i3-input.man: Add description of options and improve examples.

12 years agoi3bar: when kicking tray clients, remove them immediately
Michael Stapelberg [Sun, 22 Apr 2012 18:53:01 +0000 (20:53 +0200)]
i3bar: when kicking tray clients, remove them immediately

This should fix empty spaces showing up instead of tray icons sometimes.

12 years agoi3bar: when tray_output == primary and there is no primary output, fall back to the...
Michael Stapelberg [Sun, 22 Apr 2012 18:51:15 +0000 (20:51 +0200)]
i3bar: when tray_output == primary and there is no primary output, fall back to the first available output

12 years agoi3bar: kick tray clients after output configuration changed
Michael Stapelberg [Sun, 22 Apr 2012 18:43:52 +0000 (20:43 +0200)]
i3bar: kick tray clients after output configuration changed

This makes i3bar reflect xrandr --output foo --primary changes immediately.

12 years agoi3bar: Bugfix: Properly update the primary flag
Michael Stapelberg [Sun, 22 Apr 2012 18:43:43 +0000 (20:43 +0200)]
i3bar: Bugfix: Properly update the primary flag

12 years agoMerge branch 'master' into next
Michael Stapelberg [Sun, 22 Apr 2012 18:11:25 +0000 (20:11 +0200)]
Merge branch 'master' into next

12 years agoMerge branch 'fix-i3bar-dying-tray'
Michael Stapelberg [Sun, 22 Apr 2012 18:11:07 +0000 (20:11 +0200)]
Merge branch 'fix-i3bar-dying-tray'

12 years agoi3bar: Bugfix: Properly reparent tray clients before killing the bar window when...
Michael Stapelberg [Sun, 22 Apr 2012 18:10:29 +0000 (20:10 +0200)]
i3bar: Bugfix: Properly reparent tray clients before killing the bar window when outputs disappear

Fixes: #655
12 years agobump copyright in --version (Thanks joepd)
Michael Stapelberg [Sun, 22 Apr 2012 11:04:24 +0000 (13:04 +0200)]
bump copyright in --version (Thanks joepd)

12 years agocfgparse: accept force-xinerama as a synonym of force_xinerama
Michael Stapelberg [Sat, 21 Apr 2012 10:48:09 +0000 (12:48 +0200)]
cfgparse: accept force-xinerama as a synonym of force_xinerama

12 years agoipc: update the links to the python libraries on github (Thanks BusMaster)
Michael Stapelberg [Sat, 14 Apr 2012 18:32:41 +0000 (20:32 +0200)]
ipc: update the links to the python libraries on github (Thanks BusMaster)

12 years agoadd missing docs/refcard_style.css to git
Michael Stapelberg [Fri, 13 Apr 2012 11:38:06 +0000 (13:38 +0200)]
add missing docs/refcard_style.css to git

12 years agofix broken link in docs/debugging (Thanks nh2)
Michael Stapelberg [Fri, 13 Apr 2012 11:30:04 +0000 (13:30 +0200)]
fix broken link in docs/debugging (Thanks nh2)

12 years agodebian: update changelog with new upload, add .menu file, update email, bump standard...
Michael Stapelberg [Thu, 12 Apr 2012 14:22:58 +0000 (16:22 +0200)]
debian: update changelog with new upload, add .menu file, update email, bump standards-version, fix section

12 years agoreplace the refcard with an HTML version (by SardemFF7)
Michael Stapelberg [Thu, 12 Apr 2012 14:01:10 +0000 (16:01 +0200)]
replace the refcard with an HTML version (by SardemFF7)

This eliminates our build-depedency on latex.

12 years agotests: warp the pointer to in multi-monitor tests to avoid flaky tests
Michael Stapelberg [Mon, 9 Apr 2012 12:48:43 +0000 (14:48 +0200)]
tests: warp the pointer to in multi-monitor tests to avoid flaky tests

12 years agot/166-assign: wait until the window is definitely mapped
Michael Stapelberg [Mon, 9 Apr 2012 12:48:25 +0000 (14:48 +0200)]
t/166-assign: wait until the window is definitely mapped

12 years agot/166-assign: remove unnecessary sleeps
Michael Stapelberg [Mon, 9 Apr 2012 12:48:15 +0000 (14:48 +0200)]
t/166-assign: remove unnecessary sleeps

12 years agoImplement fake-outputs option (cmdline, cfg) for multi-monitor testing
Michael Stapelberg [Mon, 9 Apr 2012 12:27:33 +0000 (14:27 +0200)]
Implement fake-outputs option (cmdline, cfg) for multi-monitor testing

This kills the dependency on xdmx and makes the testsuite simpler
and more flexible (in the output sizes / configurations).

12 years agoOnly resize when the left/right mouse button is used, not when scrolling (Thanks...
Michael Stapelberg [Sun, 8 Apr 2012 19:04:21 +0000 (21:04 +0200)]
Only resize when the left/right mouse button is used, not when scrolling (Thanks eeemsi)

12 years agoFix warning: properly initialize 'workspace' variable
Michael Stapelberg [Sun, 8 Apr 2012 18:45:49 +0000 (20:45 +0200)]
Fix warning: properly initialize 'workspace' variable

12 years agoImplement 'rename workspace <old_name> to <new_name>'
Michael Stapelberg [Sun, 8 Apr 2012 18:34:31 +0000 (20:34 +0200)]
Implement 'rename workspace <old_name> to <new_name>'

12 years agoImplement 'move [container|window] to workspace number <number>'
Michael Stapelberg [Sun, 8 Apr 2012 18:33:46 +0000 (20:33 +0200)]
Implement 'move [container|window] to workspace number <number>'

12 years agoImplement 'workspace number <number>' to switch to named workspaces
Michael Stapelberg [Sun, 8 Apr 2012 17:17:46 +0000 (19:17 +0200)]
Implement 'workspace number <number>' to switch to named workspaces

12 years agoPrevent changing focus outside a container when scrolling on the decorations
Michael Stapelberg [Sun, 8 Apr 2012 16:33:45 +0000 (18:33 +0200)]
Prevent changing focus outside a container when scrolling on the decorations

Fixes: #557
12 years agoReplace the old fullscreen container when requesting fullscreen
Michael Stapelberg [Sun, 8 Apr 2012 15:53:37 +0000 (17:53 +0200)]
Replace the old fullscreen container when requesting fullscreen

Fixes: #510
12 years agoImplement resize <grow|shrink> <width|height>, use it in the default config
Michael Stapelberg [Sun, 8 Apr 2012 13:59:49 +0000 (15:59 +0200)]
Implement resize <grow|shrink> <width|height>, use it in the default config

Fixes: #576
12 years agoBugfix: Properly terminate lines not ending with a newline (Thanks xeen)
Michael Stapelberg [Sat, 7 Apr 2012 17:15:41 +0000 (19:15 +0200)]
Bugfix: Properly terminate lines not ending with a newline (Thanks xeen)

Previously, we didn’t check for a newline and thus could be corrupting
formerly valid UTF-8 input, such as
    echo -n '↓'

Fixes: #671
12 years agoForce WM_TAKE_FOCUS event to be sent when clicking
Michael Stapelberg [Sat, 7 Apr 2012 14:22:58 +0000 (16:22 +0200)]
Force WM_TAKE_FOCUS event to be sent when clicking

This fixes more problems with Eclipse.
See also commit 1962c30dfb3baee0fb98589aca575ae54d1142e0

12 years agoMerge branch 'fix-eclipse-focus'
Michael Stapelberg [Sat, 7 Apr 2012 14:23:39 +0000 (16:23 +0200)]
Merge branch 'fix-eclipse-focus'

12 years agoForce WM_TAKE_FOCUS event to be sent when clicking
Michael Stapelberg [Sat, 7 Apr 2012 14:22:58 +0000 (16:22 +0200)]
Force WM_TAKE_FOCUS event to be sent when clicking

This fixes more problems with Eclipse.
See also commit 1962c30dfb3baee0fb98589aca575ae54d1142e0

12 years agoadd a testcase for the previous commit
Michael Stapelberg [Thu, 5 Apr 2012 16:12:24 +0000 (18:12 +0200)]
add a testcase for the previous commit

12 years agoBug 676: if scratchpad window is active on a non-visible workspace, then "scratchpad...
Peter Bui [Tue, 20 Mar 2012 22:52:38 +0000 (18:52 -0400)]
Bug 676: if scratchpad window is active on a non-visible workspace, then "scratchpad show" should move it to the current visible workspace.

12 years agoAdded option to select primary display on tray_output
Jose Pereira [Sun, 1 Apr 2012 14:07:15 +0000 (15:07 +0100)]
Added option to select primary display on tray_output

12 years agoUse (void) instead of () for functions without args (Thanks fernandotcl)
Michael Stapelberg [Sat, 31 Mar 2012 08:53:04 +0000 (10:53 +0200)]
Use (void) instead of () for functions without args (Thanks fernandotcl)

See also:
http://article.gmane.org/gmane.linux.kernel/1268792

The C compiler will handle (void) as "no arguments" and () as "variadic
function" (equivalent to (...)) which might lead to subtle errors, such
as the one which was fixed with commit 0ea64ae4.

12 years agoi3bar: kill child processes when exit()ing (they might be stopped) (Thanks darkraven)
Michael Stapelberg [Mon, 26 Mar 2012 15:36:00 +0000 (17:36 +0200)]
i3bar: kill child processes when exit()ing (they might be stopped) (Thanks darkraven)

12 years agotestsuite: explicitly start Xdummy with -nolisten tcp
Michael Stapelberg [Mon, 26 Mar 2012 15:00:44 +0000 (17:00 +0200)]
testsuite: explicitly start Xdummy with -nolisten tcp

12 years agoA few style fixes for the previous commit
Michael Stapelberg [Mon, 26 Mar 2012 15:00:35 +0000 (17:00 +0200)]
A few style fixes for the previous commit

12 years agoUse 32bit visual only when needed. Thus we could drop the --enable-32bit-visual option.
darkraven [Thu, 1 Mar 2012 05:53:06 +0000 (13:53 +0800)]
Use 32bit visual only when needed. Thus we could drop the --enable-32bit-visual option.