From e713283605a8636541cc91987436abce8902bcf8 Mon Sep 17 00:00:00 2001 From: Michael Stapelberg Date: Tue, 11 Sep 2012 13:02:59 +0200 Subject: [PATCH] =?utf8?q?sasprintf()=20already=20handles=20errors,=20we?= =?utf8?q?=20don=E2=80=99t=20need=20to=20do=20that=20twice?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit --- src/sighandler.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/sighandler.c b/src/sighandler.c index 5d987865..c951ea9d 100644 --- a/src/sighandler.c +++ b/src/sighandler.c @@ -52,9 +52,7 @@ static int backtrace(void) { pid_t pid_parent = getpid(); char *filename = NULL; - if (sasprintf(&filename, "%s/i3-backtrace.%d.txt", tmpdir, pid_parent) == -1 - || filename == NULL) - filename = "i3-backtrace.txt"; + sasprintf(&filename, "%s/i3-backtrace.%d.txt", tmpdir, pid_parent); pid_t pid_gdb = fork(); if (pid_gdb < 0) { @@ -81,13 +79,9 @@ static int backtrace(void) { dup2(stdin_pipe[0], STDIN_FILENO); dup2(stdout_pipe[1], STDOUT_FILENO); - char *pid_s = NULL; + char *pid_s, *gdb_log_cmd; sasprintf(&pid_s, "%d", pid_parent); - - char *gdb_log_cmd = NULL; - if (sasprintf(&gdb_log_cmd, "set logging file %s", filename) == -1 - || gdb_log_cmd == NULL) - gdb_log_cmd = "set logging file i3-backtrace.txt"; + sasprintf(&gdb_log_cmd, "set logging file %s", filename); char *args[] = { "gdb", -- 2.39.5