From 12e25f326ec56a1caa7e26c07b63a27e5418f474 Mon Sep 17 00:00:00 2001 From: Quanah Gibson-Mount Date: Wed, 28 Jan 2015 18:06:39 -0600 Subject: [PATCH] Note refactoring refresh & persist presence phase --- TODO | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/TODO b/TODO index 914c09aa69..29dd5b5719 100644 --- a/TODO +++ b/TODO @@ -16,3 +16,14 @@ ITS#7926 - [18:19] this is going to be a WONTFIX for 2.4, I think [10:22] and rewriting Bind and Exop result handling [10:22] so that it's no longer a special case for overlays + +[23:34] ok, so far heap profile shows that memory use during refresh is normal +[23:35] not wonderful, but normal. mem usage grows because we're recording the present list while receiving entries in the refresh +[23:36] I'm seeing for 1.2GB of data about 235MB of presentlist +[23:36] which is pretty awful, considering presentlist is just a list of UUIDs +[23:36] being stored in an avl tree +[23:37] a btree would have been better here, and we could just use an unsorted segmented array +[23:42] for the accumulation phase anyway. we need to be able to lookup records during the delete pphase +[00:05] this stuff seriously needs a rewrite +[01:13] 2.8M records x 16 bytes per uuid so this should be no more than 48MB of overhead +[01:13] and instead it's 3-400MB -- 2.39.5