From 148ff30ec483807fb87464bfe2d53453617c2d7e Mon Sep 17 00:00:00 2001 From: Eric Bollengier Date: Fri, 10 Feb 2012 17:32:10 +0100 Subject: [PATCH] Remove bad optimization from Accurate code By returning "already seen", we didn't reply to the original question: has the file changed (must be backed up)? If your fileset contains two Include {} sections the second Include may ask for the same files than the first Include, and depending on Exclude, Wild, etc.. the answer may be "Already Seen" even if the file needs to be saved. From what I can see, Wild/Exclude are called after the accurate check. --- bacula/src/filed/accurate.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/bacula/src/filed/accurate.c b/bacula/src/filed/accurate.c index 6a2c9e6738..04bbfe43ab 100644 --- a/bacula/src/filed/accurate.c +++ b/bacula/src/filed/accurate.c @@ -282,11 +282,6 @@ bool accurate_check_file(JCR *jcr, FF_PKT *ff_pkt) ff_pkt->accurate_found = true; ff_pkt->delta_seq = elt.delta_seq; - if (elt.seen) { /* file has been seen ? */ - Dmsg1(dbglvl, "accurate %s (already seen)\n", fname); - goto bail_out; - } - decode_stat(elt.lstat, &statc, sizeof(statc), &LinkFIc); /* decode catalog stat */ if (!jcr->rerunning && (jcr->getJobLevel() == L_FULL)) { -- 2.39.5