From 22929bec528f42c1a7fbcd76adeea8daed9ba55c Mon Sep 17 00:00:00 2001 From: Simon Glass Date: Wed, 7 Jun 2017 10:28:47 -0600 Subject: [PATCH] rkcommon.c: Drop pointless assignment Assigning a variable to itself is not necessary. Drop this and also add a check for malloc() failure. Signed-off-by: Simon Glass Reported-by: Coverity (CID: 161418) Fixes: 111bcc4 (rockchip: mkimage: pad the header to 8-bytes (using a 'nop') for RK3399) --- tools/rkcommon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/rkcommon.c b/tools/rkcommon.c index fd95abc79a..a583c0caa0 100644 --- a/tools/rkcommon.c +++ b/tools/rkcommon.c @@ -380,8 +380,9 @@ int rkcommon_vrec_header(struct image_tool_params *params, /* Allocate, clear and install the header */ tparams->hdr = malloc(tparams->header_size); + if (!tparams->hdr) + return -ENOMEM; memset(tparams->hdr, 0, tparams->header_size); - tparams->header_size = tparams->header_size; /* * If someone passed in 0 for the alignment, we'd better handle -- 2.39.5