From 28a993e65614c2a50f440db5cb2e9a5b138ea152 Mon Sep 17 00:00:00 2001 From: Michael Stapelberg Date: Sun, 15 Dec 2013 14:57:04 +0100 Subject: [PATCH] replace never-true condition with a working one state->initial is set to false before calling x_push_node() since we began pushing the window stack before pushing changes. Therefore, the condition could never be true. --- src/x.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/x.c b/src/x.c index ac5498d2..6fe7df38 100644 --- a/src/x.c +++ b/src/x.c @@ -731,10 +731,9 @@ void x_push_node(Con *con) { } /* Map if map state changed, also ensure that the child window - * is changed if we are mapped *and* in initial state (meaning the - * container was empty before, but now got a child). Unmaps are handled in - * x_push_node_unmaps(). */ - if ((state->mapped != con->mapped || (con->mapped && state->initial)) && + * is changed if we are mapped and there is a new, unmapped child window. + * Unmaps are handled in x_push_node_unmaps(). */ + if ((state->mapped != con->mapped || (con->window != NULL && !state->child_mapped)) && con->mapped) { xcb_void_cookie_t cookie; -- 2.39.5