From 30107b08d7df87e4c92e413d92896a847f1c74dd Mon Sep 17 00:00:00 2001 From: Simon Glass Date: Sun, 18 Jun 2017 22:09:04 -0600 Subject: [PATCH] dtoc: Add a comment about string replace in conv_name_to_c() This function uses several separate string replaces where a regular expression might seem more reasonable. Add a comment justifying the way it is currently done. Signed-off-by: Simon Glass --- tools/dtoc/dtb_platdata.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/dtoc/dtb_platdata.py b/tools/dtoc/dtb_platdata.py index 9923892dc3..1f85343a9f 100644 --- a/tools/dtoc/dtb_platdata.py +++ b/tools/dtoc/dtb_platdata.py @@ -46,6 +46,9 @@ VAL_PREFIX = 'dtv_' def conv_name_to_c(name): """Convert a device-tree name to a C identifier + This uses multiple replace() calls instead of re.sub() since it is faster + (400ms for 1m calls versus 1000ms for the 're' version). + Args: name: Name to convert Return: -- 2.39.5