From 3777b08affb17de2ee6b1dc1436239c1fba7f99e Mon Sep 17 00:00:00 2001 From: Andreas Fritiofson Date: Wed, 10 Jul 2013 11:06:26 +0200 Subject: [PATCH] ftdi: Fix error in calloc retval check Found by clang. Change-Id: Iaa952b063779f4d392d8bdc62a3e7ce9daef2740 Signed-off-by: Andreas Fritiofson Reviewed-on: http://openocd.zylin.com/1498 Tested-by: jenkins Reviewed-by: Laszlo Papp Reviewed-by: Spencer Oliver --- src/jtag/drivers/ftdi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/jtag/drivers/ftdi.c b/src/jtag/drivers/ftdi.c index 20969c04..11a7414f 100644 --- a/src/jtag/drivers/ftdi.c +++ b/src/jtag/drivers/ftdi.c @@ -127,8 +127,10 @@ static struct signal *create_signal(const char *name) psig = &(*psig)->next; *psig = calloc(1, sizeof(**psig)); - if (*psig) - (*psig)->name = strdup(name); + if (*psig == NULL) + return NULL; + + (*psig)->name = strdup(name); if ((*psig)->name == NULL) { free(*psig); *psig = NULL; -- 2.39.5