From b850cfba4d4ce9f5dda5613c6d197648e7e65401 Mon Sep 17 00:00:00 2001 From: Michael Stapelberg Date: Wed, 14 Sep 2016 09:22:06 +0200 Subject: [PATCH] Fix memleaks by avoiding _checked variants when discarding the result Thanks psychon for pointing this out in https://github.com/i3/i3/pull/2450#discussion_r78560433! --- src/main.c | 2 +- src/x.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main.c b/src/main.c index 367ebac1..5362d077 100644 --- a/src/main.c +++ b/src/main.c @@ -826,7 +826,7 @@ int main(int argc, char *argv[]) { (uint32_t[]){XCB_GX_COPY, ~0, XCB_FILL_STYLE_SOLID, XCB_SUBWINDOW_MODE_INCLUDE_INFERIORS}); xcb_copy_area(conn, root->root, pixmap, gc, 0, 0, 0, 0, width, height); - xcb_change_window_attributes_checked(conn, root->root, XCB_CW_BACK_PIXMAP, (uint32_t[]){pixmap}); + xcb_change_window_attributes(conn, root->root, XCB_CW_BACK_PIXMAP, (uint32_t[]){pixmap}); xcb_flush(conn); xcb_free_gc(conn, gc); xcb_free_pixmap(conn, pixmap); diff --git a/src/x.c b/src/x.c index f3e02fa4..9a387749 100644 --- a/src/x.c +++ b/src/x.c @@ -789,7 +789,7 @@ void x_push_node(Con *con) { int width = MAX((int32_t)rect.width, 1); int height = MAX((int32_t)rect.height, 1); - xcb_create_pixmap_checked(conn, win_depth, con->frame_buffer.id, con->frame.id, width, height); + xcb_create_pixmap(conn, win_depth, con->frame_buffer.id, con->frame.id, width, height); draw_util_surface_init(conn, &(con->frame_buffer), con->frame_buffer.id, get_visualtype_by_id(get_visualid_by_depth(win_depth)), width, height); -- 2.39.5