From 417f709978679b1f7fa3b28a432caf09b70aefac Mon Sep 17 00:00:00 2001
From: Pierangelo Masarati <ando@openldap.org>
Date: Tue, 25 May 2004 13:35:04 +0000
Subject: [PATCH] fix previous commit

---
 servers/slapd/main.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/servers/slapd/main.c b/servers/slapd/main.c
index c66fce701e..7cd20669e6 100644
--- a/servers/slapd/main.c
+++ b/servers/slapd/main.c
@@ -190,8 +190,7 @@ usage( char *name )
 		"\t-l facility\tSyslog facility (default: LOCAL4)\n"
 #endif
 		"\t-n serverName\tService name\n"
-		"\t-o <option>[=value]\n"
-		"\t\t\tGeneric means to specify options; see slapd(8) for details\n"
+		"\t-o <opt>[=val]\tGeneric means to specify options; details in slapd(8)\n"
 #ifdef HAVE_CHROOT
 		"\t-r directory\tSandbox directory to chroot to\n"
 #endif
@@ -405,9 +404,14 @@ int main( int argc, char **argv )
 
 			for ( i = 0; !BER_BVISNULL( &option_helpers[i].oh_name ); i++ ) {
 				if ( ber_bvstrcasecmp( &option_helpers[i].oh_name, &opt ) == 0 ) {
-					if ( option_helpers[i].oh_fnc( val, option_helpers[i].oh_arg ) == -1 ) {
-						goto destroy;
+					assert( option_helpers[i].oh_fnc != NULL );
+					if ( (*option_helpers[i].oh_fnc)( val, option_helpers[i].oh_arg ) == -1 ) {
+						/* we assume the option parsing helper
+						 * issues appropriate and self-explanatory
+						 * error messages... */
+						goto stop;
 					}
+					break;
 				}
 			}
 
-- 
2.39.5