From 60bb8a8a7e19126a04c6e524e86020c364fa8d2b Mon Sep 17 00:00:00 2001 From: Marek Vasut Date: Sun, 19 Jul 2015 06:25:27 +0200 Subject: [PATCH] ddr: altera: Clean up rw_mgr_*_vfifo() part 1 Perform minor cleanup, fix data types and constify where applicable. Add kerneldoc. Signed-off-by: Marek Vasut --- drivers/ddr/altera/sequencer.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/ddr/altera/sequencer.c b/drivers/ddr/altera/sequencer.c index ff1170227e..3d0dc59a07 100644 --- a/drivers/ddr/altera/sequencer.c +++ b/drivers/ddr/altera/sequencer.c @@ -1286,17 +1286,31 @@ static uint32_t rw_mgr_mem_calibrate_read_test_all_ranks(uint32_t group, bit_chk, all_groups, 1); } -static void rw_mgr_incr_vfifo(uint32_t grp, uint32_t *v) +/** + * rw_mgr_incr_vfifo() - Increase VFIFO value + * @grp: Read/Write group + * @v: VFIFO value + * + * Increase VFIFO value. + */ +static void rw_mgr_incr_vfifo(const u32 grp, u32 *v) { writel(grp, &phy_mgr_cmd->inc_vfifo_hard_phy); (*v)++; } -static void rw_mgr_decr_vfifo(uint32_t grp, uint32_t *v) +/** + * rw_mgr_decr_vfifo() - Decrease VFIFO value + * @grp: Read/Write group + * @v: VFIFO value + * + * Decrease VFIFO value. + */ +static void rw_mgr_decr_vfifo(const u32 grp, u32 *v) { - uint32_t i; + u32 i; - for (i = 0; i < VFIFO_SIZE-1; i++) + for (i = 0; i < VFIFO_SIZE - 1; i++) rw_mgr_incr_vfifo(grp, v); } -- 2.39.5