From 6cdaa19b96ceea7fb255d88a54d7300656aa8842 Mon Sep 17 00:00:00 2001 From: Luke Howard Date: Fri, 27 Aug 2004 19:34:14 +0000 Subject: [PATCH] Remove bogus SLAPI code path which special-cased modlist == NULL This had the effect of setting the result code to LDAP_SUCCESS for modlist == NULL even on a replica when an update-ref might be set. This was causing a plugin (that implements the commit phase in a post-op plugin) to write to "read-only" replica. --- servers/slapd/modify.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/servers/slapd/modify.c b/servers/slapd/modify.c index bfb2842108..70f282a396 100644 --- a/servers/slapd/modify.c +++ b/servers/slapd/modify.c @@ -470,10 +470,6 @@ fe_op_modify( Operation *op, SlapReply *rs ) * However, the post-operation plugin should still be * called. */ - if ( modlist == NULL ) { - rs->sr_err = LDAP_SUCCESS; - send_ldap_result( op, rs ); - } else { #endif /* defined( LDAP_SLAPI ) */ /* @@ -560,8 +556,6 @@ fe_op_modify( Operation *op, SlapReply *rs ) } #if defined( LDAP_SLAPI ) - } /* modlist != NULL */ - if ( pb != NULL && slapi_int_call_plugins( op->o_bd, SLAPI_PLUGIN_POST_MODIFY_FN, pb ) < 0 ) { -- 2.39.5