From 73027a853d2d9324ef2b15d5a860da3e3126321d Mon Sep 17 00:00:00 2001 From: Simon Glass Date: Wed, 7 Jun 2017 10:28:45 -0600 Subject: [PATCH] dm: core: Supress dead-code warning in __of_get_next_child() Suppress a warning on next = next->sibling. Signed-off-by: Simon Glass Reported-by: Coverity (CID: 163245) Fixes 644ec0a (dm: core: Add livetree access functions) --- drivers/core/of_access.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/core/of_access.c b/drivers/core/of_access.c index 94ef3cc251..93a6560496 100644 --- a/drivers/core/of_access.c +++ b/drivers/core/of_access.c @@ -244,6 +244,12 @@ static struct device_node *__of_get_next_child(const struct device_node *node, return NULL; next = prev ? prev->sibling : node->child; + /* + * coverity[dead_error_line : FALSE] + * Dead code here since our current implementation of of_node_get() + * always returns NULL (Coverity CID 163245). But we leave it as is + * since we may want to implement get/put later. + */ for (; next; next = next->sibling) if (of_node_get(next)) break; -- 2.39.2