From 85903156d70aec211b3c66326aeffc6ceba6ebb4 Mon Sep 17 00:00:00 2001 From: Alamy Liu Date: Thu, 6 Aug 2015 14:45:19 -0700 Subject: [PATCH] flash/nor/jtagspi: 'retval' may be used uninitialized Problem As my compiler has "warnings being treated as errors" on, it shows the error message: error: 'retval' may be used uninitialized in this function Investigation Nothing wrong with the logic, 'retval' would have a value before returning. Just wanna get rid of the compiling "warning as error" message. Solution Provide a reasonable default value Change-Id: I712c15f82819c6c48bee9dceca8de4b18aeb29b0 Signed-off-by: Alamy Liu Reviewed-on: http://openocd.zylin.com/2905 Tested-by: jenkins Reviewed-by: Robert Jordens Reviewed-by: Andreas Fritiofson --- src/flash/nor/jtagspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/flash/nor/jtagspi.c b/src/flash/nor/jtagspi.c index 6ca5c3c2..1e623a71 100644 --- a/src/flash/nor/jtagspi.c +++ b/src/flash/nor/jtagspi.c @@ -272,7 +272,7 @@ static int jtagspi_erase(struct flash_bank *bank, int first, int last) { int sector; struct jtagspi_flash_bank *info = bank->driver_priv; - int retval; + int retval = ERROR_OK; LOG_DEBUG("erase from sector %d to sector %d", first, last); -- 2.39.5