From 8bb2bddc2c18a3643ce53e793d5bc27a40e98a4f Mon Sep 17 00:00:00 2001 From: Stephen Warren Date: Wed, 9 Oct 2013 14:28:09 -0600 Subject: [PATCH] buildman: don't fail --list-toolchains when toolchains fail When a toolchain invocation fails, an exception is thrown but not caught which then aborts the entire toolchain detection process. To solve this, request that exceptions not be thrown, since the toolchain init code already error-checks the command result. This solves e.g.: - found '/usr/bin/winegcc' Traceback (most recent call last): ... Exception: Error running '/usr/bin/winegcc --version' Change-Id: I579c72ab3b021e38b14132893c3375ea257c74f0 Signed-off-by: Stephen Warren Acked-by: Simon Glass Signed-off-by: Simon Glass (formatted to 80cols) --- tools/buildman/toolchain.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/buildman/toolchain.py b/tools/buildman/toolchain.py index a292338b6d..b64338680e 100644 --- a/tools/buildman/toolchain.py +++ b/tools/buildman/toolchain.py @@ -39,7 +39,8 @@ class Toolchain: # As a basic sanity check, run the C compiler with --version cmd = [fname, '--version'] if test: - result = command.RunPipe([cmd], capture=True, env=env) + result = command.RunPipe([cmd], capture=True, env=env, + raise_on_error=False) self.ok = result.return_code == 0 if verbose: print 'Tool chain test: ', -- 2.39.5