From 98baa45e6ac710e1722a3b646e7b9e639352a95a Mon Sep 17 00:00:00 2001 From: Kurt Zeilenga Date: Thu, 8 Apr 2004 19:56:50 +0000 Subject: [PATCH] No need to check attribute values when a is NULL --- servers/slapd/mods.c | 24 ++---------------------- 1 file changed, 2 insertions(+), 22 deletions(-) diff --git a/servers/slapd/mods.c b/servers/slapd/mods.c index 8a40ef301a..c75d4208c3 100644 --- a/servers/slapd/mods.c +++ b/servers/slapd/mods.c @@ -73,29 +73,9 @@ modify_add_values( "modify/%s: %s: no equality matching rule", op, mod->sm_desc->ad_cname.bv_val ); return LDAP_INAPPROPRIATE_MATCHING; - } - - for ( i = 0; mod->sm_values[i].bv_val != NULL; i++ ) { - /* test asserted values against existing values */ - for( matched = 0, j = 0; a->a_vals[j].bv_val != NULL; j++ ) { - if ( bvmatch( &mod->sm_values[i], &a->a_vals[j] ) ) { - if ( permissive ) { - matched++; - continue; - } - /* value exists already */ - *text = textbuf; - snprintf( textbuf, textlen, - "modify/%s: %s: value #%i already exists", - op, mod->sm_desc->ad_cname.bv_val, j ); - return LDAP_TYPE_OR_VALUE_EXISTS; - } - } - if ( permissive && matched == j ) { - /* values already exist; do nothing */ - return LDAP_SUCCESS; - } + } else { + return LDAP_SUCCESS; } } else if ( a != NULL ) { -- 2.39.5