From 9b238a8d65c5fd444422a3f32ce98b6631c88377 Mon Sep 17 00:00:00 2001 From: "Dmitrij D. Czarkoff" Date: Thu, 6 Aug 2015 17:14:38 +0200 Subject: [PATCH] Use "color_degraded" when interface has no IP On laptops one may want to have all interfaces up in order to let network prioritization manage switching between wired and wireless connection. In such cases lack of IP address is a useful hint about currently used interface, and color-coding makes it stand out more. --- src/print_eth_info.c | 5 ++++- src/print_wireless_info.c | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/print_eth_info.c b/src/print_eth_info.c index 06a1613..e2326b5 100644 --- a/src/print_eth_info.c +++ b/src/print_eth_info.c @@ -126,7 +126,10 @@ void print_eth_info(yajl_gen json_gen, char *buffer, const char *interface, cons goto out; } - START_COLOR("color_good"); + if (BEGINS_WITH(ip_address, "no IP")) + START_COLOR("color_degraded"); + else + START_COLOR("color_good"); for (walk = format_up; *walk != '\0'; walk++) { if (*walk != '%') { diff --git a/src/print_wireless_info.c b/src/print_wireless_info.c index 8b390ab..83c717e 100644 --- a/src/print_wireless_info.c +++ b/src/print_wireless_info.c @@ -342,7 +342,7 @@ void print_wireless_info(yajl_gen json_gen, char *buffer, const char *interface, if (info.flags & WIRELESS_INFO_FLAG_HAS_QUALITY) START_COLOR((info.quality < info.quality_average ? "color_degraded" : "color_good")); else - START_COLOR("color_good"); + START_COLOR((BEGINS_WITH(ip_address, "no IP") ? "color_degraded" : "color_good")); } else { walk = format_down; START_COLOR("color_bad"); -- 2.39.5