From ab2a55d22209c06e230a8646c649b5ff0577ce89 Mon Sep 17 00:00:00 2001 From: Howard Chu Date: Tue, 13 Feb 2007 11:03:41 +0000 Subject: [PATCH] Coverity error --- servers/slapd/extended.c | 2 +- servers/slapd/syncrepl.c | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/servers/slapd/extended.c b/servers/slapd/extended.c index e2420776e7..38bb96c147 100644 --- a/servers/slapd/extended.c +++ b/servers/slapd/extended.c @@ -281,7 +281,7 @@ load_extop2( LDAP_SUCCESS ) { oidm.bv_val = oidm_find( ext_oid->bv_val ); - if ( ext_oid == NULL ) { + if ( oidm.bv_val == NULL ) { return -1; } oidm.bv_len = strlen( oidm.bv_val ); diff --git a/servers/slapd/syncrepl.c b/servers/slapd/syncrepl.c index 4d9f28b3b7..ff9debc685 100644 --- a/servers/slapd/syncrepl.c +++ b/servers/slapd/syncrepl.c @@ -1628,13 +1628,11 @@ syncrepl_message_to_entry( if ( syncstate == LDAP_SYNC_PRESENT || syncstate == LDAP_SYNC_DELETE ) { /* NOTE: this could be done even before decoding the DN, * although encoding errors wouldn't be detected */ - rc = LDAP_SUCCESS; - goto done; + return LDAP_SUCCESS; } if ( entry == NULL ) { - rc = -1; - goto done; + return -1; } dnPrettyNormal( NULL, &bdn, &dn, &ndn, op->o_tmpmemctx ); -- 2.39.5