From ba7b6ddea469512ba8a34ae6342af858bf427b89 Mon Sep 17 00:00:00 2001 From: Alexander Kurz Date: Fri, 26 Feb 2016 23:38:50 +0100 Subject: [PATCH] flash/nor/faux.c: fixing check for failed malloc Error found by static code analysis using the semantic pattern null_ref2/mini_null_ref2.cocci, see coccinellery.org Change-Id: Ic817c29f0ccf2b41fc8f7d9a480ad30d6e5b7ab8 Signed-off-by: Alexander Kurz Reviewed-on: http://openocd.zylin.com/3364 Tested-by: jenkins Reviewed-by: Uwe Bonnes Reviewed-by: Andreas Fritiofson --- src/flash/nor/faux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/flash/nor/faux.c b/src/flash/nor/faux.c index 1fd1da21..8198ef52 100644 --- a/src/flash/nor/faux.c +++ b/src/flash/nor/faux.c @@ -50,7 +50,7 @@ FLASH_BANK_COMMAND_HANDLER(faux_flash_bank_command) return ERROR_FAIL; } info->memory = malloc(bank->size); - if (info == NULL) { + if (info->memory == NULL) { free(info); LOG_ERROR("no memory for flash bank info"); return ERROR_FAIL; -- 2.39.5