From c46980f6d2135ade345dadc1fb1f1f4c8bbf255a Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Tue, 14 Oct 2008 07:04:38 -0400 Subject: [PATCH] cmd_spi: remove broken signed casting for display Since we're working with unsigned data, you can't apply a signed pointer cast and then attempt to print the result. Otherwise you get wrong output when the sign bit is set like "0xFF" incorrectly extended to "0xFFFFFFFF". Signed-off-by: Mike Frysinger --- common/cmd_spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/common/cmd_spi.c b/common/cmd_spi.c index 40ee7e7dd3..1f0727b4a2 100644 --- a/common/cmd_spi.c +++ b/common/cmd_spi.c @@ -123,9 +123,8 @@ int do_spi (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) printf("Error with the SPI transaction.\n"); rcode = 1; } else { - cp = (char *)din; for(j = 0; j < ((bitlen + 7) / 8); j++) { - printf("%02X", *cp++); + printf("%02X", din[j]); } printf("\n"); } -- 2.39.5