From eb2eb369c6c2d72f0ff67091ccf443b3e9384747 Mon Sep 17 00:00:00 2001
From: Kern Sibbald <kern@sibbald.com>
Date: Thu, 15 Feb 2007 18:53:37 +0000
Subject: [PATCH] tweaks

git-svn-id: https://bacula.svn.sourceforge.net/svnroot/bacula/trunk@4182 91ce42f0-d328-0410-95d8-f526ca767f89
---
 bacula/kernstodo            | 15 +++++++++++++++
 bacula/src/filed/job.c      |  2 +-
 bacula/src/stored/dev.c     |  8 ++++----
 bacula/src/stored/fd_cmds.c |  3 ---
 bacula/technotes-2.1        |  1 +
 5 files changed, 21 insertions(+), 8 deletions(-)

diff --git a/bacula/kernstodo b/bacula/kernstodo
index 1195f92ff3..766e57a122 100644
--- a/bacula/kernstodo
+++ b/bacula/kernstodo
@@ -41,6 +41,21 @@ Document:
  
 
 Priority:
+- btape "test" command with Offline on Unmount = yes
+
+   This test is essential to Bacula.
+
+   I'm going to write one record  in file 0,
+   two records in file 1,
+   and three records in file 2
+
+   02-Feb 11:00 btape: ABORTING due to ERROR in dev.c:715
+   dev.c:714 Bad call to rewind. Device "LTO" (/dev/nst0) not open
+   02-Feb 11:00 btape: Fatal Error because: Bacula interrupted by signal 11: Segmentation violation
+   Kaboom! btape, btape got signal 11. Attempting traceback.
+
+- Why the heck doesn't bacula drop root priviledges before connecting to
+  the DB?
 - Ensure that moving a purged Volume in ua_purge.c to the RecyclePool
   does the right thing.
 - Why doesn't @"xxx abc" work in a conf file?
diff --git a/bacula/src/filed/job.c b/bacula/src/filed/job.c
index 5c8d4c55c1..89a7c52c95 100644
--- a/bacula/src/filed/job.c
+++ b/bacula/src/filed/job.c
@@ -249,7 +249,7 @@ void *handle_client_request(void *dirp)
       bnet_sig(jcr->store_bsock, BNET_TERMINATE);
    }
 
-   /* run after job */   
+   /* Run the after job */
    run_scripts(jcr, jcr->RunScripts, "ClientAfterJob");
 
    generate_daemon_event(jcr, "JobEnd");
diff --git a/bacula/src/stored/dev.c b/bacula/src/stored/dev.c
index 6a68935c7a..474fa45d41 100644
--- a/bacula/src/stored/dev.c
+++ b/bacula/src/stored/dev.c
@@ -2205,7 +2205,7 @@ ssize_t DEVICE::read(void *buf, size_t len)
 {
    ssize_t read_len ;
 
-// get_timer_count();
+   get_timer_count();
 
    if (this->is_tape()) {
       read_len = tape_read(fd, buf, len);
@@ -2213,7 +2213,7 @@ ssize_t DEVICE::read(void *buf, size_t len)
       read_len = ::read(fd, buf, len);
    }
 
-// last_tick = get_timer_count();
+   last_tick = get_timer_count();
 
    DevReadTime += last_tick;
    VolCatInfo.VolReadTime += last_tick;
@@ -2230,7 +2230,7 @@ ssize_t DEVICE::write(const void *buf, size_t len)
 {
    ssize_t write_len ;
 
-// get_timer_count();
+   get_timer_count();
 
    if (this->is_tape()) {
       write_len = tape_write(fd, buf, len);
@@ -2238,7 +2238,7 @@ ssize_t DEVICE::write(const void *buf, size_t len)
       write_len = ::write(fd, buf, len);
    }
 
-// last_tick = get_timer_count();
+   last_tick = get_timer_count();
 
    DevWriteTime += last_tick;
    VolCatInfo.VolWriteTime += last_tick;
diff --git a/bacula/src/stored/fd_cmds.c b/bacula/src/stored/fd_cmds.c
index 78a59331c9..63c163ff00 100644
--- a/bacula/src/stored/fd_cmds.c
+++ b/bacula/src/stored/fd_cmds.c
@@ -193,9 +193,6 @@ static bool append_data_cmd(JCR *jcr)
       jcr->JobType = JT_BACKUP;
       if (do_append_data(jcr)) {
          return true;
-#ifdef xxx 
-         return bnet_fsend(fd, OK_append);
-#endif
       } else {
          bnet_suppress_error_messages(fd, 1); /* ignore errors at this point */
          bnet_fsend(fd, ERROR_append);
diff --git a/bacula/technotes-2.1 b/bacula/technotes-2.1
index e28200ceff..3dcef37cd9 100644
--- a/bacula/technotes-2.1
+++ b/bacula/technotes-2.1
@@ -2,6 +2,7 @@
 
 General:
 13Feb07
+kes  Apply Eric's ClientRunScriptAfter patch to 2.0 and 2.1.
 ebl  Use btime_t instead of uint64_t in media patch.
 11Feb07
 kes  Optimize the use of the database a bit in the Status dir command.
-- 
2.39.5