From ecab881c7fcd7484420b6aa15b0f748458640191 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Marek=20Beh=C3=BAn?= Date: Fri, 6 Oct 2017 15:04:57 +0200 Subject: [PATCH] fs: btrfs: Fix usage of uninitialized variables The variable res should be initialized to 0 in these functions, because if the searched key is not found, the variable is used uninitialized. Reported-by: Coverity (CID: 167335) Reported-by: Coverity (CID: 167336) Reported-by: Coverity (CID: 167337) Signed-off-by: Marek Behun --- fs/btrfs/chunk-map.c | 2 +- fs/btrfs/dir-item.c | 2 +- fs/btrfs/inode.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/btrfs/chunk-map.c b/fs/btrfs/chunk-map.c index 48407f3331..ce7330b1b7 100644 --- a/fs/btrfs/chunk-map.c +++ b/fs/btrfs/chunk-map.c @@ -147,7 +147,7 @@ int btrfs_read_chunk_tree(void) struct btrfs_path path; struct btrfs_key key, *found_key; struct btrfs_chunk *chunk; - int res; + int res = 0; key.objectid = BTRFS_FIRST_CHUNK_TREE_OBJECTID; key.type = BTRFS_CHUNK_ITEM_KEY; diff --git a/fs/btrfs/dir-item.c b/fs/btrfs/dir-item.c index decf86eb53..970563404f 100644 --- a/fs/btrfs/dir-item.c +++ b/fs/btrfs/dir-item.c @@ -93,7 +93,7 @@ int btrfs_readdir(const struct btrfs_root *root, u64 dir, struct btrfs_path path; struct btrfs_key key, *found_key; struct btrfs_dir_item *item; - int res; + int res = 0; key.objectid = dir; key.type = BTRFS_DIR_INDEX_KEY; diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 0d3da28296..0af04278a3 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -324,7 +324,7 @@ u64 btrfs_file_read(const struct btrfs_root *root, u64 inr, u64 offset, struct btrfs_path path; struct btrfs_key key; struct btrfs_file_extent_item *extent; - int res; + int res = 0; u64 rd, rd_all = -1ULL; key.objectid = inr; -- 2.39.5