From f7b6ae2836086ed72dde6c44b7ad5d8c918b165b Mon Sep 17 00:00:00 2001 From: Orestis Floros Date: Sun, 16 Dec 2018 03:27:09 +0200 Subject: [PATCH] Fix: render_con shows floating containers on wrong workspace After 204eefc. Alternative fix: diff --git a/src/floating.c b/src/floating.c index f5c61782..6dd79668 100644 --- a/src/floating.c +++ b/src/floating.c @@ -954,7 +954,7 @@ bool floating_reposition(Con *con, Rect newrect) { con->scratchpad_state = SCRATCHPAD_CHANGED; /* Workspace change will already result in a tree_render. */ - if (!reassigned) { + if (!reassigned && workspace_is_visible(con_get_workspace(con))) { render_con(con); x_push_node(con); } but I don't think that the extra complexity is worth it. Change in handlers.c because of d2d6d6e0 where the bug also appears. Fixes #3567 --- src/floating.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/floating.c b/src/floating.c index a99d0970..4833466c 100644 --- a/src/floating.c +++ b/src/floating.c @@ -907,8 +907,7 @@ bool floating_reposition(Con *con, Rect newrect) { /* Workspace change will already result in a tree_render. */ if (!reassigned) { - render_con(con, false); - x_push_node(con); + tree_render(); } return true; } -- 2.39.5