From 3a914396df50441377f1d0f17912653dd4bba4cf Mon Sep 17 00:00:00 2001 From: Tony Crisci Date: Wed, 12 Jul 2017 17:50:19 -0400 Subject: [PATCH] libi3: Add basic validation to hex color conversion Make sure a given hex color is the expected length and begins with a hash in draw_util_hex_to_color() to avoid memory errors. fixes #2829 --- libi3/draw_util.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libi3/draw_util.c b/libi3/draw_util.c index e4f0d065..6a2e93dc 100644 --- a/libi3/draw_util.c +++ b/libi3/draw_util.c @@ -84,6 +84,11 @@ void draw_util_surface_set_size(surface_t *surface, int width, int height) { * */ color_t draw_util_hex_to_color(const char *color) { + if (strlen(color) < 6 || color[0] != '#') { + ELOG("Could not parse color: %s\n", color); + return draw_util_hex_to_color("#A9A9A9"); + } + char alpha[2]; if (strlen(color) == strlen("#rrggbbaa")) { alpha[0] = color[7]; -- 2.39.5