]> git.sur5r.net Git - groeck-it87/commitdiff
Fix FAN_TAC5 detection for IT8665E
authorGuenter Roeck <linux@roeck-us.net>
Sun, 24 Sep 2017 15:10:16 +0000 (08:10 -0700)
committerGuenter Roeck <linux@roeck-us.net>
Sun, 24 Sep 2017 15:10:16 +0000 (08:10 -0700)
FAN_TAC5 is connected if 26h[4]=0.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
it87.c

diff --git a/it87.c b/it87.c
index 594301973270f2982aa2507f3c49a26af764054f..87ee0882127e81190ea36764747da002162e6bf0 100644 (file)
--- a/it87.c
+++ b/it87.c
@@ -3237,6 +3237,10 @@ static int __init it87_find(int sioaddr, unsigned short *address,
                /* Check for pwm2, fan2 */
                if (reg29 & BIT(1))
                        sio_data->skip_pwm |= BIT(1);
+               /*
+                * Note: Table 6-1 in datasheet claims that FAN_TAC2
+                * would be enabled with 29h[2]=0.
+                */
                if (reg2d & BIT(4))
                        sio_data->skip_fan |= BIT(1);
 
@@ -3267,7 +3271,7 @@ static int __init it87_find(int sioaddr, unsigned short *address,
                                sio_data->skip_fan |= BIT(3);
                        if (reg26 & BIT(5))
                                sio_data->skip_pwm |= BIT(4);
-                       if (!(reg26 & BIT(4)))
+                       if (reg26 & BIT(4))
                                sio_data->skip_fan |= BIT(4);
                }