+#undef I3__FILE__
+#define I3__FILE__ "click.c"
/*
* vim:ts=4:sw=4:expandtab
*
* i3 - an improved dynamic tiling window manager
+ * © 2009-2012 Michael Stapelberg and contributors (see also: LICENSE)
*
- * © 2009-2011 Michael Stapelberg and contributors
- *
- * See file LICENSE for license information.
- *
- * src/click.c: Contains the handlers for button press (mouse click) events
- * because they are quite large.
+ * click.c: Button press (mouse click) events.
*
*/
+#include "all.h"
+
#include <time.h>
#include <math.h>
#include <X11/XKBlib.h>
-#include "all.h"
-
-
typedef enum { CLICK_BORDER = 0, CLICK_DECORATION = 1, CLICK_INSIDE = 2 } click_destination_t;
/*
*
*/
static bool tiling_resize_for_border(Con *con, border_t border, xcb_button_press_event_t *event) {
- DLOG("border = %d\n", border);
+ DLOG("border = %d, con = %p\n", border, con);
char way = (border == BORDER_TOP || border == BORDER_LEFT ? 'p' : 'n');
orientation_t orientation = (border == BORDER_TOP || border == BORDER_BOTTOM ? VERT : HORIZ);
Con *resize_con = con;
while (resize_con->type != CT_WORKSPACE &&
resize_con->type != CT_FLOATING_CON &&
- resize_con->parent->orientation != orientation)
+ con_orientation(resize_con->parent) != orientation)
resize_con = resize_con->parent;
+ DLOG("resize_con = %p\n", resize_con);
if (resize_con->type != CT_WORKSPACE &&
resize_con->type != CT_FLOATING_CON &&
- resize_con->parent->orientation == orientation) {
+ con_orientation(resize_con->parent) == orientation) {
first = resize_con;
second = (way == 'n') ? TAILQ_NEXT(first, nodes) : TAILQ_PREV(first, nodes_head, nodes);
if (second == TAILQ_END(&(first->nodes_head))) {
first = second;
second = tmp;
}
+ DLOG("first = %p, second = %p, resize_con = %p\n",
+ first, second, resize_con);
}
if (first == NULL || second == NULL) {
DLOG("Resize not possible\n");
return false;
}
- else {
- assert(first != second);
- assert(first->parent == second->parent);
- resize_graphical_handler(first, second, orientation, event);
- }
+
+ assert(first != second);
+ assert(first->parent == second->parent);
+
+ /* We modify the X/Y position in the event so that the divider line is at
+ * the actual position of the border, not at the position of the click. */
+ if (orientation == HORIZ)
+ event->root_x = second->rect.x;
+ else event->root_y = second->rect.y;
+
+ resize_graphical_handler(first, second, orientation, event);
DLOG("After resize handler, rendering\n");
tree_render();
* Finds out which border was clicked on and calls tiling_resize_for_border().
*
*/
-static bool tiling_resize(Con *con, xcb_button_press_event_t *event, click_destination_t dest) {
+static bool tiling_resize(Con *con, xcb_button_press_event_t *event, const click_destination_t dest) {
/* check if this was a click on the window border (and on which one) */
Rect bsr = con_border_style_rect(con);
DLOG("BORDER x = %d, y = %d for con %p, window 0x%08x\n",
event->event_x, event->event_y, con, event->event);
DLOG("checks for right >= %d\n", con->window_rect.x + con->window_rect.width);
- if (dest == CLICK_DECORATION)
+ if (dest == CLICK_DECORATION) {
+ /* The user clicked on a window decoration. We ignore the following case:
+ * The container is a h-split, tabbed or stacked container with > 1
+ * window. Decorations will end up next to each other and the user
+ * expects to switch to a window by clicking on its decoration. */
+
+ /* Since the container might either be the child *or* already a split
+ * container (in the case of a nested split container), we need to make
+ * sure that we are dealing with the split container here. */
+ Con *check_con = con;
+ if (con_is_leaf(check_con) && check_con->parent->type == CT_CON)
+ check_con = check_con->parent;
+
+ if ((check_con->layout == L_STACKED ||
+ check_con->layout == L_TABBED ||
+ con_orientation(check_con) == HORIZ) &&
+ con_num_children(check_con) > 1) {
+ DLOG("Not handling this resize, this container has > 1 child.\n");
+ return false;
+ }
return tiling_resize_for_border(con, BORDER_TOP, event);
+ }
if (event->event_x >= 0 && event->event_x <= bsr.x &&
event->event_y >= bsr.y && event->event_y <= con->rect.height + bsr.height)
* functions for resizing/dragging.
*
*/
-static int route_click(Con *con, xcb_button_press_event_t *event, bool mod_pressed, click_destination_t dest) {
+static int route_click(Con *con, xcb_button_press_event_t *event, const bool mod_pressed, const click_destination_t dest) {
DLOG("--> click properties: mod = %d, destination = %d\n", mod_pressed, dest);
DLOG("--> OUTCOME = %p\n", con);
DLOG("type = %d, name = %s\n", con->type, con->name);
/* get the floating con */
Con *floatingcon = con_inside_floating(con);
const bool proportional = (event->state & BIND_SHIFT);
+ const bool in_stacked = (con->parent->layout == L_STACKED || con->parent->layout == L_TABBED);
- /* 1: focus this con */
- con_focus(con);
+ /* 1: see if the user scrolled on the decoration of a stacked/tabbed con */
+ if (in_stacked &&
+ dest == CLICK_DECORATION &&
+ (event->detail == XCB_BUTTON_INDEX_4 ||
+ event->detail == XCB_BUTTON_INDEX_5)) {
+ DLOG("Scrolling on a window decoration\n");
+ orientation_t orientation = (con->parent->layout == L_STACKED ? VERT : HORIZ);
+ /* To prevent scrolling from going outside the container (see ticket
+ * #557), we first check if scrolling is possible at all. */
+ Con *focused = con_descend_focused(con->parent);
+ bool scroll_prev_possible = (TAILQ_PREV(focused, nodes_head, nodes) != NULL);
+ bool scroll_next_possible = (TAILQ_NEXT(focused, nodes) != NULL);
+ if (event->detail == XCB_BUTTON_INDEX_4 && scroll_prev_possible)
+ tree_next('p', orientation);
+ else if (event->detail == XCB_BUTTON_INDEX_5 && scroll_next_possible)
+ tree_next('n', orientation);
+ goto done;
+ }
- const bool in_stacked = (con->parent->layout == L_STACKED || con->parent->layout == L_TABBED);
+ /* 2: focus this con. If the workspace is on another output we need to
+ * do a workspace_show in order for i3bar (and others) to notice the
+ * change in workspace. */
+ Con *ws = con_get_workspace(con);
+ Con *focused_workspace = con_get_workspace(focused);
+
+ if (ws != focused_workspace)
+ workspace_show(ws);
+ focused_id = XCB_NONE;
+ con_focus(con);
- /* 2: for floating containers, we also want to raise them on click */
- if (floatingcon != NULL) {
+ /* 3: For floating containers, we also want to raise them on click.
+ * We will skip handling events on floating cons in fullscreen mode */
+ Con *fs = (ws ? con_get_fullscreen_con(ws, CF_OUTPUT) : NULL);
+ if (floatingcon != NULL && fs == NULL) {
floating_raise_con(floatingcon);
- /* 3: floating_modifier plus left mouse button drags */
- if (mod_pressed && event->detail == 1) {
+ /* 4: floating_modifier plus left mouse button drags */
+ if (mod_pressed && event->detail == XCB_BUTTON_INDEX_1) {
floating_drag_window(floatingcon, event);
return 1;
}
- /* 3: resize (floating) if this was a click on the left/right/bottom
+ /* 5: resize (floating) if this was a click on the left/right/bottom
* border. also try resizing (tiling) if it was a click on the top
* border, but continue if that does not work */
if (mod_pressed && event->detail == 3) {
return 1;
}
- /* 4: dragging, if this was a click on a decoration (which did not lead
+ /* 6: dragging, if this was a click on a decoration (which did not lead
* to a resize) */
if (!in_stacked && dest == CLICK_DECORATION) {
floating_drag_window(floatingcon, event);
}
if (in_stacked) {
- /* for stacked/tabbed cons, floating modifier + right click resizes the
- * parent container */
- if (mod_pressed && event->detail == 3)
- if (floating_mod_on_tiled_client(con->parent, event))
- return 1;
- goto done;
+ /* for stacked/tabbed cons, the resizing applies to the parent
+ * container */
+ con = con->parent;
}
- /* 3: floating modifier pressed, initiate a resize */
- if (mod_pressed && event->detail == 3) {
+ /* 7: floating modifier pressed, initiate a resize */
+ if (dest == CLICK_INSIDE && mod_pressed && event->detail == 3) {
if (floating_mod_on_tiled_client(con, event))
return 1;
}
- /* 4: otherwise, check for border/decoration clicks and resize */
- else if (dest == CLICK_BORDER || dest == CLICK_DECORATION) {
- DLOG("Should trry resizing (tiling)\n");
+ /* 8: otherwise, check for border/decoration clicks and resize */
+ else if ((dest == CLICK_BORDER || dest == CLICK_DECORATION) &&
+ (event->detail == XCB_BUTTON_INDEX_1 ||
+ event->detail == XCB_BUTTON_INDEX_3)) {
+ DLOG("Trying to resize (tiling)\n");
tiling_resize(con, event, dest);
}
* Then, route_click is called on the appropriate con.
*
*/
-int handle_button_press(void *ignored, xcb_connection_t *conn, xcb_button_press_event_t *event) {
+int handle_button_press(xcb_button_press_event_t *event) {
Con *con;
DLOG("Button %d pressed on window 0x%08x\n", event->state, event->event);
+ last_timestamp = event->time;
+
const uint32_t mod = config.floating_modifier;
- bool mod_pressed = (mod != 0 && (event->state & mod) == mod);
+ const bool mod_pressed = (mod != 0 && (event->state & mod) == mod);
DLOG("floating_mod = %d, detail = %d\n", mod_pressed, event->detail);
if ((con = con_by_window_id(event->event)))
return route_click(con, event, mod_pressed, CLICK_INSIDE);
projects / i3 / i3 / blobdiff