Merge pull request #1665 from Airblader/feature-1658

[i3/i3] / src / match.c

diff --git a/src/match.c b/src/match.c
index 350a2c11d0e115091e01ab7af96a31af55e29ebd..f1bc8430d45fca43db596b293dd71bfed959304d 100644 (file)
--- a/src/match.c
+++ b/src/match.c
@@ -4,7 +4,7 @@
  * vim:ts=4:sw=4:expandtab
  *
  * i3 - an improved dynamic tiling window manager
- * © 2009-2011 Michael Stapelberg and contributors (see also: LICENSE)
+ * © 2009 Michael Stapelberg and contributors (see also: LICENSE)
  *
  * A "match" is a data structure which acts like a mask or expression to match
  * certain windows or not. For example, when using commands, you can specify a
@@ -16,10 +16,8 @@
 #include "all.h"
 
 /* From sys/time.h, not sure if it’s available on all systems. */
-# define _i3_timercmp(a, b, CMP)                                                  \
-  (((a).tv_sec == (b).tv_sec) ?                                             \
-   ((a).tv_usec CMP (b).tv_usec) :                                          \
-   ((a).tv_sec CMP (b).tv_sec))
+#define _i3_timercmp(a, b, CMP) \
+    (((a).tv_sec == (b).tv_sec) ? ((a).tv_usec CMP(b).tv_usec) : ((a).tv_sec CMP(b).tv_sec))
 
 /*
  * Initializes the Match data structure. This function is necessary because the
@@ -29,8 +27,10 @@
  */
 void match_init(Match *match) {
     memset(match, 0, sizeof(Match));
-    match->dock = -1;
+    match->dock = M_DONTCHECK;
     match->urgent = U_DONTCHECK;
+    /* we use this as the placeholder value for "not set". */
+    match->window_type = UINT32_MAX;
 }
 
 /*
@@ -47,9 +47,10 @@ bool match_is_empty(Match *match) {
             match->application == NULL &&
             match->class == NULL &&
             match->instance == NULL &&
-            match->role == NULL &&
+            match->window_role == NULL &&
             match->urgent == U_DONTCHECK &&
             match->id == XCB_NONE &&
+            match->window_type == UINT32_MAX &&
             match->con_id == NULL &&
             match->dock == -1 &&
             match->floating == M_ANY);
@@ -65,17 +66,18 @@ void match_copy(Match *dest, Match *src) {
 /* The DUPLICATE_REGEX macro creates a new regular expression from the
  * ->pattern of the old one. It therefore does use a little more memory then
  *  with a refcounting system, but it’s easier this way. */
-#define DUPLICATE_REGEX(field) do { \
-    if (src->field != NULL) \
-        dest->field = regex_new(src->field->pattern); \
-} while (0)
+#define DUPLICATE_REGEX(field)                            \
+    do {                                                  \
+        if (src->field != NULL)                           \
+            dest->field = regex_new(src->field->pattern); \
+    } while (0)
 
     DUPLICATE_REGEX(title);
     DUPLICATE_REGEX(mark);
     DUPLICATE_REGEX(application);
     DUPLICATE_REGEX(class);
     DUPLICATE_REGEX(instance);
-    DUPLICATE_REGEX(role);
+    DUPLICATE_REGEX(window_role);
 }
 
 /*
@@ -121,15 +123,23 @@ bool match_matches_window(Match *match, i3Window *window) {
         }
     }
 
-    if (match->role != NULL) {
+    if (match->window_role != NULL) {
         if (window->role != NULL &&
-            regex_matches(match->role, window->role)) {
+            regex_matches(match->window_role, window->role)) {
             LOG("window_role matches (%s)\n", window->role);
         } else {
             return false;
         }
     }
 
+    if (match->window_type != UINT32_MAX) {
+        if (window->window_type == match->window_type) {
+            LOG("window_type matches (%i)\n", match->window_type);
+        } else {
+            return false;
+        }
+    }
+
     Con *con = NULL;
     if (match->urgent == U_LATEST) {
         /* if the window isn't urgent, no sense in searching */
@@ -139,7 +149,7 @@ bool match_matches_window(Match *match, i3Window *window) {
         /* if we find a window that is newer than this one, bail */
         TAILQ_FOREACH(con, &all_cons, all_cons) {
             if ((con->window != NULL) &&
-                _i3_timercmp(con->window->urgent, window->urgent, >)) {
+                _i3_timercmp(con->window->urgent, window->urgent, > )) {
                 return false;
             }
         }
@@ -155,19 +165,19 @@ bool match_matches_window(Match *match, i3Window *window) {
         TAILQ_FOREACH(con, &all_cons, all_cons) {
             if ((con->window != NULL) &&
                 (con->window->urgent.tv_sec != 0) &&
-                _i3_timercmp(con->window->urgent, window->urgent, <)) {
+                _i3_timercmp(con->window->urgent, window->urgent, < )) {
                 return false;
             }
         }
         LOG("urgent matches oldest\n");
     }
 
-    if (match->dock != -1) {
+    if (match->dock != M_DONTCHECK) {
         if ((window->dock == W_DOCK_TOP && match->dock == M_DOCK_TOP) ||
-         (window->dock == W_DOCK_BOTTOM && match->dock == M_DOCK_BOTTOM) ||
-         ((window->dock == W_DOCK_TOP || window->dock == W_DOCK_BOTTOM) &&
-          match->dock == M_DOCK_ANY) ||
-         (window->dock == W_NODOCK && match->dock == M_NODOCK)) {
+            (window->dock == W_DOCK_BOTTOM && match->dock == M_DOCK_BOTTOM) ||
+            ((window->dock == W_DOCK_TOP || window->dock == W_DOCK_BOTTOM) &&
+             match->dock == M_DOCK_ANY) ||
+            (window->dock == W_NODOCK && match->dock == M_NODOCK)) {
             LOG("dock status matches\n");
         } else {
             LOG("dock status does not match\n");
@@ -196,7 +206,7 @@ void match_free(Match *match) {
     regex_free(match->class);
     regex_free(match->instance);
     regex_free(match->mark);
-    regex_free(match->role);
+    regex_free(match->window_role);
 
     /* Second step: free the regex helper struct itself */
     FREE(match->title);
@@ -204,5 +214,5 @@ void match_free(Match *match) {
     FREE(match->class);
     FREE(match->instance);
     FREE(match->mark);
-    FREE(match->role);
+    FREE(match->window_role);
 }