-#undef I3__FILE__
-#define I3__FILE__ "window.c"
/*
* vim:ts=4:sw=4:expandtab
*
* i3 - an improved dynamic tiling window manager
- * © 2009-2012 Michael Stapelberg and contributors (see also: LICENSE)
+ * © 2009 Michael Stapelberg and contributors (see also: LICENSE)
*
* window.c: Updates window attributes (X11 hints/properties).
*
*/
#include "all.h"
+/*
+ * Frees an i3Window and all its members.
+ *
+ */
+void window_free(i3Window *win) {
+ FREE(win->class_class);
+ FREE(win->class_instance);
+ i3string_free(win->name);
+ FREE(win->ran_assignments);
+ FREE(win);
+}
+
/*
* Updates the WM_CLASS (consisting of the class and instance) for the
* given window.
/* We cannot use asprintf here since this property contains two
* null-terminated strings (for compatibility reasons). Instead, we
* use strdup() on both strings */
+ const size_t prop_length = xcb_get_property_value_length(prop);
char *new_class = xcb_get_property_value(prop);
+ const size_t class_class_index = strnlen(new_class, prop_length) + 1;
FREE(win->class_instance);
FREE(win->class_class);
- win->class_instance = sstrdup(new_class);
- if ((strlen(new_class) + 1) < xcb_get_property_value_length(prop))
- win->class_class = sstrdup(new_class + strlen(new_class) + 1);
- else win->class_class = NULL;
+ win->class_instance = sstrndup(new_class, prop_length);
+ if (class_class_index < prop_length)
+ win->class_class = sstrndup(new_class + class_class_index, prop_length - class_class_index);
+ else
+ win->class_class = NULL;
LOG("WM_CLASS changed to %s (instance), %s (class)\n",
win->class_instance, win->class_class);
}
i3string_free(win->name);
- win->name = i3string_from_utf8_with_length(xcb_get_property_value(prop),
- xcb_get_property_value_length(prop));
+
+ /* Truncate the name at the first zero byte. See #3515. */
+ const int len = xcb_get_property_value_length(prop);
+ char *name = sstrndup(xcb_get_property_value(prop), len);
+ win->name = i3string_from_utf8(name);
+ free(name);
+
+ Con *con = con_by_window_id(win->id);
+ if (con != NULL && con->title_format != NULL) {
+ i3String *name = con_parse_title_format(con);
+ ewmh_update_visible_name(win->id, i3string_as_utf8(name));
+ I3STRING_FREE(name);
+ }
win->name_x_changed = true;
LOG("_NET_WM_NAME changed to \"%s\"\n", i3string_as_utf8(win->name));
}
i3string_free(win->name);
- win->name = i3string_from_utf8_with_length(xcb_get_property_value(prop),
- xcb_get_property_value_length(prop));
+ const int len = xcb_get_property_value_length(prop);
+ char *name = sstrndup(xcb_get_property_value(prop), len);
+ win->name = i3string_from_utf8(name);
+ free(name);
+
+ Con *con = con_by_window_id(win->id);
+ if (con != NULL && con->title_format != NULL) {
+ i3String *name = con_parse_title_format(con);
+ ewmh_update_visible_name(win->id, i3string_as_utf8(name));
+ I3STRING_FREE(name);
+ }
LOG("WM_NAME changed to \"%s\"\n", i3string_as_utf8(win->name));
LOG("Using legacy window title. Note that in order to get Unicode window "
*/
void window_update_leader(i3Window *win, xcb_get_property_reply_t *prop) {
if (prop == NULL || xcb_get_property_value_length(prop) == 0) {
- DLOG("CLIENT_LEADER not set.\n");
+ DLOG("CLIENT_LEADER not set on window 0x%08x.\n", win->id);
+ win->leader = XCB_NONE;
FREE(prop);
return;
}
*/
void window_update_transient_for(i3Window *win, xcb_get_property_reply_t *prop) {
if (prop == NULL || xcb_get_property_value_length(prop) == 0) {
- DLOG("TRANSIENT_FOR not set.\n");
+ DLOG("TRANSIENT_FOR not set on window 0x%08x.\n", win->id);
+ win->transient_for = XCB_NONE;
FREE(prop);
return;
}
return;
}
- DLOG("Transient for changed to %08x\n", transient_for);
+ DLOG("Transient for changed to 0x%08x (window 0x%08x)\n", transient_for, win->id);
win->transient_for = transient_for;
DLOG("Reserved pixels changed to: left = %d, right = %d, top = %d, bottom = %d\n",
strut[0], strut[1], strut[2], strut[3]);
- win->reserved = (struct reservedpx){ strut[0], strut[1], strut[2], strut[3] };
+ win->reserved = (struct reservedpx){strut[0], strut[1], strut[2], strut[3]};
free(prop);
}
}
char *new_role;
- if (asprintf(&new_role, "%.*s", xcb_get_property_value_length(prop),
- (char*)xcb_get_property_value(prop)) == -1) {
- perror("asprintf()");
- DLOG("Could not get WM_WINDOW_ROLE\n");
- free(prop);
- return;
- }
+ sasprintf(&new_role, "%.*s", xcb_get_property_value_length(prop),
+ (char *)xcb_get_property_value(prop));
FREE(win->role);
win->role = new_role;
LOG("WM_WINDOW_ROLE changed to \"%s\"\n", win->role);
free(prop);
}
+/*
+ * Updates the _NET_WM_WINDOW_TYPE property.
+ *
+ */
+void window_update_type(i3Window *window, xcb_get_property_reply_t *reply) {
+ xcb_atom_t new_type = xcb_get_preferred_window_type(reply);
+ free(reply);
+ if (new_type == XCB_NONE) {
+ DLOG("cannot read _NET_WM_WINDOW_TYPE from window.\n");
+ return;
+ }
+
+ window->window_type = new_type;
+ LOG("_NET_WM_WINDOW_TYPE changed to %i.\n", window->window_type);
+
+ run_assignments(window);
+}
+
/*
* Updates the WM_HINTS (we only care about the input focus handling part).
*
return;
}
- win->doesnt_accept_focus = !hints.input;
- LOG("WM_HINTS.input changed to \"%d\"\n", hints.input);
+ if (hints.flags & XCB_ICCCM_WM_HINT_INPUT) {
+ win->doesnt_accept_focus = !hints.input;
+ LOG("WM_HINTS.input changed to \"%d\"\n", hints.input);
+ }
if (urgency_hint != NULL)
*urgency_hint = (xcb_icccm_wm_hints_get_urgency(&hints) != 0);
free(prop);
}
+
+/*
+ * Updates the MOTIF_WM_HINTS. The container's border style should be set to
+ * `motif_border_style' if border style is not BS_NORMAL.
+ *
+ * i3 only uses this hint when it specifies a window should have no
+ * title bar, or no decorations at all, which is how most window managers
+ * handle it.
+ *
+ * The EWMH spec intended to replace Motif hints with _NET_WM_WINDOW_TYPE, but
+ * it is still in use by popular widget toolkits such as GTK+ and Java AWT.
+ *
+ */
+void window_update_motif_hints(i3Window *win, xcb_get_property_reply_t *prop, border_style_t *motif_border_style) {
+/* This implementation simply mirrors Gnome's Metacity. Official
+ * documentation of this hint is nowhere to be found.
+ * For more information see:
+ * https://people.gnome.org/~tthurman/docs/metacity/xprops_8h-source.html
+ * https://stackoverflow.com/questions/13787553/detect-if-a-x11-window-has-decorations
+ */
+#define MWM_HINTS_FLAGS_FIELD 0
+#define MWM_HINTS_DECORATIONS_FIELD 2
+
+#define MWM_HINTS_DECORATIONS (1 << 1)
+#define MWM_DECOR_ALL (1 << 0)
+#define MWM_DECOR_BORDER (1 << 1)
+#define MWM_DECOR_TITLE (1 << 3)
+
+ if (motif_border_style != NULL)
+ *motif_border_style = BS_NORMAL;
+
+ if (prop == NULL || xcb_get_property_value_length(prop) == 0) {
+ FREE(prop);
+ return;
+ }
+
+ /* The property consists of an array of 5 uint32_t's. The first value is a
+ * bit mask of what properties the hint will specify. We are only interested
+ * in MWM_HINTS_DECORATIONS because it indicates that the third value of the
+ * array tells us which decorations the window should have, each flag being
+ * a particular decoration. Notice that X11 (Xlib) often mentions 32-bit
+ * fields which in reality are implemented using unsigned long variables
+ * (64-bits long on amd64 for example). On the other hand,
+ * xcb_get_property_value() behaves strictly according to documentation,
+ * i.e. returns 32-bit data fields. */
+ uint32_t *motif_hints = (uint32_t *)xcb_get_property_value(prop);
+
+ if (motif_border_style != NULL &&
+ motif_hints[MWM_HINTS_FLAGS_FIELD] & MWM_HINTS_DECORATIONS) {
+ if (motif_hints[MWM_HINTS_DECORATIONS_FIELD] & MWM_DECOR_ALL ||
+ motif_hints[MWM_HINTS_DECORATIONS_FIELD] & MWM_DECOR_TITLE)
+ *motif_border_style = BS_NORMAL;
+ else if (motif_hints[MWM_HINTS_DECORATIONS_FIELD] & MWM_DECOR_BORDER)
+ *motif_border_style = BS_PIXEL;
+ else
+ *motif_border_style = BS_NONE;
+ }
+
+ FREE(prop);
+
+#undef MWM_HINTS_FLAGS_FIELD
+#undef MWM_HINTS_DECORATIONS_FIELD
+#undef MWM_HINTS_DECORATIONS
+#undef MWM_DECOR_ALL
+#undef MWM_DECOR_BORDER
+#undef MWM_DECOR_TITLE
+}
projects / i3 / i3 / blobdiff