+#undef I3__FILE__
+#define I3__FILE__ "window.c"
/*
* vim:ts=4:sw=4:expandtab
*
* i3 - an improved dynamic tiling window manager
- * © 2009-2012 Michael Stapelberg and contributors (see also: LICENSE)
+ * © 2009 Michael Stapelberg and contributors (see also: LICENSE)
*
* window.c: Updates window attributes (X11 hints/properties).
*
/* We cannot use asprintf here since this property contains two
* null-terminated strings (for compatibility reasons). Instead, we
* use strdup() on both strings */
+ const size_t prop_length = xcb_get_property_value_length(prop);
char *new_class = xcb_get_property_value(prop);
+ const size_t class_class_index = strnlen(new_class, prop_length) + 1;
FREE(win->class_instance);
FREE(win->class_class);
- win->class_instance = sstrdup(new_class);
- if ((strlen(new_class) + 1) < xcb_get_property_value_length(prop))
- win->class_class = sstrdup(new_class + strlen(new_class) + 1);
- else win->class_class = NULL;
+ win->class_instance = sstrndup(new_class, prop_length);
+ if (class_class_index < prop_length)
+ win->class_class = sstrndup(new_class + class_class_index, prop_length - class_class_index);
+ else
+ win->class_class = NULL;
LOG("WM_CLASS changed to %s (instance), %s (class)\n",
win->class_instance, win->class_class);
return;
}
- /* Save the old pointer to make the update atomic */
- char *new_name;
- if (asprintf(&new_name, "%.*s", xcb_get_property_value_length(prop),
- (char*)xcb_get_property_value(prop)) == -1) {
- perror("asprintf()");
- DLOG("Could not get window name\n");
- free(prop);
- return;
- }
- /* Convert it to UCS-2 here for not having to convert it later every time we want to pass it to X */
- size_t len;
- xcb_char2b_t *ucs2_name = convert_utf8_to_ucs2(new_name, &len);
- if (ucs2_name == NULL) {
- LOG("Could not convert _NET_WM_NAME to UCS-2, ignoring new hint\n");
- FREE(new_name);
- free(prop);
- return;
- }
- FREE(win->name_x);
- FREE(win->name_json);
- win->name_json = new_name;
- win->name_x = (char*)ucs2_name;
- win->name_len = len;
+ i3string_free(win->name);
+ win->name = i3string_from_utf8_with_length(xcb_get_property_value(prop),
+ xcb_get_property_value_length(prop));
win->name_x_changed = true;
- LOG("_NET_WM_NAME changed to \"%s\"\n", win->name_json);
+ LOG("_NET_WM_NAME changed to \"%s\"\n", i3string_as_utf8(win->name));
win->uses_net_wm_name = true;
return;
}
- char *new_name;
- if (asprintf(&new_name, "%.*s", xcb_get_property_value_length(prop),
- (char*)xcb_get_property_value(prop)) == -1) {
- perror("asprintf()");
- DLOG("Could not get legacy window name\n");
- free(prop);
- return;
- }
+ i3string_free(win->name);
+ win->name = i3string_from_utf8_with_length(xcb_get_property_value(prop),
+ xcb_get_property_value_length(prop));
- LOG("WM_NAME changed to \"%s\"\n", new_name);
+ LOG("WM_NAME changed to \"%s\"\n", i3string_as_utf8(win->name));
LOG("Using legacy window title. Note that in order to get Unicode window "
"titles in i3, the application has to set _NET_WM_NAME (UTF-8)\n");
- FREE(win->name_x);
- FREE(win->name_json);
- win->name_x = new_name;
- win->name_json = sstrdup(new_name);
- win->name_len = strlen(new_name);
win->name_x_changed = true;
if (before_mgmt) {
*/
void window_update_leader(i3Window *win, xcb_get_property_reply_t *prop) {
if (prop == NULL || xcb_get_property_value_length(prop) == 0) {
- DLOG("CLIENT_LEADER not set.\n");
+ DLOG("CLIENT_LEADER not set on window 0x%08x.\n", win->id);
+ win->leader = XCB_NONE;
FREE(prop);
return;
}
*/
void window_update_transient_for(i3Window *win, xcb_get_property_reply_t *prop) {
if (prop == NULL || xcb_get_property_value_length(prop) == 0) {
- DLOG("TRANSIENT_FOR not set.\n");
+ DLOG("TRANSIENT_FOR not set on window 0x%08x.\n", win->id);
+ win->transient_for = XCB_NONE;
FREE(prop);
return;
}
return;
}
- DLOG("Transient for changed to %08x\n", transient_for);
+ DLOG("Transient for changed to 0x%08x (window 0x%08x)\n", transient_for, win->id);
win->transient_for = transient_for;
DLOG("Reserved pixels changed to: left = %d, right = %d, top = %d, bottom = %d\n",
strut[0], strut[1], strut[2], strut[3]);
- win->reserved = (struct reservedpx){ strut[0], strut[1], strut[2], strut[3] };
+ win->reserved = (struct reservedpx){strut[0], strut[1], strut[2], strut[3]};
free(prop);
}
char *new_role;
if (asprintf(&new_role, "%.*s", xcb_get_property_value_length(prop),
- (char*)xcb_get_property_value(prop)) == -1) {
+ (char *)xcb_get_property_value(prop)) == -1) {
perror("asprintf()");
DLOG("Could not get WM_WINDOW_ROLE\n");
free(prop);
free(prop);
}
+/*
+ * Updates the _NET_WM_WINDOW_TYPE property.
+ *
+ */
+void window_update_type(i3Window *window, xcb_get_property_reply_t *reply) {
+ xcb_atom_t new_type = xcb_get_preferred_window_type(reply);
+ if (new_type == XCB_NONE) {
+ DLOG("cannot read _NET_WM_WINDOW_TYPE from window.\n");
+ return;
+ }
+
+ window->window_type = new_type;
+ LOG("_NET_WM_WINDOW_TYPE changed to %i.\n", window->window_type);
+
+ run_assignments(window);
+}
+
/*
* Updates the WM_HINTS (we only care about the input focus handling part).
*
*/
-void window_update_hints(i3Window *win, xcb_get_property_reply_t *prop) {
+void window_update_hints(i3Window *win, xcb_get_property_reply_t *prop, bool *urgency_hint) {
+ if (urgency_hint != NULL)
+ *urgency_hint = false;
+
if (prop == NULL || xcb_get_property_value_length(prop) == 0) {
DLOG("WM_HINTS not set.\n");
FREE(prop);
return;
}
- win->doesnt_accept_focus = !hints.input;
- LOG("WM_HINTS.input changed to \"%d\"\n", hints.input);
+ if (hints.flags & XCB_ICCCM_WM_HINT_INPUT) {
+ win->doesnt_accept_focus = !hints.input;
+ LOG("WM_HINTS.input changed to \"%d\"\n", hints.input);
+ }
+
+ if (urgency_hint != NULL)
+ *urgency_hint = (xcb_icccm_wm_hints_get_urgency(&hints) != 0);
free(prop);
}
+
+/*
+ * Updates the MOTIF_WM_HINTS. The container's border style should be set to
+ * `motif_border_style' if border style is not BS_NORMAL.
+ *
+ * i3 only uses this hint when it specifies a window should have no
+ * title bar, or no decorations at all, which is how most window managers
+ * handle it.
+ *
+ * The EWMH spec intended to replace Motif hints with _NET_WM_WINDOW_TYPE, but
+ * it is still in use by popular widget toolkits such as GTK+ and Java AWT.
+ *
+ */
+void window_update_motif_hints(i3Window *win, xcb_get_property_reply_t *prop, border_style_t *motif_border_style) {
+/* This implementation simply mirrors Gnome's Metacity. Official
+ * documentation of this hint is nowhere to be found.
+ * For more information see:
+ * https://people.gnome.org/~tthurman/docs/metacity/xprops_8h-source.html
+ * http://stackoverflow.com/questions/13787553/detect-if-a-x11-window-has-decorations
+ */
+#define MWM_HINTS_DECORATIONS (1 << 1)
+#define MWM_DECOR_ALL (1 << 0)
+#define MWM_DECOR_BORDER (1 << 1)
+#define MWM_DECOR_TITLE (1 << 3)
+
+ if (motif_border_style != NULL)
+ *motif_border_style = BS_NORMAL;
+
+ if (prop == NULL || xcb_get_property_value_length(prop) == 0) {
+ FREE(prop);
+ return;
+ }
+
+ /* The property consists of an array of 5 uint64_t's. The first value is a bit
+ * mask of what properties the hint will specify. We are only interested in
+ * MWM_HINTS_DECORATIONS because it indicates that the second value of the
+ * array tells us which decorations the window should have, each flag being
+ * a particular decoration. */
+ uint64_t *motif_hints = (uint64_t *)xcb_get_property_value(prop);
+
+ if (motif_border_style != NULL && motif_hints[0] & MWM_HINTS_DECORATIONS) {
+ if (motif_hints[1] & MWM_DECOR_ALL || motif_hints[1] & MWM_DECOR_TITLE)
+ *motif_border_style = BS_NORMAL;
+ else if (motif_hints[1] & MWM_DECOR_BORDER)
+ *motif_border_style = BS_PIXEL;
+ else
+ *motif_border_style = BS_NONE;
+ }
+
+ FREE(prop);
+
+#undef MWM_HINTS_DECORATIONS
+#undef MWM_DECOR_ALL
+#undef MWM_DECOR_BORDER
+#undef MWM_DECOR_TITLE
+}
projects / i3 / i3 / blobdiff