]> git.sur5r.net Git - i3/i3/commit - src/bindings.c
compare modifiers for equality, not subset (+test) 2784/head
authorMichael Stapelberg <michael@stapelberg.de>
Wed, 24 May 2017 18:42:27 +0000 (20:42 +0200)
committerMichael Stapelberg <michael@stapelberg.de>
Wed, 24 May 2017 18:42:27 +0000 (20:42 +0200)
commita4f6387911b4b79ca864052012c5cbace584eb2e
tree6d3972a6442be0e875fdec1d542bccb68ec2943d
parent26f5edb97fb3dcc0659c3ae5fff5b816f80d57e5
compare modifiers for equality, not subset (+test)

Subset comparison was introduced with the rather large commit
bf3cd41b5ddf1e757515ab5fbf811be56e5f69cc, but I now think we should use
equality.

In other words, the following key binding:

    bindsym Mod4+x nop Mod4+x

previously would have been triggered when pressing Mod3+Mod4+x.

Strictly speaking, this is a change of behavior, but it breaks none of our
tests, and using equality instead of subset comparison enables more use-cases.

fixes #2002
src/bindings.c
testcases/t/264-keypress-numlock.t