]> git.sur5r.net Git - i3/i3/commit
Fix: render_con shows floating containers on wrong workspace 3568/head
authorOrestis Floros <orestisf1993@gmail.com>
Sun, 16 Dec 2018 01:27:09 +0000 (03:27 +0200)
committerOrestis Floros <orestisf1993@gmail.com>
Sun, 16 Dec 2018 01:49:21 +0000 (03:49 +0200)
commit318528e3fcc472e8ee1d39cda56bbe86d5b3f720
tree8e26afafefed4a8b749c2ae909618ea36aee9977
parenta68542c8f7f3bb2b1579c12b55c9d9ebd2cb293d
Fix: render_con shows floating containers on wrong workspace

After 204eefc. Alternative fix:
    diff --git a/src/floating.c b/src/floating.c
    index f5c61782..6dd79668 100644
    --- a/src/floating.c
    +++ b/src/floating.c
    @@ -954,7 +954,7 @@ bool floating_reposition(Con *con, Rect newrect) {
             con->scratchpad_state = SCRATCHPAD_CHANGED;

         /* Workspace change will already result in a tree_render. */
    -    if (!reassigned) {
    +    if (!reassigned && workspace_is_visible(con_get_workspace(con))) {
             render_con(con);
             x_push_node(con);
         }
but I don't think that the extra complexity is worth it.

Change in handlers.c because of d2d6d6e0 where the bug also appears.

Fixes #3567
src/floating.c
src/handlers.c