Show unlock indicator if password was entered during PAM verification

[i3/i3lock] / unlock_indicator.c

diff --git a/unlock_indicator.c b/unlock_indicator.c
index 8834f0012d58906eae8b3937de9161ac956e1f41..3b94d1765f2d02bb0c80df4dc8779c41231365c3 100644 (file)
--- a/unlock_indicator.c
+++ b/unlock_indicator.c
@@ -1,7 +1,7 @@
 /*
  * vim:ts=4:sw=4:expandtab
  *
- * © 2010-2014 Michael Stapelberg
+ * © 2010 Michael Stapelberg
  *
  * See LICENSE for licensing information
  *
@@ -45,9 +45,8 @@ extern uint32_t last_resolution[2];
 /* Whether the unlock indicator is enabled (defaults to true). */
 extern bool unlock_indicator;
 
-/* Whether the capslock and numlock mods are active or not. */
-extern bool capslock_active;
-extern bool numlock_active;
+/* List of pressed modifiers, or NULL if none are pressed. */
+extern char *modifier_string;
 
 /* A Cairo surface containing the specified image (-i), if any. */
 extern cairo_surface_t *img;
@@ -141,7 +140,8 @@ xcb_pixmap_t draw_image(uint32_t *resolution) {
         cairo_fill(xcb_ctx);
     }
 
-    if (unlock_state >= STATE_KEY_PRESSED && unlock_indicator) {
+    if (unlock_indicator &&
+        (unlock_state >= STATE_KEY_PRESSED || pam_state > STATE_PAM_IDLE)) {
         cairo_scale(ctx, scaling_factor(), scaling_factor());
         /* Draw a (centered) circle with transparent background. */
         cairo_set_line_width(ctx, 10.0);
@@ -234,27 +234,19 @@ xcb_pixmap_t draw_image(uint32_t *resolution) {
             cairo_close_path(ctx);
         }
 
-        if (pam_state == STATE_PAM_WRONG && (capslock_active || numlock_active)) {
+        if (pam_state == STATE_PAM_WRONG && (modifier_string != NULL)) {
             cairo_text_extents_t extents;
             double x, y;
-            char *lock_text = NULL;
 
-            if (asprintf(&lock_text, "%s%s%s locked",
-                        capslock_active ? "Caps" : "",
-                        capslock_active && numlock_active ? ", " : "",
-                        numlock_active ? "Num" : "") != -1) {
-                cairo_set_font_size(ctx, 14.0);
+            cairo_set_font_size(ctx, 14.0);
 
-                cairo_text_extents(ctx, lock_text, &extents);
-                x = BUTTON_CENTER - ((extents.width / 2) + extents.x_bearing);
-                y = BUTTON_CENTER - ((extents.height / 2) + extents.y_bearing) + 28.0;
-
-                cairo_move_to(ctx, x, y);
-                cairo_show_text(ctx, lock_text);
-                cairo_close_path(ctx);
+            cairo_text_extents(ctx, modifier_string, &extents);
+            x = BUTTON_CENTER - ((extents.width / 2) + extents.x_bearing);
+            y = BUTTON_CENTER - ((extents.height / 2) + extents.y_bearing) + 28.0;
 
-                free(lock_text);
-            }
+            cairo_move_to(ctx, x, y);
+            cairo_show_text(ctx, modifier_string);
+            cairo_close_path(ctx);
         }
 
         /* After the user pressed any valid key or the backspace key, we
@@ -331,6 +323,7 @@ xcb_pixmap_t draw_image(uint32_t *resolution) {
  *
  */
 void redraw_screen(void) {
+    DEBUG("redraw_screen(unlock_state = %d, pam_state = %d)\n", unlock_state, pam_state);
     xcb_pixmap_t bg_pixmap = draw_image(last_resolution);
     xcb_change_window_attributes(conn, win, XCB_CW_BACK_PIXMAP, (uint32_t[1]){bg_pixmap});
     /* XXX: Possible optimization: Only update the area in the middle of the