Don’t perror("connect") when there most likely is no IPv6 connectivity

[i3/i3status] / src / get_ipv6_addr.c

diff --git a/src/get_ipv6_addr.c b/src/get_ipv6_addr.c
index 95a06a6ec6163a3754a36da47f3cf495768fc6f2..aa09d3a2ed7e515a18602f2bdef5ed83be21dd6d 100644 (file)
--- a/src/get_ipv6_addr.c
+++ b/src/get_ipv6_addr.c
@@ -21,19 +21,31 @@ const char *get_ipv6_addr() {
         memset(&hints, 0, sizeof(struct addrinfo));
         hints.ai_family = AF_INET6;
 
+        /* We resolve the K root server to get a public IPv6 address. You can
+         * replace this with any other host which has an AAAA record, but the
+         * K root server is a pretty safe bet. */
         if (getaddrinfo("k.root-servers.net", "domain", &hints, &result) != 0) {
                 perror("getaddrinfo()");
                 return "no IP";
         }
 
         for (resp = result; resp != NULL; resp = resp->ai_next) {
-                if ((fd = socket(resp->ai_family, SOCK_STREAM, 0)) == -1) {
+                if ((fd = socket(resp->ai_family, SOCK_DGRAM, 0)) == -1) {
                         perror("socket()");
                         continue;
                 }
 
+                /* Since the socket was created with SOCK_DGRAM, this is
+                 * actually not establishing a connection or generating
+                 * any other network traffic. Instead, as a side-effect,
+                 * it saves the local address with which packets would
+                 * be sent to the destination. */
                 if (connect(fd, resp->ai_addr, resp->ai_addrlen) == -1) {
-                        perror("connect()");
+                        /* We don’t display the error here because most
+                         * likely, there just is no IPv6 connectivity.
+                         * Thus, don’t spam the user’s console but just
+                         * try the next address. */
+                        (void)close(fd);
                         continue;
                 }
 
@@ -41,18 +53,21 @@ const char *get_ipv6_addr() {
                 socklen_t local_len = sizeof(struct sockaddr_storage);
                 if (getsockname(fd, (struct sockaddr*)&local, &local_len) == -1) {
                         perror("getsockname()");
+                        (void)close(fd);
                         return "no IP";
                 }
 
+                (void)close(fd);
+
                 memset(buf, 0, INET6_ADDRSTRLEN + 1);
                 int ret;
-                if ((ret = getnameinfo((struct sockaddr*)&local, local_len, buf, sizeof(buf), NULL, 0, NI_NUMERICHOST)) != 0) {
+                if ((ret = getnameinfo((struct sockaddr*)&local, local_len,
+                                       buf, sizeof(buf), NULL, 0,
+                                       NI_NUMERICHOST)) != 0) {
                         fprintf(stderr, "getnameinfo(): %s\n", gai_strerror(ret));
                         return "no IP";
                 }
 
-                (void)close(fd);
-
                 free(result);
                 return buf;
         }