// vim:ts=4:sw=4:expandtab
+#include <config.h>
+#if defined(__linux__)
+#include <sys/sysinfo.h>
+#endif
#include <stdlib.h>
#include <limits.h>
#include <stdio.h>
int diff_idle, diff_total, diff_usage;
bool colorful_output = false;
-#if defined(LINUX)
+#if defined(__linux__)
// Detecting if CPU count has changed
- int curr_cpu_count = sysconf(_SC_NPROCESSORS_ONLN);
+ int curr_cpu_count = get_nprocs_conf();
if (curr_cpu_count != cpu_count) {
cpu_count = curr_cpu_count;
free(prev_cpus);
curr_cpus = (struct cpu_usage *)calloc(cpu_count, sizeof(struct cpu_usage));
}
+ memcpy(curr_cpus, prev_cpus, cpu_count * sizeof(struct cpu_usage));
char buf[4096];
+ curr_cpu_count = get_nprocs();
if (!slurp(path, buf, sizeof(buf)))
goto error;
// Parsing all cpu values using strtok
if (strtok(buf, "\n") == NULL)
goto error;
char *buf_itr = NULL;
- for (int cpu_idx = 0; cpu_idx < cpu_count; cpu_idx++) {
+ for (int idx = 0; idx < curr_cpu_count; ++idx) {
buf_itr = strtok(NULL, "\n");
- int curr_cpu_idx = -1;
- if (!buf_itr || sscanf(buf_itr, "cpu%d %d %d %d %d", &curr_cpu_idx, &curr_cpus[cpu_idx].user, &curr_cpus[cpu_idx].nice, &curr_cpus[cpu_idx].system, &curr_cpus[cpu_idx].idle) != 5 || curr_cpu_idx != cpu_idx)
+ int cpu_idx, user, nice, system, idle;
+ if (!buf_itr || sscanf(buf_itr, "cpu%d %d %d %d %d", &cpu_idx, &user, &nice, &system, &idle) != 5) {
+ goto error;
+ }
+ if (cpu_idx < 0 || cpu_idx >= cpu_count)
goto error;
- curr_cpus[cpu_idx].total = curr_cpus[cpu_idx].user + curr_cpus[cpu_idx].nice + curr_cpus[cpu_idx].system + curr_cpus[cpu_idx].idle;
+ curr_cpus[cpu_idx].user = user;
+ curr_cpus[cpu_idx].nice = nice;
+ curr_cpus[cpu_idx].system = system;
+ curr_cpus[cpu_idx].idle = idle;
+ curr_cpus[cpu_idx].total = user + nice + system + idle;
+ }
+ for (int cpu_idx = 0; cpu_idx < cpu_count; cpu_idx++) {
curr_all.user += curr_cpus[cpu_idx].user;
curr_all.nice += curr_cpus[cpu_idx].nice;
curr_all.system += curr_cpus[cpu_idx].system;
outwalk += sprintf(outwalk, "%02d%s", diff_usage, pct_mark);
walk += strlen("usage");
}
-#if defined(LINUX)
+#if defined(__linux__)
else if (BEGINS_WITH(walk + 1, "cpu")) {
- int number = 0;
+ int number = -1;
sscanf(walk + 1, "cpu%d", &number);
- if (number < 0 || number >= cpu_count) {
- fprintf(stderr, "provided CPU number '%d' above detected number of CPU %d\n", number, cpu_count);
+ if (number == -1) {
+ fprintf(stderr, "i3status: provided CPU number cannot be parsed\n");
+ } else if (number >= cpu_count) {
+ fprintf(stderr, "i3status: provided CPU number '%d' above detected number of CPU %d\n", number, cpu_count);
} else {
int cpu_diff_idle = curr_cpus[number].idle - prev_cpus[number].idle;
int cpu_diff_total = curr_cpus[number].total - prev_cpus[number].total;
}
int padding = 1;
int step = 10;
- while (step < number) {
+ while (step <= number) {
step *= 10;
padding++;
}
}
}
- for (int i = 0; i < cpu_count; i++)
- prev_cpus[i] = curr_cpus[i];
+ struct cpu_usage *temp_cpus = prev_cpus;
+ prev_cpus = curr_cpus;
+ curr_cpus = temp_cpus;
if (colorful_output)
END_COLOR;