From: Michael Stapelberg Date: Mon, 7 May 2012 06:27:28 +0000 (+0200) Subject: Use (void) instead of () for functions without args (Thanks fernandotcl) X-Git-Tag: 2.5.1~4 X-Git-Url: https://git.sur5r.net/?p=i3%2Fi3status;a=commitdiff_plain;h=4ddd115af8e6247788c78dc3630d37f2f4493e03 Use (void) instead of () for functions without args (Thanks fernandotcl) See also: http://article.gmane.org/gmane.linux.kernel/1268792 The C compiler will handle (void) as "no arguments" and () as "variadic function" (equivalent to (...)) which might lead to subtle errors. --- diff --git a/i3status.c b/i3status.c index 3c5e3ce..15c58da 100644 --- a/i3status.c +++ b/i3status.c @@ -121,7 +121,7 @@ static char *resolve_tilde(const char *path) { return result; } -static char *get_config_path() { +static char *get_config_path(void) { char *xdg_config_home, *xdg_config_dirs, *config_path; /* 1: check the traditional path under the home directory */ diff --git a/src/auto_detect_format.c b/src/auto_detect_format.c index 7c4d65d..46e5f95 100644 --- a/src/auto_detect_format.c +++ b/src/auto_detect_format.c @@ -29,7 +29,7 @@ * We then check whether the pipe target’s name is known and chose the format. * */ -char *auto_detect_format() { +char *auto_detect_format(void) { pid_t myppid = getppid(); pid_t mypid = getpid(); diff --git a/src/output.c b/src/output.c index c0c1480..c4a2d27 100644 --- a/src/output.c +++ b/src/output.c @@ -32,13 +32,13 @@ char *color(const char *colorstr) { * Some color formats (xmobar) require to terminate colors again * */ -char *endcolor() { +char *endcolor(void) { if (output_format == O_XMOBAR) return ""; else return ""; } -void print_seperator() { +void print_seperator(void) { if (output_format == O_DZEN2) printf("^fg(%s)^p(5;-2)^ro(2)^p()^fg()^p(5)", cfg_getstr(cfg_general, "color_separator")); else if (output_format == O_XMOBAR) diff --git a/src/print_ipv6_addr.c b/src/print_ipv6_addr.c index 21974f3..f987b59 100644 --- a/src/print_ipv6_addr.c +++ b/src/print_ipv6_addr.c @@ -64,7 +64,7 @@ static char *get_sockname(struct addrinfo *addr) { * Returns the IPv6 address with which you have connectivity at the moment. * The char * is statically allocated and mustn't be freed */ -static char *get_ipv6_addr() { +static char *get_ipv6_addr(void) { struct addrinfo hints; struct addrinfo *result, *resp; static struct addrinfo *cached = NULL;