]> git.sur5r.net Git - openocd/commit
at91sam7: ensure probed flash bank has a name (fix a segfault)
authorAurelien Jacobs <aurel@gnuage.org>
Mon, 17 Oct 2011 12:49:18 +0000 (14:49 +0200)
committerSpencer Oliver <spen@spen-soft.co.uk>
Tue, 15 Nov 2011 09:27:50 +0000 (09:27 +0000)
commit67c3ad8c403ec552cff6a499f8834f369f928c4f
tree142d8c86f44aceaefe1aa3dd1812a262d138a14a
parenta943ec1ca9e8ef742ce0c0ae6b15acff960675ef
at91sam7: ensure probed flash bank has a name (fix a segfault)

Before this commit, openocd used to segfault when probing flash
of an at91sam7x512 (which contains 2 banks of flash). This was due
to the way it systematically insert a new flash bank without setting
its name.
Then, when get_flash_bank_by_name_noprobe() is called, it is doing
a strcmp() on the non-initialized bank->name.

This commit prevents allocation of second probed bank if it is already
allocated (for example, if it is set in a target config file). If a
new bank really needs to be allocated, it ensures that a default name
is set.

Change-Id: I38d15bef1fda2ec746efad37171975136cf7b371
Signed-off-by: Aurelien Jacobs <aurel@gnuage.org>
Reviewed-on: http://openocd.zylin.com/171
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
src/flash/nor/at91sam7.c